From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1AB0C433F5 for ; Sat, 19 Feb 2022 08:52:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7CE0083B88; Sat, 19 Feb 2022 09:52:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 3B81283B9F; Sat, 19 Feb 2022 09:52:19 +0100 (CET) Received: from Atcsqr.andestech.com (exmail.andestech.com [60.248.187.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2357E838F5 for ; Sat, 19 Feb 2022 09:52:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 21J8pcIj002965; Sat, 19 Feb 2022 16:51:38 +0800 (+08) (envelope-from ycliang@andestech.com) Received: from ubuntu01 (10.0.12.75) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Sat, 19 Feb 2022 16:51:38 +0800 Date: Sat, 19 Feb 2022 08:51:32 +0000 From: Leo Liang To: Alexandre Ghiti CC: Rick Chen , Aurelien Jarno , Heinrich Schuchardt , , Subject: Re: [PATCH] riscv: Fix build against binutils 2.38 Message-ID: References: <20220128134713.2322800-1-alexandre.ghiti@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) X-Originating-IP: [10.0.12.75] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 21J8pcIj002965 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Alex, On Thu, Feb 17, 2022 at 11:28:46AM +0100, Alexandre Ghiti wrote: > Hi Leo, > > On Thu, Feb 17, 2022 at 10:25 AM Leo Liang wrote: > > > > Hi Alexandre, > > On Fri, Jan 28, 2022 at 02:47:13PM +0100, Alexandre Ghiti wrote: > > > The following description is copied from the equivalent patch for the > > > Linux Kernel proposed by Aurelien Jarno: > > > > > > From version 2.38, binutils default to ISA spec version 20191213. This > > > means that the csr read/write (csrr*/csrw*) instructions and fence.i > > > instruction has separated from the `I` extension, become two standalone > > > extensions: Zicsr and Zifencei. As the kernel uses those instruction, > > > this causes the following build failure: > > > > > > arch/riscv/cpu/mtrap.S: Assembler messages: > > > arch/riscv/cpu/mtrap.S:65: Error: unrecognized opcode `csrr a0,scause' > > > arch/riscv/cpu/mtrap.S:66: Error: unrecognized opcode `csrr a1,sepc' > > > arch/riscv/cpu/mtrap.S:67: Error: unrecognized opcode `csrr a2,stval' > > > arch/riscv/cpu/mtrap.S:70: Error: unrecognized opcode `csrw sepc,a0' > > > > > > Signed-off-by: Alexandre Ghiti > > > --- > > > arch/riscv/Makefile | 11 ++++++++++- > > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > This patch seems to fail CI somehow. > > (https://source.denx.de/u-boot/custodians/u-boot-riscv/-/pipelines/11004) > > > > Could you take a look at it ? > > I have just tried on master (commit ab8903a24db1) and it failed for > the same reason, so this is not related to this patch. Nevertheless, > I'll try to bisect the problem :) > > Thanks, > > Alex > Thanks for putting the effort into it! AFAIK, this patch does nothing related to the error message "undefined reference to `__ashldi3'" from the failed CI. Nonetheless, I have tried a few times myself, and found that CI could pass with ab8903a24db1 but cannot pass with this patch on my side. https://source.denx.de/u-boot/custodians/u-boot-riscv/-/commits/staging https://source.denx.de/u-boot/custodians/u-boot-riscv/-/pipelines Best regards, Leo > > > > Best regards, > > Leo