From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19BEBC4321E for ; Wed, 9 Mar 2022 07:37:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8A3FA83982; Wed, 9 Mar 2022 08:37:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ztkQ4Z6D"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 20AAD8393F; Wed, 9 Mar 2022 08:37:21 +0100 (CET) Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0C51783998 for ; Wed, 9 Mar 2022 08:37:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ed1-x530.google.com with SMTP id y12so1656576edc.13 for ; Tue, 08 Mar 2022 23:37:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DvLQL5U7ljNwQzT7EJDHs4d8vfYgQsZRXGqfbMftgvI=; b=ztkQ4Z6D8FRb92tGQ5cCsUsmJNj+wc+KTQFXgUNgGJ9lrYKjtbPgymHETIqHaGBcx2 EwdoPdU4nY49xnT7EjcAaUkFHkowZy7KfPgWeavuuwhbY09YF0d4vta045VkxluN6F6M Zo1fyXogkftFBSgiH0B1SHl65lI+cOSAKAboNSp+LCMCsMinlz1IEjL0xrwUG1fiuujf c0MESnWFvnA6ha79T7CcbojfAmgrRyaWdpY22aDsetF2RbR4wNhfJqH+JrJDJVmEIRGe o+7XoMWmWYF1H3LrLMsbZ0zHEUc5t1FTZK57TDwA4NllqBic1gdazDVIZ0xLHawRYGpZ reAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DvLQL5U7ljNwQzT7EJDHs4d8vfYgQsZRXGqfbMftgvI=; b=iABzc+b17Qm0DarmfpuDqyLhrJUZyJRLXZZ1l+cFTT6BFVHGLb+0Zg8h22sIDDlKu1 /Xm+nDhB2WbTxPypH39uuvF/QBGs62YPV55MAQYMLbxeug2WAU0upsOU2L/WJcLK190U Xgv9p0vTPJ7WiTGrUusriHWUXQ99rSIHZsM/S5b836+AL3GAE4Hq/QTRuLwpn+yYeEC5 KziMvsi2QTx+L0GCQSfiIeEArLaw23QZu88mHOVXsJprDSTxknO0uzLfjZWIEsDnA9ip riUwW9YpzJcs6oz8gw2rKoaLipG0dZnatJ3pF+/VYlmNvYKGEKfkjYEM7NtRCAzdLFW+ hIdQ== X-Gm-Message-State: AOAM530t/fh0hj2ITWww6aaHCgrht4bVOqNmh54O8Kzn5ZVyWYSBzzOp MEv3HeM50lJpIcOYV8+fUQ4fsw== X-Google-Smtp-Source: ABdhPJxxxmohjngoMv8O5HbO19p+BXqHdOTFj0qTgjzQFIlLPwhsxlcPD3dUXVCnHzwdt94QmKP/kg== X-Received: by 2002:a05:6402:5144:b0:416:3513:8c1f with SMTP id n4-20020a056402514400b0041635138c1fmr15642880edd.355.1646811434613; Tue, 08 Mar 2022 23:37:14 -0800 (PST) Received: from hades (athedsl-4461682.home.otenet.gr. [94.71.4.98]) by smtp.gmail.com with ESMTPSA id jl2-20020a17090775c200b006dabe8887b8sm387675ejc.21.2022.03.08.23.37.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 23:37:14 -0800 (PST) Date: Wed, 9 Mar 2022 09:37:11 +0200 From: Ilias Apalodimas To: Sughosh Ganu Cc: u-boot@lists.denx.de, Simon Glass , Heinrich Schuchardt Subject: Re: [PATCH v3 2/8] tpm: Fix the return type of tpm_startup Message-ID: References: <20220304133429.1047752-1-sughosh.ganu@linaro.org> <20220304133429.1047752-3-sughosh.ganu@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220304133429.1047752-3-sughosh.ganu@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Fri, Mar 04, 2022 at 07:04:23PM +0530, Sughosh Ganu wrote: > The tpm_startup function returns negative values for error > conditions. Fix the return type of the function to a signed int > instead of a u32. > > Signed-off-by: Sughosh Ganu > Reviewed-by: Simon Glass > --- > > Changes since V2: None > > include/tpm_api.h | 2 +- > lib/tpm_api.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/tpm_api.h b/include/tpm_api.h > index 249a966942..4d77a49719 100644 > --- a/include/tpm_api.h > +++ b/include/tpm_api.h > @@ -18,7 +18,7 @@ > * @param mode TPM startup mode > * Return: return code of the operation > */ > -u32 tpm_startup(struct udevice *dev, enum tpm_startup_type mode); > +int tpm_startup(struct udevice *dev, enum tpm_startup_type mode); > > /** > * Issue a TPM_SelfTestFull command. > diff --git a/lib/tpm_api.c b/lib/tpm_api.c > index 7d26ea2c3a..da48058abe 100644 > --- a/lib/tpm_api.c > +++ b/lib/tpm_api.c > @@ -11,7 +11,8 @@ > #include > #include > > -u32 tpm_startup(struct udevice *dev, enum tpm_startup_type mode) > + > +int tpm_startup(struct udevice *dev, enum tpm_startup_type mode) > { > if (tpm_is_v1(dev)) { > return tpm1_startup(dev, mode); > -- > 2.25.1 > Reviewed-by: Ilias Apalodimas