From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DF8BC433EF for ; Wed, 30 Mar 2022 09:31:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E93C3840A4; Wed, 30 Mar 2022 11:31:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=linux.intel.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="EGkkMo0h"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E58FA840AA; Wed, 30 Mar 2022 11:31:10 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A40148408D for ; Wed, 30 Mar 2022 11:30:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=linux.intel.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=andriy.shevchenko@linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648632664; x=1680168664; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=AXJeQq8cvVBQ8UAWPVX2WPrQlKyHgKeuyBL2iFvNzZM=; b=EGkkMo0hod0iCJmAOc7yI66gW9HCPWeBWTtxloH8kCGNsXKvvCnPsZzx 8nTHltQA7cMzoklMJvPMUkNjUw3qWH+8EWt5KQeSiu0DTtHfQKKxE+bAr sqCD2s7/NK8Pu9Bnu6sialUqdGrO+CGfTkAq2a9h5bJ3nTrYx4XUVNBdE mWVO9IihYFAwjLbaq+owzbLkQAURUQflHnV+iJ/ikC23UIyWzWWMeGYYV zrZVyMGCHeYVrGrmBVZsc62MpMhy9u0pn0XNIGFD3h6KpqA9BCK90EpoW EMs1BLDsGrLpiasb7vh60yzpha+vffn2RHJf7IHUfkm7wSxJv//z8aiba g==; X-IronPort-AV: E=McAfee;i="6200,9189,10301"; a="240093597" X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="240093597" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2022 02:30:55 -0700 X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="649803010" Received: from smile.fi.intel.com ([10.237.72.59]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2022 02:30:53 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nZUei-009JMg-Oz; Wed, 30 Mar 2022 12:30:20 +0300 Date: Wed, 30 Mar 2022 12:30:20 +0300 From: Andy Shevchenko To: Simon Glass Cc: Heinrich Schuchardt , u-boot@lists.denx.de, Bin Meng Subject: Re: [PATCH v1 1/2] hexdump: Introduce debug APIs Message-ID: References: <20211109120255.77679-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Sat, Nov 13, 2021 at 11:14:28AM -0700, Simon Glass wrote: > On Tue, 9 Nov 2021 at 05:03, Andy Shevchenko > wrote: > > > > debug_hex_dump() and debug_hex_dump_bytes() conditionally print > > the dump based on DEBUG definition. > > > > Signed-off-by: Andy Shevchenko > > --- > > include/hexdump.h | 4 ++++ > > lib/hexdump.c | 60 ++++++++++++++++++++++++++++++++++++++++------- > > 2 files changed, 56 insertions(+), 8 deletions(-) > > +Heinrich Schuchardt Heinrich, it's several months passed. What should we do? > Is it possible to resolve this in the header file? It is a bit odd to > have to add DEBUG to hexdump.c in order to get debug output. > > Note also the logging system so you can do > > log(LOG_CATEGORY, dbg ? LOGL_DEBUG : LOGL_INFO, "fmt ...", ...) -- With Best Regards, Andy Shevchenko