From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70EB8C433F5 for ; Thu, 31 Mar 2022 18:10:30 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8CE6C8421F; Thu, 31 Mar 2022 20:10:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="AO+sT3Fz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 085FD84209; Thu, 31 Mar 2022 20:10:26 +0200 (CEST) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C74C084209 for ; Thu, 31 Mar 2022 20:10:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wm1-x333.google.com with SMTP id 123-20020a1c1981000000b0038b3616a71aso117550wmz.4 for ; Thu, 31 Mar 2022 11:10:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1rdNZPMQ5yGP7vlY8dgEvTe0Kx54UGgxk9jqA94dgz0=; b=AO+sT3FzHMz2gpvAXPfgWGS6NEOw8DdkypLVf3m/IZjf+eLQR8cXs2isqa5WM+NQy0 clsZ1szSLkMwSKXRtnuTJcY8+GSkev87N2+rKhIhZ7jLZ3XMHchH7XU4uvwn0kchW0uw 2wof7weW0vZtMr/PHvDIJaO/XCHYlhXc4kYa3Vke6fqtiT0h8WdSFS9IPU4fQfdV9xl5 1yVz1q4HCpNfW11rQOtTvatWa0YHiN5tx85JMFvdjo3niJ+q0u9Oa8/yS6eYIy588zW3 /xFPn6wrw+v+l8PO/hJ/CynFCbodFM6bLP50BdMF97aWNSgHWCGwAJNEpPUgvl/ogYZO 7otw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1rdNZPMQ5yGP7vlY8dgEvTe0Kx54UGgxk9jqA94dgz0=; b=iEY7dYiAMLekCelxHIthnwubPioP4UeH+5ZcGwA4fnvtPlyEpOo5updkpiianNwxwm mYUNlKjd7iWSbHtbMeK8v8oEhmMhGPCBqbCXHxQyN9iw25A8ftOTGu7wQDO+iXzcotpj SkHE5uH8jIPOwsNpTOfsx+TN+UFQ/qeV9/JoeDhCqZ0KTZe0YqWemNfcJGYQwR/Eeb6V SQJhy7ixqsmKTq7WTKYzAp9E0IqWF5e7IzzRJ+3zbwxbvO+XWEVY+6JyM4J0kdctKwKX A9noXf5sgbnhfOuk5x45hyxEMFz1b/hXghHzJSK6zkEszP+0FHwE4uWyJqjS8bJ3jnUS Ic8w== X-Gm-Message-State: AOAM533EcJAMeb4dWl8XftahirOT1AEoKPgJuDX1aEWUVej2wmYnrhHg A/SEV9/GMmRjj+iFOIAwggcJXQ== X-Google-Smtp-Source: ABdhPJwE3CjGIac9Lm60T6Z+7DNplYWzL1pGurqQOm7ybmAeA7cU+oGKG9SMK9ihMqX3IkqRbPTQfg== X-Received: by 2002:a05:600c:1d8e:b0:389:d079:cc0 with SMTP id p14-20020a05600c1d8e00b00389d0790cc0mr5702996wms.98.1648750222366; Thu, 31 Mar 2022 11:10:22 -0700 (PDT) Received: from hades (athedsl-4461682.home.otenet.gr. [94.71.4.98]) by smtp.gmail.com with ESMTPSA id n37-20020a05600c3ba500b0038cc9d6ff5bsm14807wms.4.2022.03.31.11.10.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Mar 2022 11:10:21 -0700 (PDT) Date: Thu, 31 Mar 2022 21:10:19 +0300 From: Ilias Apalodimas To: Sughosh Ganu Cc: u-boot@lists.denx.de, Heinrich Schuchardt , AKASHI Takahiro , Ying-Chun Liu , Tuomas Tynkkynen , Heiko Thiery , Frieder Schrempf , Michael Walle , Masami Hiramatsu , Jassi Brar , Michal Simek , Michal Simek Subject: Re: [PATCH v4 6/8] FMP: Remove GUIDs for FIT and raw images Message-ID: References: <20220331132750.1532722-1-sughosh.ganu@linaro.org> <20220331132750.1532722-7-sughosh.ganu@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220331132750.1532722-7-sughosh.ganu@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thu, Mar 31, 2022 at 06:57:48PM +0530, Sughosh Ganu wrote: > The capsule update code has been modified for getting the image GUID > values from the platform code. With this, each image now has a unique > GUID value. With this change, there is no longer a need for defining > GUIDs for FIT and raw images. Remove these GUID values. > > Signed-off-by: Sughosh Ganu > --- > > Changes since V3: None > > include/efi_api.h | 8 -------- > lib/efi_loader/efi_firmware.c | 4 ---- > 2 files changed, 12 deletions(-) > > diff --git a/include/efi_api.h b/include/efi_api.h > index 982c200172..c7f7873b5d 100644 > --- a/include/efi_api.h > +++ b/include/efi_api.h > @@ -1967,14 +1967,6 @@ struct efi_signature_list { > EFI_GUID(0x86c77a67, 0x0b97, 0x4633, 0xa1, 0x87, \ > 0x49, 0x10, 0x4d, 0x06, 0x85, 0xc7) > > -#define EFI_FIRMWARE_IMAGE_TYPE_UBOOT_FIT_GUID \ > - EFI_GUID(0xae13ff2d, 0x9ad4, 0x4e25, 0x9a, 0xc8, \ > - 0x6d, 0x80, 0xb3, 0xb2, 0x21, 0x47) > - > -#define EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID \ > - EFI_GUID(0xe2bb9c06, 0x70e9, 0x4b14, 0x97, 0xa3, \ > - 0x5a, 0x79, 0x13, 0x17, 0x6e, 0x3f) > - > #define IMAGE_ATTRIBUTE_IMAGE_UPDATABLE 0x0000000000000001 > #define IMAGE_ATTRIBUTE_RESET_REQUIRED 0x0000000000000002 > #define IMAGE_ATTRIBUTE_AUTHENTICATION_REQUIRED 0x0000000000000004 > diff --git a/lib/efi_loader/efi_firmware.c b/lib/efi_loader/efi_firmware.c > index 169f3a29bb..7734d9f353 100644 > --- a/lib/efi_loader/efi_firmware.c > +++ b/lib/efi_loader/efi_firmware.c > @@ -185,8 +185,6 @@ static efi_status_t efi_fill_image_desc_array( > * - versioning of firmware image > * - package information > */ > -const efi_guid_t efi_firmware_image_type_uboot_fit = > - EFI_FIRMWARE_IMAGE_TYPE_UBOOT_FIT_GUID; > > /** > * efi_firmware_fit_get_image_info - return information about the current > @@ -293,8 +291,6 @@ const struct efi_firmware_management_protocol efi_fmp_fit = { > * This FIRMWARE_MANAGEMENT_PROTOCOL driver provides a firmware update > * method with raw data. > */ > -const efi_guid_t efi_firmware_image_type_uboot_raw = > - EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID; > > /** > * efi_firmware_raw_get_image_info - return information about the current > -- > 2.25.1 > Reviewed-by: Ilias Apalodimas