From: Grzegorz Szymaszek <gszymaszek@short.pl>
To: Patrick Delaunay <patrick.delaunay@foss.st.com>
Cc: u-boot@lists.denx.de,
Gabriel Fernandez <gabriel.fernandez@foss.st.com>,
Sean Anderson <seanga2@gmail.com>,
uboot-stm32@st-md-mailman.stormreply.com,
Lukasz Majewski <lukma@denx.de>,
Grzegorz Szymaszek <gszymaszek@short.pl>
Subject: Re: [Uboot-stm32] [PATCH 2/4] clk: stm32mp13: add a STM32MP13 RCC clock driver
Date: Tue, 10 May 2022 14:18:16 +0200 [thread overview]
Message-ID: <YnpYCCpHX4Ax0S9s@nx64de-df6d00> (raw)
In-Reply-To: <20220510095041.2.I98b0b23318f39ef6411b8f96c05f5b11b4cf5de7@changeid>
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
Hi,
On Tue, May 10, 2022 at 09:51:11AM +0200, Patrick Delaunay wrote:
> Introduce a minimal STM32MP13 RCC driver only to allow bind of RCC MISC
> driver.
Consider s/only/just/ and s/bind of/binding of the/.
> diff --git a/drivers/clk/stm32/Makefile b/drivers/clk/stm32/Makefile
> -%<-
> obj-$(CONFIG_CLK_STM32MP1) += clk_stm32mp1.o
> +obj-$(CONFIG_CLK_STM32MP13) += clk-stm32mp13.o
> \ No newline at end of file
Could you add a newline here? I think it was there in the previous
patch. Also, note that the new file name seems to break the convention
of using underscores.
All the best
--
Grzegorz
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-05-10 12:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 7:51 [PATCH 0/4] stm32mp: add minimal RCC support for STM32MP13 Patrick Delaunay
2022-05-10 7:51 ` [PATCH 1/4] clk: Add directory for STM32 clock drivers Patrick Delaunay
2022-05-11 16:40 ` Sean Anderson
2022-05-10 7:51 ` [PATCH 2/4] clk: stm32mp13: add a STM32MP13 RCC clock driver Patrick Delaunay
2022-05-10 12:18 ` Grzegorz Szymaszek [this message]
2022-05-10 7:51 ` [PATCH 3/4] misc: stm32mp13: introduce STM32MP13 RCC driver Patrick Delaunay
2022-05-10 7:51 ` [PATCH 4/4] ARM: dts: stm32: add rcc node for STM32MP13 Patrick Delaunay
2022-05-11 16:44 ` [PATCH 0/4] stm32mp: add minimal RCC support " Sean Anderson
2022-05-17 8:12 ` Patrick DELAUNAY
2022-05-19 13:42 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnpYCCpHX4Ax0S9s@nx64de-df6d00 \
--to=gszymaszek@short.pl \
--cc=gabriel.fernandez@foss.st.com \
--cc=lukma@denx.de \
--cc=patrick.delaunay@foss.st.com \
--cc=seanga2@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox