* [PATCH 1/3] ARM: dts: omap3-devkit8000: Add support for Devkit8000
@ 2022-05-15 13:38 Anthoine Bourgeois
2022-05-15 13:38 ` [PATCH 2/3] ARM: dts: omap3-devkit8000: Fix CONFIG_DM_I2C warning Anthoine Bourgeois
2022-05-15 13:38 ` [PATCH 3/3] ARM: dts: omap3-devkit8000: Fix CONFIG_DM_ETH warning Anthoine Bourgeois
0 siblings, 2 replies; 6+ messages in thread
From: Anthoine Bourgeois @ 2022-05-15 13:38 UTC (permalink / raw)
To: u-boot; +Cc: trini, sjg, Anthoine Bourgeois
This commit adds OMAP3 BeagleBoard devicetree files from Linux
v5.16.0.
This commit fixes CONFIG_DM_MMC warning.
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@gmail.com>
---
arch/arm/dts/Makefile | 2 +
arch/arm/dts/omap3-devkit8000-u-boot.dtsi | 14 +
arch/arm/dts/omap3-devkit8000.dts | 349 ++++++++++++++++++++++
configs/devkit8000_defconfig | 24 +-
include/configs/devkit8000.h | 64 ++--
5 files changed, 426 insertions(+), 27 deletions(-)
create mode 100644 arch/arm/dts/omap3-devkit8000-u-boot.dtsi
create mode 100644 arch/arm/dts/omap3-devkit8000.dts
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 83630af4f6..70f003259a 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -1047,6 +1047,8 @@ dtb-$(CONFIG_TARGET_OMAP3_BEAGLE) += \
omap3-beagle-xm.dtb \
omap3-beagle.dtb
+dtb-$(CONFIG_TARGET_DEVKIT8000) += omap3-devkit8000.dtb
+
dtb-$(CONFIG_TARGET_OMAP3_IGEP00X0) += \
omap3-igep0020.dtb
diff --git a/arch/arm/dts/omap3-devkit8000-u-boot.dtsi b/arch/arm/dts/omap3-devkit8000-u-boot.dtsi
new file mode 100644
index 0000000000..2c03701c89
--- /dev/null
+++ b/arch/arm/dts/omap3-devkit8000-u-boot.dtsi
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * U-Boot additions
+ *
+ * (C) Copyright 2017 Derald D. Woods <woods.technical@gmail.com>
+ */
+
+#include "omap3-u-boot.dtsi"
+
+/ {
+ chosen {
+ stdout-path = &uart3;
+ };
+};
diff --git a/arch/arm/dts/omap3-devkit8000.dts b/arch/arm/dts/omap3-devkit8000.dts
new file mode 100644
index 0000000000..eee3ba073b
--- /dev/null
+++ b/arch/arm/dts/omap3-devkit8000.dts
@@ -0,0 +1,349 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Author: Anthoine Bourgeois <anthoine.bourgeois@gmail.com>
+ */
+/dts-v1/;
+
+#include "omap34xx.dtsi"
+/ {
+ model = "TimLL OMAP3 Devkit8000";
+ compatible = "timll,omap3-devkit8000", "ti,omap3430", "ti,omap3";
+
+ aliases {
+ display1 = &dvi0;
+ display2 = &tv0;
+ };
+
+ memory@80000000 {
+ device_type = "memory";
+ reg = <0x80000000 0x10000000>; /* 256 MB */
+ };
+
+ leds {
+ compatible = "gpio-leds";
+
+ heartbeat {
+ label = "devkit8000::led1";
+ gpios = <&gpio6 26 GPIO_ACTIVE_HIGH>; /* 186 -> LED1 */
+ default-state = "on";
+ linux,default-trigger = "heartbeat";
+ };
+
+ mmc {
+ label = "devkit8000::led2";
+ gpios = <&gpio6 3 GPIO_ACTIVE_HIGH>; /* 163 -> LED2 */
+ default-state = "on";
+ linux,default-trigger = "none";
+ };
+
+ usr {
+ label = "devkit8000::led3";
+ gpios = <&gpio6 4 GPIO_ACTIVE_HIGH>; /* 164 -> LED3 */
+ default-state = "on";
+ linux,default-trigger = "usr";
+ };
+
+ pmu_stat {
+ label = "devkit8000::pmu_stat";
+ gpios = <&twl_gpio 19 GPIO_ACTIVE_HIGH>; /* LEDB */
+ };
+ };
+
+ sound {
+ compatible = "ti,omap-twl4030";
+ ti,model = "devkit8000";
+
+ ti,mcbsp = <&mcbsp2>;
+ ti,audio-routing =
+ "Ext Spk", "PREDRIVEL",
+ "Ext Spk", "PREDRIVER",
+ "MAINMIC", "Main Mic",
+ "Main Mic", "Mic Bias 1";
+ };
+
+ tfp410: encoder0 {
+ compatible = "ti,tfp410";
+ powerdown-gpios = <&twl_gpio 7 GPIO_ACTIVE_LOW>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ tfp410_in: endpoint {
+ remote-endpoint = <&dpi_dvi_out>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ tfp410_out: endpoint {
+ remote-endpoint = <&dvi_connector_in>;
+ };
+ };
+ };
+ };
+
+ dvi0: connector0 {
+ compatible = "dvi-connector";
+ label = "dvi";
+
+ digital;
+
+ ddc-i2c-bus = <&i2c2>;
+
+ port {
+ dvi_connector_in: endpoint {
+ remote-endpoint = <&tfp410_out>;
+ };
+ };
+ };
+
+ tv0: connector1 {
+ compatible = "svideo-connector";
+ label = "tv";
+
+ port {
+ tv_connector_in: endpoint {
+ remote-endpoint = <&venc_out>;
+ };
+ };
+ };
+};
+
+&i2c1 {
+ clock-frequency = <2600000>;
+
+ twl: twl@48 {
+ reg = <0x48>;
+ interrupts = <7>; /* SYS_NIRQ cascaded to intc */
+
+ twl_audio: audio {
+ compatible = "ti,twl4030-audio";
+ codec {
+ };
+ };
+ };
+};
+
+&i2c2 {
+ clock-frequency = <400000>;
+};
+
+&i2c3 {
+ status = "disabled";
+};
+
+#include "twl4030.dtsi"
+#include "twl4030_omap3.dtsi"
+
+&mmc1 {
+ vmmc-supply = <&vmmc1>;
+ vqmmc-supply = <&vsim>;
+ bus-width = <8>;
+};
+
+&mmc2 {
+ status = "disabled";
+};
+
+&mmc3 {
+ status = "disabled";
+};
+
+&twl_gpio {
+ ti,use-leds;
+ /*
+ * pulldowns:
+ * BIT(1), BIT(2), BIT(6), BIT(7), BIT(8), BIT(13)
+ * BIT(15), BIT(16), BIT(17)
+ */
+ ti,pulldowns = <0x03a1c6>;
+};
+
+&wdt2 {
+ status = "disabled";
+};
+
+&mcbsp2 {
+ status = "okay";
+};
+
+&gpmc {
+ ranges = <0 0 0x30000000 0x1000000 /* CS0: 16MB for NAND */
+ 6 0 0x2c000000 0x1000000>; /* CS6: 16MB for DM9000 */
+
+ nand@0,0 {
+ compatible = "ti,omap2-nand";
+ reg = <0 0 4>; /* CS0, offset 0, IO size 4 */
+ interrupt-parent = <&gpmc>;
+ interrupts = <0 IRQ_TYPE_NONE>, /* fifoevent */
+ <1 IRQ_TYPE_NONE>; /* termcount */
+ nand-bus-width = <16>;
+ gpmc,device-width = <2>;
+ ti,nand-ecc-opt = "sw";
+
+ gpmc,sync-clk-ps = <0>;
+ gpmc,cs-on-ns = <0>;
+ gpmc,cs-rd-off-ns = <44>;
+ gpmc,cs-wr-off-ns = <44>;
+ gpmc,adv-on-ns = <6>;
+ gpmc,adv-rd-off-ns = <34>;
+ gpmc,adv-wr-off-ns = <44>;
+ gpmc,we-off-ns = <40>;
+ gpmc,oe-off-ns = <54>;
+ gpmc,access-ns = <64>;
+ gpmc,rd-cycle-ns = <82>;
+ gpmc,wr-cycle-ns = <82>;
+ gpmc,wr-access-ns = <40>;
+ gpmc,wr-data-mux-bus-ns = <0>;
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ x-loader@0 {
+ label = "X-Loader";
+ reg = <0 0x80000>;
+ };
+
+ bootloaders@80000 {
+ label = "U-Boot";
+ reg = <0x80000 0x1e0000>;
+ };
+
+ bootloaders_env@260000 {
+ label = "U-Boot Env";
+ reg = <0x260000 0x20000>;
+ };
+
+ kernel@280000 {
+ label = "Kernel";
+ reg = <0x280000 0x400000>;
+ };
+
+ filesystem@680000 {
+ label = "File System";
+ reg = <0x680000 0xf980000>;
+ };
+ };
+
+ ethernet@6,0 {
+ compatible = "davicom,dm9000";
+ reg = <6 0x000 2
+ 6 0x400 2>; /* CS6, offset 0 and 0x400, IO size 2 */
+ bank-width = <2>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <25 IRQ_TYPE_LEVEL_LOW>;
+ davicom,no-eeprom;
+
+ gpmc,mux-add-data = <0>;
+ gpmc,device-width = <1>;
+ gpmc,wait-pin = <0>;
+ gpmc,cycle2cycle-samecsen;
+ gpmc,cycle2cycle-diffcsen;
+
+ gpmc,cs-on-ns = <6>;
+ gpmc,cs-rd-off-ns = <180>;
+ gpmc,cs-wr-off-ns = <180>;
+ gpmc,adv-on-ns = <0>;
+ gpmc,adv-rd-off-ns = <18>;
+ gpmc,adv-wr-off-ns = <48>;
+ gpmc,oe-on-ns = <54>;
+ gpmc,oe-off-ns = <168>;
+ gpmc,we-on-ns = <54>;
+ gpmc,we-off-ns = <168>;
+ gpmc,rd-cycle-ns = <186>;
+ gpmc,wr-cycle-ns = <186>;
+ gpmc,access-ns = <144>;
+ gpmc,page-burst-access-ns = <24>;
+ gpmc,bus-turnaround-ns = <90>;
+ gpmc,cycle2cycle-delay-ns = <90>;
+ gpmc,wait-monitoring-ns = <0>;
+ gpmc,clk-activation-ns = <0>;
+ gpmc,wr-data-mux-bus-ns = <0>;
+ gpmc,wr-access-ns = <0>;
+ };
+};
+
+&omap3_pmx_core {
+ dss_dpi_pins: pinmux_dss_dpi_pins {
+ pinctrl-single,pins = <
+ OMAP3_CORE1_IOPAD(0x20d4, PIN_OUTPUT | MUX_MODE0) /* dss_pclk.dss_pclk */
+ OMAP3_CORE1_IOPAD(0x20d6, PIN_OUTPUT | MUX_MODE0) /* dss_hsync.dss_hsync */
+ OMAP3_CORE1_IOPAD(0x20d8, PIN_OUTPUT | MUX_MODE0) /* dss_vsync.dss_vsync */
+ OMAP3_CORE1_IOPAD(0x20da, PIN_OUTPUT | MUX_MODE0) /* dss_acbias.dss_acbias */
+ OMAP3_CORE1_IOPAD(0x20dc, PIN_OUTPUT | MUX_MODE0) /* dss_data0.dss_data0 */
+ OMAP3_CORE1_IOPAD(0x20de, PIN_OUTPUT | MUX_MODE0) /* dss_data1.dss_data1 */
+ OMAP3_CORE1_IOPAD(0x20e0, PIN_OUTPUT | MUX_MODE0) /* dss_data2.dss_data2 */
+ OMAP3_CORE1_IOPAD(0x20e2, PIN_OUTPUT | MUX_MODE0) /* dss_data3.dss_data3 */
+ OMAP3_CORE1_IOPAD(0x20e4, PIN_OUTPUT | MUX_MODE0) /* dss_data4.dss_data4 */
+ OMAP3_CORE1_IOPAD(0x20e6, PIN_OUTPUT | MUX_MODE0) /* dss_data5.dss_data5 */
+ OMAP3_CORE1_IOPAD(0x20e8, PIN_OUTPUT | MUX_MODE0) /* dss_data6.dss_data6 */
+ OMAP3_CORE1_IOPAD(0x20ea, PIN_OUTPUT | MUX_MODE0) /* dss_data7.dss_data7 */
+ OMAP3_CORE1_IOPAD(0x20ec, PIN_OUTPUT | MUX_MODE0) /* dss_data8.dss_data8 */
+ OMAP3_CORE1_IOPAD(0x20ee, PIN_OUTPUT | MUX_MODE0) /* dss_data9.dss_data9 */
+ OMAP3_CORE1_IOPAD(0x20f0, PIN_OUTPUT | MUX_MODE0) /* dss_data10.dss_data10 */
+ OMAP3_CORE1_IOPAD(0x20f2, PIN_OUTPUT | MUX_MODE0) /* dss_data11.dss_data11 */
+ OMAP3_CORE1_IOPAD(0x20f4, PIN_OUTPUT | MUX_MODE0) /* dss_data12.dss_data12 */
+ OMAP3_CORE1_IOPAD(0x20f6, PIN_OUTPUT | MUX_MODE0) /* dss_data13.dss_data13 */
+ OMAP3_CORE1_IOPAD(0x20f8, PIN_OUTPUT | MUX_MODE0) /* dss_data14.dss_data14 */
+ OMAP3_CORE1_IOPAD(0x20fa, PIN_OUTPUT | MUX_MODE0) /* dss_data15.dss_data15 */
+ OMAP3_CORE1_IOPAD(0x20fc, PIN_OUTPUT | MUX_MODE0) /* dss_data16.dss_data16 */
+ OMAP3_CORE1_IOPAD(0x20fe, PIN_OUTPUT | MUX_MODE0) /* dss_data17.dss_data17 */
+ OMAP3_CORE1_IOPAD(0x2100, PIN_OUTPUT | MUX_MODE0) /* dss_data18.dss_data18 */
+ OMAP3_CORE1_IOPAD(0x2102, PIN_OUTPUT | MUX_MODE0) /* dss_data19.dss_data19 */
+ OMAP3_CORE1_IOPAD(0x2104, PIN_OUTPUT | MUX_MODE0) /* dss_data20.dss_data20 */
+ OMAP3_CORE1_IOPAD(0x2106, PIN_OUTPUT | MUX_MODE0) /* dss_data21.dss_data21 */
+ OMAP3_CORE1_IOPAD(0x2108, PIN_OUTPUT | MUX_MODE0) /* dss_data22.dss_data22 */
+ OMAP3_CORE1_IOPAD(0x210a, PIN_OUTPUT | MUX_MODE0) /* dss_data23.dss_data23 */
+ >;
+ };
+};
+
+&vpll1 {
+ /* Needed for DSS */
+ regulator-name = "vdds_dsi";
+
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+};
+
+&dss {
+ status = "okay";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&dss_dpi_pins>;
+
+ vdds_dsi-supply = <&vpll1>;
+ vdda_dac-supply = <&vdac>;
+
+ port {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ dpi_dvi_out: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&tfp410_in>;
+ data-lines = <24>;
+ };
+
+ endpoint@1 {
+ reg = <1>;
+ };
+ };
+};
+
+&venc {
+ status = "okay";
+
+ vdda-supply = <&vdac>;
+
+ port {
+ venc_out: endpoint {
+ remote-endpoint = <&tv_connector_in>;
+ ti,channels = <2>;
+ };
+ };
+};
diff --git a/configs/devkit8000_defconfig b/configs/devkit8000_defconfig
index be780949ec..c025b400d2 100644
--- a/configs/devkit8000_defconfig
+++ b/configs/devkit8000_defconfig
@@ -2,14 +2,21 @@ CONFIG_ARM=y
CONFIG_ARCH_OMAP2PLUS=y
CONFIG_SYS_TEXT_BASE=0x80100000
CONFIG_SYS_MALLOC_LEN=0x40000
-CONFIG_SYS_MALLOC_F_LEN=0x400
+CONFIG_SYS_MALLOC_F_LEN=0x4000
CONFIG_NR_DRAM_BANKS=2
CONFIG_SPL_TEXT_BASE=0x40200000
CONFIG_TARGET_DEVKIT8000=y
+CONFIG_SPL_SYS_MALLOC_F_LEN=0x400
CONFIG_SPL=y
+CONFIG_DEFAULT_DEVICE_TREE="omap3-devkit8000"
CONFIG_DISTRO_DEFAULTS=y
CONFIG_BOOTCOMMAND="run autoboot"
+CONFIG_USE_PREBOOT=y
+CONFIG_DEFAULT_FDT_FILE="omap3-devkit8000.dtb"
CONFIG_SYS_CONSOLE_INFO_QUIET=y
+CONFIG_SPL_SYS_MALLOC_SIMPLE=y
+CONFIG_SPL_SEPARATE_BSS=y
+# CONFIG_SPL_FS_EXT4 is not set
CONFIG_SPL_NAND_DRIVERS=y
CONFIG_SPL_NAND_ECC=y
CONFIG_SPL_NAND_SIMPLE=y
@@ -19,8 +26,8 @@ CONFIG_SPL_FALCON_BOOT_MMCSD=y
CONFIG_SYS_MMCSD_RAW_MODE_KERNEL_SECTOR=0x500
# CONFIG_CMD_IMI is not set
CONFIG_CMD_SPL=y
-CONFIG_CMD_SPL_NAND_OFS=0x680000
-CONFIG_CMD_SPL_WRITE_SIZE=0x400
+CONFIG_CMD_SPL_NAND_OFS=0x280000
+CONFIG_CMD_SPL_WRITE_SIZE=0x20000
# CONFIG_CMD_FLASH is not set
CONFIG_CMD_I2C=y
CONFIG_CMD_MMC=y
@@ -38,6 +45,11 @@ CONFIG_JFFS2_PART_SIZE=0xF980000
CONFIG_CMD_MTDPARTS=y
CONFIG_MTDIDS_DEFAULT="nand0=nand"
CONFIG_MTDPARTS_DEFAULT="mtdparts=nand:512k(x-loader),1920k(u-boot),128k(u-boot-env),4m(kernel),-(fs)"
+# CONFIG_ISO_PARTITION is not set
+# CONFIG_SPL_EFI_PARTITION is not set
+CONFIG_OF_CONTROL=y
+CONFIG_SPL_OF_CONTROL=y
+CONFIG_OF_SPL_REMOVE_PROPS="clocks clock-names interrupt-parent"
CONFIG_ENV_OVERWRITE=y
CONFIG_ENV_IS_IN_NAND=y
CONFIG_SYS_RELOC_GD_ENV_ADDR=y
@@ -47,6 +59,10 @@ CONFIG_BOOTP_SEND_HOSTNAME=y
CONFIG_SYS_I2C_LEGACY=y
CONFIG_SPL_SYS_I2C_LEGACY=y
CONFIG_TWL4030_LED=y
+CONFIG_SPL_DM=y
+CONFIG_SPL_DM_SEQ_ALIAS=y
+CONFIG_SPL_OF_TRANSLATE=y
+CONFIG_DM_MMC=y
CONFIG_MMC_OMAP_HS=y
CONFIG_MTD=y
CONFIG_MTD_RAW_NAND=y
@@ -59,6 +75,4 @@ CONFIG_SYS_NAND_BUSWIDTH_16BIT=y
CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y
CONFIG_SYS_NAND_U_BOOT_OFFS=0x80000
CONFIG_DRIVER_DM9000=y
-CONFIG_CONS_INDEX=3
CONFIG_JFFS2_NAND=y
-CONFIG_OF_LIBFDT=y
diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h
index 5dbd126a2a..d810554a4c 100644
--- a/include/configs/devkit8000.h
+++ b/include/configs/devkit8000.h
@@ -14,23 +14,6 @@
#ifndef __CONFIG_H
#define __CONFIG_H
-/* High Level Configuration Options */
-
-/*
- * 1MB into the SDRAM to allow for SPL's bss at the beginning of SDRAM
- * 64 bytes before this address should be set aside for u-boot.img's
- * header. That is 0x800FFFC0--0x80100000 should not be used for any
- * other needs.
- */
-
-#define CONFIG_SPL_BSS_START_ADDR 0x80000500 /* leave space for bootargs*/
-#define CONFIG_SPL_BSS_MAX_SIZE 0x80000
-
-#define CONFIG_SYS_SPL_MALLOC_START 0x80208000
-#define CONFIG_SYS_SPL_MALLOC_SIZE 0x100000 /* 1 MB */
-
-/* Physical Memory Map */
-
#include <configs/ti_omap3_common.h>
/* Hardware drivers */
@@ -46,9 +29,48 @@
/* BOOTP/DHCP options */
+#define MEM_LAYOUT_ENV_SETTINGS \
+ DEFAULT_LINUX_BOOT_ENV
+
+#define BOOTENV_DEV_LEGACY_MMC(devtypeu, devtypel, instance) \
+ "bootcmd_" #devtypel #instance "=" \
+ "setenv mmcdev " #instance "; " \
+ "run mmcboot\0"
+#define BOOTENV_DEV_NAME_LEGACY_MMC(devtypeu, devtypel, instance) \
+ #devtypel #instance " "
+
+#if defined(CONFIG_MTD_RAW_NAND)
+
+#define BOOTENV_DEV_NAND(devtypeu, devtypel, instance) \
+ "bootcmd_" #devtypel #instance "=" \
+ "if test ${mtdids} = '' || test ${mtdparts} = '' ; then " \
+ "echo NAND boot disabled: No mtdids and/or mtdparts; " \
+ "else " \
+ "run nandboot; " \
+ "fi\0"
+#define BOOTENV_DEV_NAME_NAND(devtypeu, devtypel, instance) \
+ #devtypel #instance " "
+
+#define BOOT_TARGET_DEVICES(func) \
+ func(MMC, mmc, 0) \
+ func(LEGACY_MMC, legacy_mmc, 0) \
+ func(NAND, nand, 0)
+
+#else /* !CONFIG_MTD_RAW_NAND */
+
+#define BOOT_TARGET_DEVICES(func) \
+ func(MMC, mmc, 0) \
+ func(LEGACY_MMC, legacy_mmc, 0)
+
+#endif /* CONFIG_MTD_RAW_NAND */
+
+#include <config_distro_bootcmd.h>
+
/* Environment information */
#define CONFIG_EXTRA_ENV_SETTINGS \
- "loadaddr=0x82000000\0" \
+ MEM_LAYOUT_ENV_SETTINGS \
+ "fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \
+ "fdt_high=0xffffffff\0" \
"console=ttyO2,115200n8\0" \
"mmcdev=0\0" \
"vram=12M\0" \
@@ -88,7 +110,6 @@
"bootscript=echo Running bootscript from mmc ...; " \
"source ${loadaddr}\0" \
"loaduimage=fatload mmc ${mmcdev} ${loadaddr} uImage\0" \
- "eraseenv=nand unlock 0x260000 0x20000; nand erase 0x260000 0x20000\0" \
"mmcboot=echo Booting from mmc ...; " \
"run mmcargs; " \
"bootm ${loadaddr}\0" \
@@ -109,9 +130,8 @@
"else run nandboot; " \
"fi; " \
"fi; " \
- "else run nandboot; fi\0"
-
-/* Boot Argument Buffer Size */
+ "else run nandboot; fi\0" \
+ BOOTENV
/* Defines for SPL */
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] ARM: dts: omap3-devkit8000: Fix CONFIG_DM_I2C warning
2022-05-15 13:38 [PATCH 1/3] ARM: dts: omap3-devkit8000: Add support for Devkit8000 Anthoine Bourgeois
@ 2022-05-15 13:38 ` Anthoine Bourgeois
2022-05-15 14:00 ` Tom Rini
2022-05-15 13:38 ` [PATCH 3/3] ARM: dts: omap3-devkit8000: Fix CONFIG_DM_ETH warning Anthoine Bourgeois
1 sibling, 1 reply; 6+ messages in thread
From: Anthoine Bourgeois @ 2022-05-15 13:38 UTC (permalink / raw)
To: u-boot; +Cc: trini, sjg, Anthoine Bourgeois
Seems that u-boot can't probe i2c bus at 2.6Mhz speed, so lower
the speed to the default value 100Khz.
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@gmail.com>
---
arch/arm/dts/omap3-devkit8000.dts | 2 +-
configs/devkit8000_defconfig | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/dts/omap3-devkit8000.dts b/arch/arm/dts/omap3-devkit8000.dts
index eee3ba073b..9cd3708d95 100644
--- a/arch/arm/dts/omap3-devkit8000.dts
+++ b/arch/arm/dts/omap3-devkit8000.dts
@@ -115,7 +115,7 @@
};
&i2c1 {
- clock-frequency = <2600000>;
+ clock-frequency = <100000>;
twl: twl@48 {
reg = <0x48>;
diff --git a/configs/devkit8000_defconfig b/configs/devkit8000_defconfig
index c025b400d2..98126e9c82 100644
--- a/configs/devkit8000_defconfig
+++ b/configs/devkit8000_defconfig
@@ -64,6 +64,7 @@ CONFIG_SPL_DM_SEQ_ALIAS=y
CONFIG_SPL_OF_TRANSLATE=y
CONFIG_DM_MMC=y
CONFIG_MMC_OMAP_HS=y
+CONFIG_DM_I2C=y
CONFIG_MTD=y
CONFIG_MTD_RAW_NAND=y
CONFIG_NAND_OMAP_ECCSCHEME_HAM1_CODE_HW=y
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] ARM: dts: omap3-devkit8000: Fix CONFIG_DM_ETH warning
2022-05-15 13:38 [PATCH 1/3] ARM: dts: omap3-devkit8000: Add support for Devkit8000 Anthoine Bourgeois
2022-05-15 13:38 ` [PATCH 2/3] ARM: dts: omap3-devkit8000: Fix CONFIG_DM_I2C warning Anthoine Bourgeois
@ 2022-05-15 13:38 ` Anthoine Bourgeois
1 sibling, 0 replies; 6+ messages in thread
From: Anthoine Bourgeois @ 2022-05-15 13:38 UTC (permalink / raw)
To: u-boot; +Cc: trini, sjg, Anthoine Bourgeois
Add the missing ethernet node in u-boot dts.
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@gmail.com>
---
arch/arm/dts/omap3-devkit8000-u-boot.dtsi | 6 ++++++
configs/devkit8000_defconfig | 1 +
2 files changed, 7 insertions(+)
diff --git a/arch/arm/dts/omap3-devkit8000-u-boot.dtsi b/arch/arm/dts/omap3-devkit8000-u-boot.dtsi
index 2c03701c89..a5768b7281 100644
--- a/arch/arm/dts/omap3-devkit8000-u-boot.dtsi
+++ b/arch/arm/dts/omap3-devkit8000-u-boot.dtsi
@@ -11,4 +11,10 @@
chosen {
stdout-path = &uart3;
};
+
+ ethernet@2c000000 {
+ compatible = "davicom,dm9000";
+ reg = <0x2c000000 2 0x2c000400 2>;
+ bank-width = <2>;
+ };
};
diff --git a/configs/devkit8000_defconfig b/configs/devkit8000_defconfig
index 98126e9c82..e167abb747 100644
--- a/configs/devkit8000_defconfig
+++ b/configs/devkit8000_defconfig
@@ -75,5 +75,6 @@ CONFIG_SYS_NAND_OOBSIZE=0x40
CONFIG_SYS_NAND_BUSWIDTH_16BIT=y
CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y
CONFIG_SYS_NAND_U_BOOT_OFFS=0x80000
+CONFIG_DM_ETH=y
CONFIG_DRIVER_DM9000=y
CONFIG_JFFS2_NAND=y
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] ARM: dts: omap3-devkit8000: Fix CONFIG_DM_I2C warning
2022-05-15 13:38 ` [PATCH 2/3] ARM: dts: omap3-devkit8000: Fix CONFIG_DM_I2C warning Anthoine Bourgeois
@ 2022-05-15 14:00 ` Tom Rini
2022-05-15 18:58 ` Derald Woods
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2022-05-15 14:00 UTC (permalink / raw)
To: Anthoine Bourgeois; +Cc: u-boot, sjg
[-- Attachment #1: Type: text/plain, Size: 874 bytes --]
On Sun, May 15, 2022 at 03:38:21PM +0200, Anthoine Bourgeois wrote:
> Seems that u-boot can't probe i2c bus at 2.6Mhz speed, so lower
> the speed to the default value 100Khz.
>
> Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@gmail.com>
> ---
> arch/arm/dts/omap3-devkit8000.dts | 2 +-
> configs/devkit8000_defconfig | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/dts/omap3-devkit8000.dts b/arch/arm/dts/omap3-devkit8000.dts
> index eee3ba073b..9cd3708d95 100644
> --- a/arch/arm/dts/omap3-devkit8000.dts
> +++ b/arch/arm/dts/omap3-devkit8000.dts
> @@ -115,7 +115,7 @@
> };
>
> &i2c1 {
> - clock-frequency = <2600000>;
> + clock-frequency = <100000>;
>
> twl: twl@48 {
> reg = <0x48>;
Thanks for updating these platforms. Can we override this in the
-u-boot.dtsi file?
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] ARM: dts: omap3-devkit8000: Fix CONFIG_DM_I2C warning
2022-05-15 14:00 ` Tom Rini
@ 2022-05-15 18:58 ` Derald Woods
2022-05-18 8:21 ` Anthoine Bourgeois
0 siblings, 1 reply; 6+ messages in thread
From: Derald Woods @ 2022-05-15 18:58 UTC (permalink / raw)
To: Tom Rini; +Cc: Anthoine Bourgeois, U-Boot Mailing List, Simon Glass
On Sun, May 15, 2022 at 9:01 AM Tom Rini <trini@konsulko.com> wrote:
> On Sun, May 15, 2022 at 03:38:21PM +0200, Anthoine Bourgeois wrote:
>
> > Seems that u-boot can't probe i2c bus at 2.6Mhz speed, so lower
> > the speed to the default value 100Khz.
> >
> > Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@gmail.com>
> > ---
> > arch/arm/dts/omap3-devkit8000.dts | 2 +-
> > configs/devkit8000_defconfig | 1 +
> > 2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/dts/omap3-devkit8000.dts
> b/arch/arm/dts/omap3-devkit8000.dts
> > index eee3ba073b..9cd3708d95 100644
> > --- a/arch/arm/dts/omap3-devkit8000.dts
> > +++ b/arch/arm/dts/omap3-devkit8000.dts
> > @@ -115,7 +115,7 @@
> > };
> >
> > &i2c1 {
> > - clock-frequency = <2600000>;
> > + clock-frequency = <100000>;
> >
> > twl: twl@48 {
> > reg = <0x48>;
>
> Thanks for updating these platforms. Can we override this in the
> -u-boot.dtsi file?
>
> --
> Tom
>
$ grep -RI "clock-frequency = <2600000>" .
./arch/arm/dts/logicpd-torpedo-som.dtsi: clock-frequency = <2600000>;
./arch/arm/dts/omap3-igep.dtsi: clock-frequency = <2600000>;
./arch/arm/dts/omap3-beagle.dts: clock-frequency = <2600000>;
./arch/arm/dts/omap3-evm-common.dtsi: clock-frequency = <2600000>;
./arch/arm/dts/logicpd-som-lv.dtsi: clock-frequency = <2600000>;
./arch/arm/dts/omap3-beagle-xm.dts: clock-frequency = <2600000>;
All of these would benefit.
Derald
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] ARM: dts: omap3-devkit8000: Fix CONFIG_DM_I2C warning
2022-05-15 18:58 ` Derald Woods
@ 2022-05-18 8:21 ` Anthoine Bourgeois
0 siblings, 0 replies; 6+ messages in thread
From: Anthoine Bourgeois @ 2022-05-18 8:21 UTC (permalink / raw)
To: Derald Woods; +Cc: Tom Rini, U-Boot Mailing List, Simon Glass
On Sun, May 15, 2022 at 01:58:37PM -0500, Derald Woods wrote:
>On Sun, May 15, 2022 at 9:01 AM Tom Rini <trini@konsulko.com> wrote:
>
>> On Sun, May 15, 2022 at 03:38:21PM +0200, Anthoine Bourgeois wrote:
>>
>> > Seems that u-boot can't probe i2c bus at 2.6Mhz speed, so lower
>> > the speed to the default value 100Khz.
>> >
>> > Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@gmail.com>
>> > ---
>> > arch/arm/dts/omap3-devkit8000.dts | 2 +-
>> > configs/devkit8000_defconfig | 1 +
>> > 2 files changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/arch/arm/dts/omap3-devkit8000.dts
>> b/arch/arm/dts/omap3-devkit8000.dts
>> > index eee3ba073b..9cd3708d95 100644
>> > --- a/arch/arm/dts/omap3-devkit8000.dts
>> > +++ b/arch/arm/dts/omap3-devkit8000.dts
>> > @@ -115,7 +115,7 @@
>> > };
>> >
>> > &i2c1 {
>> > - clock-frequency = <2600000>;
>> > + clock-frequency = <100000>;
>> >
>> > twl: twl@48 {
>> > reg = <0x48>;
>>
>> Thanks for updating these platforms. Can we override this in the
>> -u-boot.dtsi file?
>>
>> --
>> Tom
>>
>
>$ grep -RI "clock-frequency = <2600000>" .
>./arch/arm/dts/logicpd-torpedo-som.dtsi: clock-frequency = <2600000>;
>./arch/arm/dts/omap3-igep.dtsi: clock-frequency = <2600000>;
>./arch/arm/dts/omap3-beagle.dts: clock-frequency = <2600000>;
>./arch/arm/dts/omap3-evm-common.dtsi: clock-frequency = <2600000>;
>./arch/arm/dts/logicpd-som-lv.dtsi: clock-frequency = <2600000>;
>./arch/arm/dts/omap3-beagle-xm.dts: clock-frequency = <2600000>;
>
>All of these would benefit.
Yes, good idea, this is in v2.
--
Anthoine
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-18 8:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-15 13:38 [PATCH 1/3] ARM: dts: omap3-devkit8000: Add support for Devkit8000 Anthoine Bourgeois
2022-05-15 13:38 ` [PATCH 2/3] ARM: dts: omap3-devkit8000: Fix CONFIG_DM_I2C warning Anthoine Bourgeois
2022-05-15 14:00 ` Tom Rini
2022-05-15 18:58 ` Derald Woods
2022-05-18 8:21 ` Anthoine Bourgeois
2022-05-15 13:38 ` [PATCH 3/3] ARM: dts: omap3-devkit8000: Fix CONFIG_DM_ETH warning Anthoine Bourgeois
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox