From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFD9CC433EF for ; Mon, 23 May 2022 13:24:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0106D83F6A; Mon, 23 May 2022 15:24:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="L89Iuke1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C672C8405A; Mon, 23 May 2022 15:24:52 +0200 (CEST) Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1972680167 for ; Mon, 23 May 2022 15:24:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ej1-x62d.google.com with SMTP id y13so28061519eje.2 for ; Mon, 23 May 2022 06:24:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=A1jUgWIwo7RV71/AXzehxUoVZQrkzmomeDJDLdOBQJY=; b=L89Iuke1GCRFHQevFk2RyTdyu5kw6a4PWOTwxGMe/qdwjl4LnqMnn1h5rVjhofia5A RTye97sQwq2ukus48KEbmCjQ430nQTXKFDo4QuSI3EaOqg7io6T2miMgW4QGfoororCL 8+JtaEjFiEOUGAQra0hb3gC9JB8xjOWA4eHm80IKyv+jrmXtTW/pRonJxfF0fj+etv48 j1X6OngHnSHjKQep3MdSEg6ZHVn0ZM8kjopGet/PW4IIQECYgLxlWqfl9a/2uQXrSpUr F5n730FKnPzMDcbzg5Gbd307yrOe6isw/O6qOOPquUckpPcaOGr3qXyUtOVQX8lvYokk pXMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=A1jUgWIwo7RV71/AXzehxUoVZQrkzmomeDJDLdOBQJY=; b=2P4CEyAdI1VFxad+fjgSX/1Mex1sBAMNMhbJ429sFNEkSUQ8cX8SbFqGfdTBfloMOC 9SvFYJRDAQV0Ta80qmpUIH2NPJ2IHqWFXMsqjvKDmGYQrUSdO3G2m2sd9ZsPFo+ni65G wmQQvq69IIfTR8RsAY3J2SIkHmaBi7otor9tV91KVnulkcVEiDKDZt3SHSy1NqEWpGfQ iw22yjXxwMdtBYNVwGp0upmQowLHsOXIY49qOE1gdWe2etvWVR5MVZKiqatFZ9+nZtt6 fOHAa07xbAcNb75ioAvTyYCqLj7V0i75KaA64+KWt8aR5nA5te4tt7pE/4lwHZ0FXckO XftQ== X-Gm-Message-State: AOAM533rGwhmgcqnpdrXwmhgYeN3rii434XHXT14dMGGBiGtdTg6QnCn QvIV4XP3hfWo7JcF5toT7AQv7Q== X-Google-Smtp-Source: ABdhPJyady8Pf3Y0gx9zarx3UtKJUZEMTp+BjZTAn5qMiaDwHsMvN6Py/8mzzfZXFUJQXIVIqEnExQ== X-Received: by 2002:a17:907:7f9e:b0:6f4:d3d0:8d8e with SMTP id qk30-20020a1709077f9e00b006f4d3d08d8emr20045679ejc.501.1653312289682; Mon, 23 May 2022 06:24:49 -0700 (PDT) Received: from hera ([176.92.137.112]) by smtp.gmail.com with ESMTPSA id 6-20020a170906024600b006f3ef214e70sm6026322ejl.214.2022.05.23.06.24.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 06:24:49 -0700 (PDT) Date: Mon, 23 May 2022 16:24:46 +0300 From: Ilias Apalodimas To: Eddie James Cc: u-boot@lists.denx.de Subject: Re: [PATCH 2/2] tpm: add support for TPMv2.x I2C chips Message-ID: References: <20220513183000.47392-1-eajames@linux.ibm.com> <20220513183000.47392-3-eajames@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Mon, May 23, 2022 at 08:19:51AM -0500, Eddie James wrote: > > On 5/23/22 01:12, Ilias Apalodimas wrote: > > Hi Eddie, > > > > Thanks for the patch. > > > > [...] > > > > > +static const struct tpm_tis_chip_data tpm_tis_std_chip_data = { > > > + .pcr_count = 24, > > > + .pcr_select_min = 3, > > > +}; > > > + > > > +static const struct udevice_id tpm_tis_i2c_ids[] = { > > > + { > > > + .compatible = "nuvoton,npct75x", > > > + .data = (ulong)&tpm_tis_std_chip_data, > > > + }, > > > + { > > > + .compatible = "tcg,tpm-tis-i2c", > > > + .data = (ulong)&tpm_tis_std_chip_data, > > > + }, > > > + { } > > > +}; > > > + > > > +U_BOOT_DRIVER(tpm_tis_i2c) = { > > > + .name = "tpm_tis_i2c", > > > + .id = UCLASS_TPM, > > > + .of_match = tpm_tis_i2c_ids, > > > + .ops = &tpm_tis_i2c_ops, > > > + .probe = tpm_tis_i2c_probe, > > > + .remove = tpm_tis_i2c_remove, > > > + .priv_auto_alloc_size = sizeof(struct tpm_chip), > > Shouldn't this be .priv_auto only? IIRC we got rid of the > > .priv_auto_alloc_size a while back? If so I can fix this while merging > > > Yes, I think so. I tested with an older u-boot (openbmc uses a modified > v2019.04) with all the TPM core patches, and I think I missed this bit in > rebasing. No worries, I can fix this while merging, there's no need for a v2. I don't see anything obviously wrong with the patchset, unfortunately I don't have an i2c tpm to test. Anyway Reviewed-by: Ilias Apalodimas P.S: Was the new TIS API useful? Thanks /Ilias > > Thanks, > > Eddie > > > > > > Regards > > /Ilias > > > > > +}; > > > -- > > > 2.27.0 > > >