From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E96AC433EF for ; Tue, 28 Jun 2022 22:43:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 48ACA83A31; Wed, 29 Jun 2022 00:43:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 539FC83AC3; Wed, 29 Jun 2022 00:43:48 +0200 (CEST) Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7F039839C3 for ; Wed, 29 Jun 2022 00:43:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=daniel@makrotopia.org Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1o6Jvq-0001vK-0I; Wed, 29 Jun 2022 00:43:42 +0200 Date: Tue, 28 Jun 2022 23:43:35 +0100 From: Daniel Golle To: Weijie Gao =?utf-8?B?KOmrmOaDn+adsCk=?= Cc: "u-boot@lists.denx.de" , GSS_MTK_Uboot_upstream Subject: Re: =?utf-8?B?5Zue5aSN?= =?utf-8?Q?=3A?= minor regression in U-Boot 2022.04 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Weijie, On Tue, Apr 12, 2022 at 01:40:00AM +0000, Weijie Gao (高惟杰) wrote: > Hi Daniel, > > I've also noticed this error message. > It seems that some struct variables containing all zero data of the pinctrl driver are not set to const, which causes these variables to be put into .bss section, instead of .rodata section. > As you know the .bss section does not exist in board_init_f stage, and its place is overlapped by dtb used by u-boot. This will result in incorrect data used by the pinctrl driver. > > I'll try to fix it later. Any news about the gobbled serial output issue? It would be nice to update uboot-mediatek in OpenWrt to v2022.04, so MT798x patches will easily apply on top. Cheers Daniel > > Best Regards > > Weijie > > -----邮件原件----- > 发件人: Daniel Golle > 发送时间: 2022年4月12日 6:44 > 收件人: u-boot@lists.denx.de; Weijie Gao (高惟杰) > 主题: minor regression in U-Boot 2022.04 > > Hi! > > I'm about to bump the U-Boot build for MediaTek MT7622 boards in OpenWrt to U-Boot 2022.04. While practially everything seems to work fine, I've noticed an error message early in the serial output which was not present in U-Boot 2022.01. It is even followed by a bunch of random characters which are different on every boot (hints to a read-out-of-bounds on uninitialzed memory or the like): > serial_mtk serial@11002000: pinctrl_select_state_full: uclass_get_device_by_phandle_id: err=-19 CC > > At another boot: > serial_mtk serial@11002000: pinctrl_select_state_full: uclass_get_device_by_phandle_id: err=-19 H H UI $&L 1.04-OpenWrt-r19423-c9c2b01b84 (Apr 11 2022 - 19:25:34 +0000) > > This is probably related to recent changes in dm and pinctrl, as there haven't been any changes to mtk_serial itself. > > Log including ROM and ARM Trusted Firmware A serial output: > > F0: 102B 0000 > F6: 0000 0000 > V0: 0000 0000 [0001] > 00: 0000 0000 > BP: 0400 0041 [0000] > G0: 1190 0000 > T0: 0000 02AD [000F] > Jump to BL > > NOTICE: BL2: v2.4(release):OpenWrt v2021-05-08-d2c75b21-2 (mt7622-snand-2ddr) > NOTICE: BL2: Built : 12:03:10, Apr 11 2022 > NOTICE: SPI-NAND: W25N01GV (128MB) > NOTICE: BL2: Booting BL31 > NOTICE: BL31: v2.4(release):OpenWrt v2021-05-08-d2c75b21-2 (mt7622-snand-2ddr) > NOTICE: BL31: Built : 12:03:10, Apr 11 2022 serial_mtk serial@11002000: pinctrl_select_state_full: uclass_get_device_by_phandle_id: err=-19 CC U-Boot 2022.04-OpenWrt-r19423-c9c2b01b84 (Apr 11 2022 - 19:25:34 +0000) > > CPU: MediaTek MT7622 > Model: mt7622-bpi-r64 > DRAM: 1 GiB > Core: 55 devices, 18 uclasses, devicetree: separate > MMC: mmc@11230000: 0, mmc@11240000: 1 > Loading Environment from UBI... SPI-NAND: W25N01GV (128MB) ... > > > I will most likely not investigate this any further, but thought it might be good to let you know. > > > Best regards > > > Daniel