public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Kever Yang <kever.yang@rock-chips.com>
Cc: sjg@chromium.org, philipp.tomsich@vrull.eu, cym@rock-chips.com,
	u-boot@lists.denx.de
Subject: Re: [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling
Date: Mon, 4 Jul 2022 10:23:52 +0100	[thread overview]
Message-ID: <YsKxqDFWW5UMISjc@google.com> (raw)
In-Reply-To: <cefa6e3e-0d57-b633-e987-66c354cd19d6@rock-chips.com>

On Fri, 01 Jul 2022, Kever Yang wrote:

> Hi Lee Jones,
> 
> 
> On 2022/6/27 16:39, Lee Jones wrote:
> > On Tue, 21 Jun 2022, Lee Jones wrote:
> > 
> > > Functions pointed to by this op pointer can return non-zero values
> > > indicating an error.  Ensure any error value is propagated back up the
> > > call-chain.
> > > 
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > ---
> > >   drivers/ram/rockchip/sdram_rk3399.c | 4 +++-
> > >   1 file changed, 3 insertions(+), 1 deletion(-)
> > Weekly check-in:
> > 
> > Are these still on someone's radar, or would you like me to [RESEND]?
> 
> It would be better to add leading message "rockchip:" in the subject.

That would be highly unusual.

Patch subjects are usually formed, as follows:

  "<subsystem>: <device>: <description>"

I only see 2 RAM-only patches (out of the 91 that touch this file)
that do as you suggested and you were the author of both of them. :)

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2022-07-04  9:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-21 10:07 [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling Lee Jones
2022-06-21 10:07 ` [PATCH 2/3] ram: rk3399: Fix faulty frequency change reports Lee Jones
2022-07-01 12:04   ` Kever Yang
2022-07-04 10:00   ` Xavier Drudis Ferran
2022-06-21 10:07 ` [PATCH 3/3] ram: rk3399: Conduct memory training at 400MHz Lee Jones
2022-07-01 12:05   ` Kever Yang
2022-07-04 10:01   ` Xavier Drudis Ferran
2022-06-27  8:39 ` [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling Lee Jones
2022-07-01 12:05   ` Kever Yang
2022-07-04  9:23     ` Lee Jones [this message]
2022-07-04 10:49       ` Kever Yang
2022-07-04 10:58         ` Lee Jones
2022-07-01 12:04 ` Kever Yang
2022-07-04  9:57 ` [SPAM] " Xavier Drudis Ferran
  -- strict thread matches above, loose matches on Subject: below --
2022-08-11  7:58 [PATCH 0/3] rockchip: Fix RAM training on RK3399 based platforms (Rock Pi 4) Lee Jones
2022-08-11  7:58 ` [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YsKxqDFWW5UMISjc@google.com \
    --to=lee.jones@linaro.org \
    --cc=cym@rock-chips.com \
    --cc=kever.yang@rock-chips.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox