From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>
Cc: xypron.glpk@gmx.de, ilias.apalodimas@linaro.org,
baocheng.su@siemens.com, jan.kiszka@siemens.com,
u-boot@lists.denx.de
Subject: Re: [PATCH 1/5] lib: crypto: add mscode_parser
Date: Tue, 5 Jul 2022 15:13:17 +0200 [thread overview]
Message-ID: <YsQ47RpsMudiIQG1@zx2c4.com> (raw)
In-Reply-To: <20220705054815.30318-2-takahiro.akashi@linaro.org>
On Tue, Jul 05, 2022 at 02:48:11PM +0900, AKASHI Takahiro wrote:
> + This option provides support for parsing MicroSoft's Authenticode
> + in pkcs7 message.
I chuckled when I saw "MicroSoft" in the cover letter, thinking it was a
wink, but here too... haha ummm. We could change it to "MikeRoweSoft"
instead in honor of the Belmont High School student. But... I think
"Microsoft" is what you're after here.
> + pr_devel("Data: %zu [%*ph]\n", data_len, (unsigned)(data_len),
> + content_data);
That's a weird cast around (data_len), but are you sure you want to keep
that print line in there?
Jason
next prev parent reply other threads:[~2022-07-05 13:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 5:48 [PATCH 0/5] efi_loader: fix a verification process issue in secure boot AKASHI Takahiro
2022-07-05 5:48 ` [PATCH 1/5] lib: crypto: add mscode_parser AKASHI Takahiro
2022-07-05 13:13 ` Jason A. Donenfeld [this message]
2022-07-06 1:07 ` AKASHI Takahiro
2022-07-05 5:48 ` [PATCH 2/5] efi_loader: signature: export efi_hash_regions() AKASHI Takahiro
2022-07-05 5:48 ` [PATCH 3/5] efi_loader: image_loader: replace EFI_PRINT with log macros AKASHI Takahiro
2022-07-05 15:26 ` Heinrich Schuchardt
2022-07-06 1:42 ` AKASHI Takahiro
2022-07-05 5:48 ` [PATCH 4/5] efi_loader: image_loader: add a missing digest verification for signed PE image AKASHI Takahiro
2022-07-05 15:29 ` Heinrich Schuchardt
2022-07-06 1:46 ` AKASHI Takahiro
2022-07-05 5:48 ` [PATCH 5/5] test/py: efi_secboot: add a test for a forged signed image AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsQ47RpsMudiIQG1@zx2c4.com \
--to=jason@zx2c4.com \
--cc=baocheng.su@siemens.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jan.kiszka@siemens.com \
--cc=takahiro.akashi@linaro.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox