From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E69B9C43334 for ; Tue, 5 Jul 2022 13:37:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8D69784514; Tue, 5 Jul 2022 15:37:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=zx2c4.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=zx2c4.com header.i=@zx2c4.com header.b="Q70zDIdT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 95810842E6; Tue, 5 Jul 2022 15:13:29 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4176282012 for ; Tue, 5 Jul 2022 15:13:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=zx2c4.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=SRS0=7kjP=XK=zx2c4.com=Jason@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5E02860F86; Tue, 5 Jul 2022 13:13:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05337C341C7; Tue, 5 Jul 2022 13:13:23 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="Q70zDIdT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1657026801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZOdAGKV/pVki3ZrmtM0wNzg9Pp1ghGT/fY7ADHCPfng=; b=Q70zDIdTbkS3XVtb8o+2KMitY274GP+NdV9576U47Np1k5lhJFGP3yG7YafrMMM+PcnpYR 9LapLaRONuGdsqu2U04iYWTXLqSZ+oQTSFZc6AHPi44n/rxgP9yQIExtNmL2nJrLr29aMg NOlbMoIQoFI2xeMDy57U8H00eKyuHG4= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 1a2a9594 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 5 Jul 2022 13:13:21 +0000 (UTC) Date: Tue, 5 Jul 2022 15:13:17 +0200 From: "Jason A. Donenfeld" To: AKASHI Takahiro Cc: xypron.glpk@gmx.de, ilias.apalodimas@linaro.org, baocheng.su@siemens.com, jan.kiszka@siemens.com, u-boot@lists.denx.de Subject: Re: [PATCH 1/5] lib: crypto: add mscode_parser Message-ID: References: <20220705054815.30318-1-takahiro.akashi@linaro.org> <20220705054815.30318-2-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220705054815.30318-2-takahiro.akashi@linaro.org> X-Mailman-Approved-At: Tue, 05 Jul 2022 15:37:45 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, Jul 05, 2022 at 02:48:11PM +0900, AKASHI Takahiro wrote: > + This option provides support for parsing MicroSoft's Authenticode > + in pkcs7 message. I chuckled when I saw "MicroSoft" in the cover letter, thinking it was a wink, but here too... haha ummm. We could change it to "MikeRoweSoft" instead in honor of the Belmont High School student. But... I think "Microsoft" is what you're after here. > + pr_devel("Data: %zu [%*ph]\n", data_len, (unsigned)(data_len), > + content_data); That's a weird cast around (data_len), but are you sure you want to keep that print line in there? Jason