From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95454C00140 for ; Sun, 31 Jul 2022 23:05:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8BB3484212; Mon, 1 Aug 2022 01:04:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="aIKBJ2kz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1E4A98420C; Mon, 1 Aug 2022 00:42:13 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 91DDD83EE2 for ; Mon, 1 Aug 2022 00:42:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xiang@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2164EB80D8E; Sun, 31 Jul 2022 22:42:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A980BC433D6; Sun, 31 Jul 2022 22:42:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659307328; bh=qP5eooVDnvm8UkEaZMLZ7aYDqktRjtGMMBcdl6LyKyo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aIKBJ2kz8f8Srib0hMRiw9T5up1jU8tLyqXAxtM3i6xsH4YeyWm452ZOkE5/H3hSA xbF9jBHDcpZUcIclYII706azHIxnk1WEyw/ugPgg060rYQP8icCtx1aYjvrGwxRZeL tsmOG2Chk+0rMuA52NX9XkxDDND461vHKQPLNF3VxhRD4MH/QjqlDDh3nNOmwdF8pk vmz5sBeEeAThv3yqkEjAZQOZdPP8aZZfayw8wHflWN/nxxZhByKcKVb3myDjbFZpOm p6sovAh8Oz3qNAlfxu0bmMgfmLQicEi43cSlpOTGqOLmBRVf7Bky5BMyvqEW4tjJV9 6GoJJ2Vu6sOfA== Date: Mon, 1 Aug 2022 06:42:04 +0800 From: Gao Xiang To: Heinrich Schuchardt Cc: Simon Glass , U-Boot Mailing List , linux-erofs@lists.ozlabs.org Subject: Re: [PATCH 1/1] fs/erofs: silence erofs_probe() Message-ID: Mail-Followup-To: Heinrich Schuchardt , Simon Glass , U-Boot Mailing List , linux-erofs@lists.ozlabs.org References: <20220731091006.50073-1-heinrich.schuchardt@canonical.com> <2d3db77a-66d1-8bac-dc53-30d322e6784f@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2d3db77a-66d1-8bac-dc53-30d322e6784f@canonical.com> X-Mailman-Approved-At: Mon, 01 Aug 2022 01:04:51 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Sun, Jul 31, 2022 at 10:53:52PM +0200, Heinrich Schuchardt wrote: > > > On 7/31/22 20:41, Simon Glass wrote: > > On Sun, 31 Jul 2022 at 03:10, Heinrich Schuchardt > > wrote: > > > > > > fs_set_blk_dev() probes all file-systems until it finds one that matches > > > the volume. We do not expect any console output for non-matching > > > file-systems. > > > > > > Convert error messages in erofs_read_superblock() to debug output. > > > > > > Fixes: 830613f8f5bb ("fs/erofs: add erofs filesystem support") > > > Signed-off-by: Heinrich Schuchardt > > > --- > > > fs/erofs/super.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > Reviewed-by: Simon Glass > > > > > > > > diff --git a/fs/erofs/super.c b/fs/erofs/super.c > > > index 4cca322b9e..095754dc28 100644 > > > --- a/fs/erofs/super.c > > > +++ b/fs/erofs/super.c > > > @@ -65,14 +65,14 @@ int erofs_read_superblock(void) > > > > > > ret = erofs_blk_read(data, 0, 1); > > > if (ret < 0) { > > > - erofs_err("cannot read erofs superblock: %d", ret); > > > + erofs_dbg("cannot read erofs superblock: %d", ret); > > > return -EIO; > > > } > > > dsb = (struct erofs_super_block *)(data + EROFS_SUPER_OFFSET); > > > > > > ret = -EINVAL; > > > if (le32_to_cpu(dsb->magic) != EROFS_SUPER_MAGIC_V1) { > > > - erofs_err("cannot find valid erofs superblock"); > > > + erofs_dbg("cannot find valid erofs superblock"); > > > return ret; > > > } > > > > > @@ -81,7 +81,7 @@ int erofs_read_superblock(void) > > > blkszbits = dsb->blkszbits; > > > /* 9(512 bytes) + LOG_SECTORS_PER_BLOCK == LOG_BLOCK_SIZE */ > > > if (blkszbits != LOG_BLOCK_SIZE) { > > > - erofs_err("blksize %u isn't supported on this platform", > > > + erofs_dbg("blksize %u isn't supported on this platform", > > > 1 << blkszbits); > > > > Does this message appear in normal scanning, or is it a genuine error? > > The erofs driver on Linux only supports LOG_BLOCK_SIZE == 12. So if we see > this message we don't have a valid erofs file system. > > @linux-erofs: > > The Linux driver requires EROFS_BLKSIZ == PAGE_SIZE == 4096. > The page size on arm64 can be 4 KiB, 16 KiB, or 64 KiB. > The page size on amd64 can be 4 KiB, 2 MiB or 4 MiB. > Requiring EROFS_BLKSIZ == PAGE_SIZE is obviously a restriction that should > be lifted. Yeah, EROFS doesn't support EROFS_BLKSIZ != PAGE_SIZE explicitly for now, please help error out this message. Thanks! Thanks, Gao Xiang > > Best regards > > Heinrich