From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1195C19F2C for ; Wed, 3 Aug 2022 10:41:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5511984205; Wed, 3 Aug 2022 12:41:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 74FA88449C; Wed, 3 Aug 2022 12:41:22 +0200 (CEST) Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2FDEF841B7 for ; Wed, 3 Aug 2022 12:41:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 273Af8XB018899; Wed, 3 Aug 2022 18:41:08 +0800 (+08) (envelope-from ycliang@andestech.com) Received: from ubuntu01 (10.0.12.75) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Wed, 3 Aug 2022 18:41:06 +0800 Date: Wed, 3 Aug 2022 10:41:01 +0000 From: Leo Liang To: Nikita Shubin CC: , Nikita Shubin , Rick Chen , , , Subject: Re: [PATCH] riscv: cpu: set gp before board_init_f_init_reserve Message-ID: References: <20220520114118.19354-1-nikita.shubin@maquefel.me> <20220802132924.087451cb@redslave.neermore.group> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220802132924.087451cb@redslave.neermore.group> User-Agent: Mutt/2.0.5 (2021-01-21) X-Originating-IP: [10.0.12.75] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 273Af8XB018899 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Nikita, On Tue, Aug 02, 2022 at 01:29:24PM +0300, Nikita Shubin wrote: > Hello Leo! > > On Wed, 1 Jun 2022 02:07:34 +0000 > Leo Liang wrote: > > > On Fri, May 20, 2022 at 02:41:17PM +0300, Nikita Shubin wrote: > > > From: Nikita Shubin > > > > > > Restore global pointer before board_init_f_init_reserve call, > > > as "a0" can be set in harts_early_init call and we end up with > > > invalid global pointer. > > > > > > Signed-off-by: Nikita Shubin > > > --- > > > arch/riscv/cpu/start.S | 1 + > > > 1 file changed, 1 insertion(+) > > > > Reviewed-by: Leo Yu-Chi Liang > > Any further motion on this ? Sorry for keeping you waiting for so long. This patch is merged in riscv tree and PR will be sent ASAP once the CI result shows no issue. Best regards, Leo > > Yours, > Nikita Shubin. >