* [PATCH] drivers: usb: fastboot: Fix full-speed usb descriptor
@ 2022-08-22 1:18 qianfanguijin
2022-08-22 10:01 ` John Keeping
0 siblings, 1 reply; 2+ messages in thread
From: qianfanguijin @ 2022-08-22 1:18 UTC (permalink / raw)
To: u-boot; +Cc: Lukasz Majewski, Marek Vasut, qianfan Zhao
From: qianfan Zhao <qianfanguijin@163.com>
The host will report such error message if the fastboot device work in
full-speed mode: "Duplicate descriptor for config 1 interface 0
altsetting 0, skipping"
Fastboot device ack both full and high speed interface descriptors when
work in full-speed mode, that's will cause this issue.
Fix it.
Signed-off-by: qianfan Zhao <qianfanguijin@163.com>
---
drivers/usb/gadget/f_fastboot.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c
index 8ba55aab9f..d0e92c7a07 100644
--- a/drivers/usb/gadget/f_fastboot.c
+++ b/drivers/usb/gadget/f_fastboot.c
@@ -119,6 +119,7 @@ static struct usb_descriptor_header *fb_fs_function[] = {
(struct usb_descriptor_header *)&interface_desc,
(struct usb_descriptor_header *)&fs_ep_in,
(struct usb_descriptor_header *)&fs_ep_out,
+ NULL,
};
static struct usb_descriptor_header *fb_hs_function[] = {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: usb: fastboot: Fix full-speed usb descriptor
2022-08-22 1:18 [PATCH] drivers: usb: fastboot: Fix full-speed usb descriptor qianfanguijin
@ 2022-08-22 10:01 ` John Keeping
0 siblings, 0 replies; 2+ messages in thread
From: John Keeping @ 2022-08-22 10:01 UTC (permalink / raw)
To: qianfanguijin; +Cc: u-boot, Lukasz Majewski, Marek Vasut
On Mon, Aug 22, 2022 at 09:18:31AM +0800, qianfanguijin@163.com wrote:
> From: qianfan Zhao <qianfanguijin@163.com>
>
> The host will report such error message if the fastboot device work in
> full-speed mode: "Duplicate descriptor for config 1 interface 0
> altsetting 0, skipping"
>
> Fastboot device ack both full and high speed interface descriptors when
> work in full-speed mode, that's will cause this issue.
>
> Fix it.
>
> Signed-off-by: qianfan Zhao <qianfanguijin@163.com>
Reviewed-by: John Keeping <john@metanate.com>
> ---
> drivers/usb/gadget/f_fastboot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c
> index 8ba55aab9f..d0e92c7a07 100644
> --- a/drivers/usb/gadget/f_fastboot.c
> +++ b/drivers/usb/gadget/f_fastboot.c
> @@ -119,6 +119,7 @@ static struct usb_descriptor_header *fb_fs_function[] = {
> (struct usb_descriptor_header *)&interface_desc,
> (struct usb_descriptor_header *)&fs_ep_in,
> (struct usb_descriptor_header *)&fs_ep_out,
> + NULL,
> };
>
> static struct usb_descriptor_header *fb_hs_function[] = {
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-22 10:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-22 1:18 [PATCH] drivers: usb: fastboot: Fix full-speed usb descriptor qianfanguijin
2022-08-22 10:01 ` John Keeping
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox