From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBE8DC28D13 for ; Mon, 22 Aug 2022 10:01:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A53FD84355; Mon, 22 Aug 2022 12:01:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=metanate.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=metanate.com header.i=@metanate.com header.b="SN8MoM6I"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 732B6844EB; Mon, 22 Aug 2022 12:01:30 +0200 (CEST) Received: from metanate.com (unknown [IPv6:2001:8b0:1628:5005::111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4ECAE841AA for ; Mon, 22 Aug 2022 12:01:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=metanate.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=john@metanate.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metanate.com; s=stronger; h=In-Reply-To:Content-Type:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description; bh=exeLDuZ60CPvRaEAgSuSxuhPVLac8g8STvMfM5J9KC0=; b=SN8Mo M6IQDd5Ii0Qz9P1Z9baz2JbwZrbr8+iTsojvPwHE5s5ChyP+7EoIxNOn5otHOEA47WNxUE5baGFVo ViFosMjS7OCz60tnUkw25AMf3nHDAIsr3ZKTa3EXdroHVXnoHjZPp0FQ+7ytDjh7Cn2z4MUl1EOlj MO8XViuba6h38z0DSoImC66p5Leb0DIgN1pKt3GjrsfXof1w7Z0v+6gP+Obq+bXltdZDedw0MK3Vl pXj3PC7DUuO1eSJSpWNwhyErruxnRN6pnKP7hah3u3aUMrMnWcYpNBzxhnywyQslXLmQv+TKwVO7R wJ9la9U730dvLKdMKp9XDSjOctPzQ==; Received: from [81.174.171.191] (helo=donbot) by email.metanate.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oQ4FG-0002rz-1a; Mon, 22 Aug 2022 11:01:22 +0100 Date: Mon, 22 Aug 2022 11:01:21 +0100 From: John Keeping To: qianfanguijin@163.com Cc: u-boot@lists.denx.de, Lukasz Majewski , Marek Vasut Subject: Re: [PATCH] drivers: usb: fastboot: Fix full-speed usb descriptor Message-ID: References: <20220822011831.18961-1-qianfanguijin@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220822011831.18961-1-qianfanguijin@163.com> X-Authenticated: YES X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Mon, Aug 22, 2022 at 09:18:31AM +0800, qianfanguijin@163.com wrote: > From: qianfan Zhao > > The host will report such error message if the fastboot device work in > full-speed mode: "Duplicate descriptor for config 1 interface 0 > altsetting 0, skipping" > > Fastboot device ack both full and high speed interface descriptors when > work in full-speed mode, that's will cause this issue. > > Fix it. > > Signed-off-by: qianfan Zhao Reviewed-by: John Keeping > --- > drivers/usb/gadget/f_fastboot.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c > index 8ba55aab9f..d0e92c7a07 100644 > --- a/drivers/usb/gadget/f_fastboot.c > +++ b/drivers/usb/gadget/f_fastboot.c > @@ -119,6 +119,7 @@ static struct usb_descriptor_header *fb_fs_function[] = { > (struct usb_descriptor_header *)&interface_desc, > (struct usb_descriptor_header *)&fs_ep_in, > (struct usb_descriptor_header *)&fs_ep_out, > + NULL, > }; > > static struct usb_descriptor_header *fb_hs_function[] = { > -- > 2.25.1 >