From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE2B6ECAAD3 for ; Sun, 4 Sep 2022 16:20:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DC7198418B; Sun, 4 Sep 2022 18:20:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="b18Pxg1h"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 98CBB8418B; Sun, 4 Sep 2022 18:20:07 +0200 (CEST) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 97E7384001 for ; Sun, 4 Sep 2022 18:20:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ed1-x536.google.com with SMTP id t5so8563453edc.11 for ; Sun, 04 Sep 2022 09:20:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=gbJCs3FwwgYKxWVVIpI2N6E7w0myk5XuSqX4flj9WfE=; b=b18Pxg1huy/+0PeJkLXdB19VF2K+Tw8LRx+3E/uqeCMd6zaueOqHtnOQRP8XvJZy7p uYL+koYarO0tFDyby11EctetDbp6BwqPXQ3bz7gayZfq90luXwpccxw/yReLvDOS7xl+ sdWeAbBXqI4NRXZQZN2W+C0Au9pEQZTsbuTdMtf/xOAQ7dHFD9OtciNdzqDMSUmBHKqg tGm1sfF6dC4CXSxFsaVR6yafNrC11sckv3W4FMqauymhgJuRfWx1s6HcyFOvC2KbFqKc e5su2PXdkMCIgjg58iWeGwGprjV0tjZPHAv7FE6yBig5w5VW2O89jd1rJZJ8JGwFIslL V/Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=gbJCs3FwwgYKxWVVIpI2N6E7w0myk5XuSqX4flj9WfE=; b=KQXRtdG+4kRwFTUQXPba33m1EBmzOK18gRsZym1/YWWYpDrSBUdXiwFsMMlRZyUkUZ IZ9CNLNCIYBglv7NfxxGM07IP+/14lK3ZftFGJc6bsqfKvCgRd6TJmRauroL/S2nRQ9Q beS4Ph6jvkud1qDpoyxy7uaqRE20VO0psqY+UEm6dwUazgyM+x7if2WBtNBwchg4/vjG Su7/le9SpiiBHPDYcdcufvc6KRqC49zaocKJH7PdQafPHyc+hUKngCqKwRV27+U9dJea MqK6DUS24KvOhWek/2HxVYqt9X6ZMFlQmRAB0uIocapnjCLJyyTAmO4o0xRDoY2opuHB n8rw== X-Gm-Message-State: ACgBeo1D4SMq2I6yd9avEkh5HzZqQMW0xjY0ZjaXB1TJ0DasssyQH+3L skRsL1C1kr5/5+TONeIsLLGIsw== X-Google-Smtp-Source: AA6agR42uTw7jWNmYc2VYwLCaw4LtpaBDg1AT2jKTz1gh+NYpkcA5Pn7LoXU4OAO96LloD6/oYCzmA== X-Received: by 2002:a05:6402:524b:b0:448:6824:8788 with SMTP id t11-20020a056402524b00b0044868248788mr29438882edd.227.1662308404208; Sun, 04 Sep 2022 09:20:04 -0700 (PDT) Received: from hades ([46.103.15.185]) by smtp.gmail.com with ESMTPSA id g23-20020a17090669d700b0073cdeedf56fsm3858301ejs.57.2022.09.04.09.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Sep 2022 09:20:03 -0700 (PDT) Date: Sun, 4 Sep 2022 19:20:01 +0300 From: Ilias Apalodimas To: Heinrich Schuchardt Cc: u-boot@lists.denx.de, Jose Marinho Subject: Re: [PATCH v2 2/2] efi_selftest: unit test for EFI Conformance Profile Table Message-ID: References: <20220903150115.51558-1-heinrich.schuchardt@canonical.com> <20220903150115.51558-3-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Sun, Sep 04, 2022 at 09:53:03AM +0200, Heinrich Schuchardt wrote: > > > On 9/4/22 07:08, Ilias Apalodimas wrote: > > Hi Heinrich, > > > > [...] > > > > > + */ > > > +static int ecpt_find_guid(struct efi_conformance_profiles_table *ecpt, > > > + const efi_guid_t *guid) { > > > + int i; > > > + > > > + for (i = 0; i < ecpt->number_of_profiles; ++i) { > > > + if (!memcmp(&ecpt->conformance_profiles[i], guid, 16)) > > > + return EFI_ST_SUCCESS; > > > > Can't we use guidcmp here? > > I would prefer to keep the unit tests independent of U-Boot's library > functions so that we can opt to compile them as freestanding UEFI > application. > > Best regards Fair enough, Reviewed-by: Ilias Apalodimas > > Heinrich > > > > > > + } > > > + efi_st_error("GUID %pU not found\n", guid); > > > + return EFI_ST_FAILURE; > > > +} > > > + > > > +/* > > [...] > > > > Thanks > > /Ilias