From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 1/1] test: fix some pylint errors in test_efi_secboot
Date: Wed, 5 Oct 2022 10:02:53 +0300 [thread overview]
Message-ID: <Yz0sHe81AMu9Mn60@hades> (raw)
In-Reply-To: <20221001185709.26980-1-heinrich.schuchardt@canonical.com>
On Sat, Oct 01, 2022 at 08:57:09PM +0200, Heinrich Schuchardt wrote:
> * Remove unused import
> * Provide module docstring
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> test/py/tests/test_efi_secboot/conftest.py | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/test/py/tests/test_efi_secboot/conftest.py b/test/py/tests/test_efi_secboot/conftest.py
> index db6b8d301f..406131cb45 100644
> --- a/test/py/tests/test_efi_secboot/conftest.py
> +++ b/test/py/tests/test_efi_secboot/conftest.py
> @@ -2,18 +2,12 @@
> # Copyright (c) 2019, Linaro Limited
> # Author: AKASHI Takahiro <takahiro.akashi@linaro.org>
>
> -import os
> -import os.path
> -from subprocess import call, check_call, check_output, CalledProcessError
> +""" Fixture for UEFI secure boot test """
> +
> +from subprocess import call, check_call, CalledProcessError
> import pytest
> from defs import *
>
> -
> -#
> -# Fixture for UEFI secure boot test
> -#
> -
> -
> @pytest.fixture(scope='session')
> def efi_boot_env(request, u_boot_config):
> """Set up a file system to be used in UEFI secure boot test.
> --
> 2.37.2
>
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
prev parent reply other threads:[~2022-10-05 7:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 18:57 [PATCH 1/1] test: fix some pylint errors in test_efi_secboot Heinrich Schuchardt
2022-10-05 7:02 ` Ilias Apalodimas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz0sHe81AMu9Mn60@hades \
--to=ilias.apalodimas@linaro.org \
--cc=heinrich.schuchardt@canonical.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox