From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E59F9C433FE for ; Thu, 6 Oct 2022 07:37:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 22C2084940; Thu, 6 Oct 2022 09:37:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="GRJoyhIe"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4DCF48492C; Thu, 6 Oct 2022 09:37:11 +0200 (CEST) Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 701138492C for ; Thu, 6 Oct 2022 09:37:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ej1-x632.google.com with SMTP id kg6so2590861ejc.9 for ; Thu, 06 Oct 2022 00:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=+h0x4VzdeJe7gGPYmnYsPuyqYC6F5fb/WUdcCoz1JDo=; b=GRJoyhIeH7DIbSCyxDt0X34R98zSoBVGk0F6AFn7Up7BWiElIPK+Ix3HIohlI+WRTU i4ggIyBaBdLUaDT0xdZzwBdtl3I/IhKww3VF7DxqBoRAatg1viqtZX/BB6WpouJNxOt5 fNCtdLZlKmd0PS1Vh84LAC2uz+H+NlruxspMFuTY5x02IptSmbZe3QJ00HG2VI47jMqL ZAy/+BcpM+ndyQ4AndKrTTQXyyqOF6nQ1dwENRyK9lGS6Lvrj4ba4mVpnL5nx1RlapE6 fhkj/ixhwaTnUgA0/jPjHIWl9ZwuB77iTTV1b7EvnCx8nfSypJOGX5JnrE6HFhQqN9yp 79jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=+h0x4VzdeJe7gGPYmnYsPuyqYC6F5fb/WUdcCoz1JDo=; b=BH8qYZEidVh86O1cgE3cP1CTkc3pI2bwdA5Wq83Evg28alPudyb8Hu0QSnvrg8SPhD WjYw1MIresDnxY8+JdQqX28N3MUR/3GU5+z/kNbt/rXI0iUuSnLuGPV+2yuZ0vE+UeCw VGsf6mLHNNLu8FMmCVXYRu79H4p1uGrBO3AkLYrbeEum9e5ZZgvnH3cww5Q8O6xtcLj8 GUxF0lJJ4fKkwYXgA1KTTy5Bjrv/rQpWl2uYhgu33/UVVk/YkrjUOEmjNc343X4id+4z sSJi683uR2nwAsA9hdImUZCWvDXB6/rk0nbxMgXQ4ijqJ3n50QGfi5h2K/irTOo+iRzJ 1+gQ== X-Gm-Message-State: ACrzQf2fS5wxb9Yo7GSF53dQfAUtKwgucseky9thTe4C2pr/fXKJ4nzY 69YeXJxg4WogPxb8Py3kbKOVww== X-Google-Smtp-Source: AMsMyM4/ykxKoCyRzeiZZV75gLwgpRYJoHXGK/UzqMVgBd0yYRBdcaTpx4Ac9auqhKUSGEVV4ioMzg== X-Received: by 2002:a17:907:a48:b0:77c:51b0:5aeb with SMTP id be8-20020a1709070a4800b0077c51b05aebmr2912447ejc.61.1665041827891; Thu, 06 Oct 2022 00:37:07 -0700 (PDT) Received: from hera (ppp046103015185.access.hol.gr. [46.103.15.185]) by smtp.gmail.com with ESMTPSA id n15-20020aa7c78f000000b00458d50b4a24sm5163797eds.96.2022.10.06.00.37.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 00:37:07 -0700 (PDT) Date: Thu, 6 Oct 2022 10:37:05 +0300 From: Ilias Apalodimas To: Heinrich Schuchardt Cc: u-boot@lists.denx.de, AKASHI Takahiro Subject: Re: [RFC PATCH 1/2] efi_loader: define internal implementations of install/uninstallmultiple Message-ID: References: <20221005152603.3085754-1-ilias.apalodimas@linaro.org> <20221005152603.3085754-2-ilias.apalodimas@linaro.org> <4f29d908-6ce5-3a68-5d2e-dbb08c7dd3a2@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f29d908-6ce5-3a68-5d2e-dbb08c7dd3a2@gmx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich [...] > > diff --git a/lib/efi_loader/efi_load_initrd.c b/lib/efi_loader/efi_load_initrd.c > > index 3d6044f76047..87fde3f88c2b 100644 > > --- a/lib/efi_loader/efi_load_initrd.c > > +++ b/lib/efi_loader/efi_load_initrd.c > > @@ -208,14 +208,13 @@ efi_status_t efi_initrd_register(void) > > if (ret != EFI_SUCCESS) > > return ret; > > > > - ret = EFI_CALL(efi_install_multiple_protocol_interfaces > > - (&efi_initrd_handle, > > - /* initramfs */ > > - &efi_guid_device_path, &dp_lf2_handle, > > - /* LOAD_FILE2 */ > > - &efi_guid_load_file2_protocol, > > - (void *)&efi_lf2_protocol, > > - NULL)); > > + ret = efi_install_multiple_protocol_interfaces(&efi_initrd_handle, > > + /* initramfs */ > > + &efi_guid_device_path, &dp_lf2_handle, > > + /* LOAD_FILE2 */ > > + &efi_guid_load_file2_protocol, > > + (void *)&efi_lf2_protocol, > > + NULL); > > > > return ret; > > } > > diff --git a/lib/efi_loader/efi_root_node.c b/lib/efi_loader/efi_root_node.c > > index 739c6867f412..b4696d54c33d 100644 > > --- a/lib/efi_loader/efi_root_node.c > > +++ b/lib/efi_loader/efi_root_node.c > > Please, put these changes into a separate patch. > Shouldn't they go in the same patchset? We are changing the definition of efi_install_multiple_protocol_interfaces() so EFI_ENTRY/EFI_EXIT is not there anymore and we don't need EFI_CALL to save/restore the gd on entry/exit. Thanks /Ilias > Best regards > > Heinrich > > > @@ -49,38 +49,38 @@ efi_status_t efi_root_node_register(void) > > dp->end.length = sizeof(struct efi_device_path); > > > > /* Create root node and install protocols */ > > - ret = EFI_CALL(efi_install_multiple_protocol_interfaces > > - (&efi_root, > > - /* Device path protocol */ > > - &efi_guid_device_path, dp, > > + ret = efi_install_multiple_protocol_interfaces > > + (&efi_root, > > + /* Device path protocol */ > > + &efi_guid_device_path, dp, > > #if CONFIG_IS_ENABLED(EFI_DEVICE_PATH_TO_TEXT) > > - /* Device path to text protocol */ > > - &efi_guid_device_path_to_text_protocol, > > - (void *)&efi_device_path_to_text, > > + /* Device path to text protocol */ > > + &efi_guid_device_path_to_text_protocol, > > + (void *)&efi_device_path_to_text, > > #endif > > #ifdef CONFIG_EFI_DEVICE_PATH_UTIL > > - /* Device path utilities protocol */ > > - &efi_guid_device_path_utilities_protocol, > > - (void *)&efi_device_path_utilities, > > + /* Device path utilities protocol */ > > + &efi_guid_device_path_utilities_protocol, > > + (void *)&efi_device_path_utilities, > > #endif > > #ifdef CONFIG_EFI_DT_FIXUP > > - /* Device-tree fix-up protocol */ > > - &efi_guid_dt_fixup_protocol, > > - (void *)&efi_dt_fixup_prot, > > + /* Device-tree fix-up protocol */ > > + &efi_guid_dt_fixup_protocol, > > + (void *)&efi_dt_fixup_prot, > > #endif > > #if CONFIG_IS_ENABLED(EFI_UNICODE_COLLATION_PROTOCOL2) > > - &efi_guid_unicode_collation_protocol2, > > - (void *)&efi_unicode_collation_protocol2, > > + &efi_guid_unicode_collation_protocol2, > > + (void *)&efi_unicode_collation_protocol2, > > #endif > > #if CONFIG_IS_ENABLED(EFI_LOADER_HII) > > - /* HII string protocol */ > > - &efi_guid_hii_string_protocol, > > - (void *)&efi_hii_string, > > - /* HII database protocol */ > > - &efi_guid_hii_database_protocol, > > - (void *)&efi_hii_database, > > + /* HII string protocol */ > > + &efi_guid_hii_string_protocol, > > + (void *)&efi_hii_string, > > + /* HII database protocol */ > > + &efi_guid_hii_database_protocol, > > + (void *)&efi_hii_database, > > #endif > > - NULL)); > > + NULL); > > efi_root->type = EFI_OBJECT_TYPE_U_BOOT_FIRMWARE; > > return ret; > > } >