Re: [PATCH v3 3/3] am335x_evm_defconfig: Enable Micron SPI flash support

Paul Barker
2022-10-03T12:07:16Z

[-- Attachment #1.1.1: Type: text/plain, Size: 1077 bytes --]

On 26/09/2022 14:21, Heinrich Schuchardt wrote:
> On 9/21/22 18:06, Paul Barker wrote:
>> Signed-off-by: Paul Barker <paul.barker@sancloud.com>
>> ---
>>   configs/am335x_evm_defconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/configs/am335x_evm_defconfig b/configs/am335x_evm_defconfig
>> index f0fbe475b394..f73123e0b71d 100644
>> --- a/configs/am335x_evm_defconfig
>> +++ b/configs/am335x_evm_defconfig
>> @@ -92,6 +92,7 @@ CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y
>>   CONFIG_SYS_NAND_U_BOOT_OFFS=0xc0000
>>   CONFIG_DM_SPI_FLASH=y
>>   CONFIG_SF_DEFAULT_SPEED=24000000
>> +CONFIG_SPI_FLASH_STMICRO=y
>
> You don't enable CONFIG_EFI_SPI_PROTOCOL anywhere; not even on the
> sandbox. So the code is never compiled and never tested. This cannot be
> correct.

I've left this config off by default - it can be turned on as needed.

I've ran the self tests with this option enabled and everything passes.

Thanks,

--
Paul Barker
Principal Software Engineer
SanCloud Ltd

e: paul.barker@sancloud.com
w: https://sancloud.com/

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 6865 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]