Re: [PATCH v3 2/3] arm: dts: am335x-sancloud-bbe-lite: UEFI SPI export

Heinrich Schuchardt
2022-09-26T13:33:53Z

On 9/26/22 15:13, Tom Rini wrote:
> On Mon, Sep 26, 2022 at 02:33:23PM +0300, Ilias Apalodimas wrote:
>> Hi Tom
>>
>> On Wed, 21 Sept 2022 at 19:15, Tom Rini <trini@konsulko.com> wrote:
>>>
>>> On Wed, Sep 21, 2022 at 05:06:27PM +0100, Paul Barker wrote:
>>>> Add properties to the Authenta SPI flash device node to enable access by
>>>> a UEFI application using a fixed GUID. Also specify that this device is
>>>> JEDEC compatible so that it is correctly initialized when running
>>>> `sf probe`.
>>>>
>>>> Signed-off-by: Paul Barker <paul.barker@sancloud.com>
>>>> ---
>>>> arch/arm/dts/am335x-sancloud-bbe-lite.dts | 10 ++++++++--
>>>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/arch/arm/dts/am335x-sancloud-bbe-lite.dts b/arch/arm/dts/am335x-sancloud-bbe-lite.dts
>>>> index d6ef19311a91..f1ff9d6024cb 100644
>>>> --- a/arch/arm/dts/am335x-sancloud-bbe-lite.dts
>>>> +++ b/arch/arm/dts/am335x-sancloud-bbe-lite.dts
>>>> @@ -37,14 +37,20 @@
>>>> pinctrl-names = "default";
>>>> pinctrl-0 = <&bb_spi0_pins>;
>>>>
>>>> - channel@0 {
>>>> + authenta-flash@0 {
>>>> #address-cells = <1>;
>>>> #size-cells = <0>;
>>>>
>>>> - compatible = "micron,spi-authenta";
>>>> + compatible = "micron,spi-authenta", "jedec,spi-nor";
>>>>
>>>> reg = <0>;
>>>> spi-max-frequency = <16000000>;
>>>> spi-cpha;
>>>> +
>>>> + uefi-spi-vendor = "micron";
>>>> + uefi-spi-part-number = "mt25ql128abb";
>>>> + /* GUID in UEFI format: 77126730-a4ca-4386-b341-881fe18e7f7d */
>>>> + uefi-spi-io-guid = [30 67 12 77 ca a4 86 43
>>>> + b3 41 88 1f e1 8e 7f 7d];
>>>> };
>>>> };
>>>
>>> Are we far enough along with part one of this series to talk about
>>> getting these properties in the upstream binding document now?
>>
>> You mean those bindings being part of the DT spec?
>
> Yes, getting these added to
> Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml in the kernel.
>

There is a related patch
[PATCH] dt-bindings: spi: Add YAML DT binding document for trivial devices
https://lore.kernel.org/all/20220407194936.223041-1-marex@denx.de/
that didn't make it into the kernel yet.

Best regards

Heinrich