Re: [PATCH v3 1/3] efi_loader: Add SPI I/O protocol support

Paul Barker
2022-10-03T12:05:32Z

[-- Attachment #1.1.1: Type: text/plain, Size: 611 bytes --]

Addressing only the comments which I've not covered in my reply to Ilias' email:

On 26/09/2022 14:13, Heinrich Schuchardt wrote:
> On 9/26/22 14:43, Ilias Apalodimas wrote:
>> On Wed, Sep 21, 2022 at 05:06:26PM +0100, Paul Barker wrote:
>>> +static efi_string_t convert_efi_string(const char *str)
>>> +{
>>> +    efi_string_t str_16, tmp;
>>> +    size_t sz_8, sz_16;
>>> +
>>> +    sz_8 = strlen(str);
>
> sz_8 seems to be unused.

I'll drop this in v4.

Thanks,

--
Paul Barker
Principal Software Engineer
SanCloud Ltd

e: paul.barker@sancloud.com
w: https://sancloud.com/

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 6865 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]