Re: [PATCH v3 3/3] am335x_evm_defconfig: Enable Micron SPI flash support

Heinrich Schuchardt
2022-09-26T13:21:41Z

On 9/21/22 18:06, Paul Barker wrote:
> Signed-off-by: Paul Barker <paul.barker@sancloud.com>
> ---
> configs/am335x_evm_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configs/am335x_evm_defconfig b/configs/am335x_evm_defconfig
> index f0fbe475b394..f73123e0b71d 100644
> --- a/configs/am335x_evm_defconfig
> +++ b/configs/am335x_evm_defconfig
> @@ -92,6 +92,7 @@ CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y
> CONFIG_SYS_NAND_U_BOOT_OFFS=0xc0000
> CONFIG_DM_SPI_FLASH=y
> CONFIG_SF_DEFAULT_SPEED=24000000
> +CONFIG_SPI_FLASH_STMICRO=y

You don't enable CONFIG_EFI_SPI_PROTOCOL anywhere; not even on the
sandbox. So the code is never compiled and never tested. This cannot be
correct.

Best regards

Heinrich

> CONFIG_SPI_FLASH_WINBOND=y
> CONFIG_PHY_ATHEROS=y
> CONFIG_PHY_SMSC=y