From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A966BC04A95 for ; Wed, 28 Sep 2022 18:50:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 66F1A84BE4; Wed, 28 Sep 2022 20:50:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=triops.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=triops.cz header.i=@triops.cz header.b="J5oozD5v"; dkim=pass (2048-bit key) header.d=triops.cz header.i=@triops.cz header.b="J5oozD5v"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 92B9D84B9E; Wed, 28 Sep 2022 19:53:44 +0200 (CEST) Received: from h1.cmg1.smtp.forpsi.com (h1.cmg1.smtp.forpsi.com [81.2.195.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9859684B67 for ; Wed, 28 Sep 2022 19:53:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=triops.cz Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=oss-lists@triops.cz Received: from lenoch ([176.102.154.174]) by cmgsmtp with ESMTPSA id dbFboNp98vULgdbFcolFz5; Wed, 28 Sep 2022 19:53:41 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=triops.cz; s=f2019; t=1664387621; bh=miQakbauLbIcUohAxGo1yVO+vQavAMCSpPyWf2QJtu0=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=J5oozD5v8LXHjRKwJT9Tt3p8JiT4jHgrV3dQJOS0msEiJ7H1j1wTcQ4ZVwKpkfHOq qEUa6iKeR92pTp42UoAjiaxQPQeRzo64a2d1uQsKE6hIew8t4bgjl7lOiH7NEvwOh0 zmRtxYo5FIzZr7suhfeMYx7e30cdCnNDyJeK4ZRb8vgFio4pWoK2aC3Y37N4Wi2BUn 9H+XZ9q5Df6afZr8R/+6/ck8jK+t5z75J8qfywNDvGF9FDpNp8iYmJbAfM4OqihNH5 N/sLKjK0KO+Xz9YcWG7yXrUyWCGQe3l5Cjf1MpvuiqEE6jLsibQlmwQrI2XlutAmjl 22TJfLhI86zqA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=triops.cz; s=f2019; t=1664387621; bh=miQakbauLbIcUohAxGo1yVO+vQavAMCSpPyWf2QJtu0=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=J5oozD5v8LXHjRKwJT9Tt3p8JiT4jHgrV3dQJOS0msEiJ7H1j1wTcQ4ZVwKpkfHOq qEUa6iKeR92pTp42UoAjiaxQPQeRzo64a2d1uQsKE6hIew8t4bgjl7lOiH7NEvwOh0 zmRtxYo5FIzZr7suhfeMYx7e30cdCnNDyJeK4ZRb8vgFio4pWoK2aC3Y37N4Wi2BUn 9H+XZ9q5Df6afZr8R/+6/ck8jK+t5z75J8qfywNDvGF9FDpNp8iYmJbAfM4OqihNH5 N/sLKjK0KO+Xz9YcWG7yXrUyWCGQe3l5Cjf1MpvuiqEE6jLsibQlmwQrI2XlutAmjl 22TJfLhI86zqA== Date: Wed, 28 Sep 2022 19:53:39 +0200 From: Ladislav Michl To: Tom Rini Cc: Enric Balletbo i Serra , u-boot@lists.denx.de Subject: Re: [PATCH 15/21] igep00x0: Disable networking Message-ID: References: <20220802113424.2988464-1-trini@konsulko.com> <20220802113424.2988464-16-trini@konsulko.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220802113424.2988464-16-trini@konsulko.com> X-CMAE-Envelope: MS4wfIptnvF1x3izekwM3uukdU4ry9TBHdRVIVtY36Ti+tEHhFH1G6tVRM+ho6To+xlwWK5GcdA8T5RZdV86pHyaag4sCzmgYG+HjTc5QNE0xd9f1kzZ0z1b oAtUzNskySqvt2OPEZEBuEBNSR0lUYsCPkTiBeXs+sXvIAifQXqsnVkKwLK25SJmQYEn5lx5rnezU55VOOiFMYel8C4jB1v3yqPpZbU0ktXXefq7na586ZEI X-Mailman-Approved-At: Wed, 28 Sep 2022 20:50:31 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, Aug 02, 2022 at 07:33:41AM -0400, Tom Rini wrote: > This platform needs to be converted to use DM_ETH as the deadline is 2 > years passed due. Disable networking support for now. Oh well, my bad. There are too many patches accumulated. Please see bellow for original version for reference (applied after this one is reverted) Alternatively I can rebase on current master, just let me know whichever way you prefer. ladis > Cc: Enric Balletbo i Serra > Signed-off-by: Tom Rini > --- > board/isee/igep00x0/igep00x0.c | 58 ---------------------------------- > configs/igep00x0_defconfig | 5 +-- > 2 files changed, 1 insertion(+), 62 deletions(-) > > diff --git a/board/isee/igep00x0/igep00x0.c b/board/isee/igep00x0/igep00x0.c > index 0932f62b9beb..6c5e6fbbcb0d 100644 > --- a/board/isee/igep00x0/igep00x0.c > +++ b/board/isee/igep00x0/igep00x0.c > @@ -88,62 +88,6 @@ int onenand_board_init(struct mtd_info *mtd) > return 1; > } > > -#if defined(CONFIG_CMD_NET) > -static void reset_net_chip(int gpio) > -{ > - if (!gpio_request(gpio, "eth nrst")) { > - gpio_direction_output(gpio, 1); > - udelay(1); > - gpio_set_value(gpio, 0); > - udelay(40); > - gpio_set_value(gpio, 1); > - mdelay(10); > - } > -} > - > -/* > - * Routine: setup_net_chip > - * Description: Setting up the configuration GPMC registers specific to the > - * Ethernet hardware. > - */ > -static void setup_net_chip(void) > -{ > - struct ctrl *ctrl_base = (struct ctrl *)OMAP34XX_CTRL_BASE; > - static const u32 gpmc_lan_config[] = { > - NET_LAN9221_GPMC_CONFIG1, > - NET_LAN9221_GPMC_CONFIG2, > - NET_LAN9221_GPMC_CONFIG3, > - NET_LAN9221_GPMC_CONFIG4, > - NET_LAN9221_GPMC_CONFIG5, > - NET_LAN9221_GPMC_CONFIG6, > - }; > - > - enable_gpmc_cs_config(gpmc_lan_config, &gpmc_cfg->cs[5], > - CONFIG_SMC911X_BASE, GPMC_SIZE_16M); > - > - /* Enable off mode for NWE in PADCONF_GPMC_NWE register */ > - writew(readw(&ctrl_base->gpmc_nwe) | 0x0E00, &ctrl_base->gpmc_nwe); > - /* Enable off mode for NOE in PADCONF_GPMC_NADV_ALE register */ > - writew(readw(&ctrl_base->gpmc_noe) | 0x0E00, &ctrl_base->gpmc_noe); > - /* Enable off mode for ALE in PADCONF_GPMC_NADV_ALE register */ > - writew(readw(&ctrl_base->gpmc_nadv_ale) | 0x0E00, > - &ctrl_base->gpmc_nadv_ale); > - > - reset_net_chip(64); > -} > - > -int board_eth_init(struct bd_info *bis) > -{ > -#ifdef CONFIG_SMC911X > - return smc911x_initialize(0, CONFIG_SMC911X_BASE); > -#else > - return 0; > -#endif > -} > -#else > -static inline void setup_net_chip(void) {} > -#endif > - > #ifdef CONFIG_OF_BOARD_SETUP > static int ft_enable_by_compatible(void *blob, char *compat, int enable) > { > @@ -234,8 +178,6 @@ int misc_init_r(void) > OMAP34XX_CTRL_WKUP_CTRL_GPIO_IO_PWRDNZ, > OMAP34XX_CTRL_WKUP_CTRL); > > - setup_net_chip(); > - > omap_die_id_display(); > > set_led(); > diff --git a/configs/igep00x0_defconfig b/configs/igep00x0_defconfig > index 17c97ac27f79..25eda11dd45e 100644 > --- a/configs/igep00x0_defconfig > +++ b/configs/igep00x0_defconfig > @@ -67,7 +67,7 @@ CONFIG_ENV_UBI_VOLUME="config" > CONFIG_ENV_UBI_VOLUME_REDUND="config_r" > CONFIG_SYS_RELOC_GD_ENV_ADDR=y > CONFIG_VERSION_VARIABLE=y > -CONFIG_NET_RANDOM_ETHADDR=y > +# CONFIG_NET is not set > CONFIG_SYS_I2C_LEGACY=y > CONFIG_SPL_SYS_I2C_LEGACY=y > CONFIG_MMC_OMAP_HS=y > @@ -81,9 +81,6 @@ CONFIG_SYS_NAND_PAGE_SIZE=0x800 > CONFIG_SYS_NAND_OOBSIZE=0x40 > CONFIG_SYS_NAND_BUSWIDTH_16BIT=y > CONFIG_MTD_UBI_FASTMAP=y > -CONFIG_SMC911X=y > -CONFIG_SMC911X_BASE=0x2C000000 > -CONFIG_SMC911X_32_BIT=y > CONFIG_CONS_INDEX=3 > CONFIG_SPI=y > CONFIG_DM_SPI=y > -- > 2.25.1 From: Ladislav Michl Date: Tue, 5 Apr 2022 15:47:45 +0200 Subject: [PATCH] ARM: igep00x0: convert to DM_ETH The GPMC bus hasn't been converted, so omap3-igep0020-u-boot.dtsi needs to provide the address of the ethernet controller. Signed-off-by: Ladislav Michl --- arch/arm/dts/omap3-igep0020-u-boot.dtsi | 12 ++++++++++++ board/isee/igep00x0/igep00x0.c | 12 +----------- configs/igep00x0_defconfig | 2 +- 3 files changed, 14 insertions(+), 12 deletions(-) diff --git a/arch/arm/dts/omap3-igep0020-u-boot.dtsi b/arch/arm/dts/omap3-igep0020-u-boot.dtsi index 41beaf0900..d418b6a79f 100644 --- a/arch/arm/dts/omap3-igep0020-u-boot.dtsi +++ b/arch/arm/dts/omap3-igep0020-u-boot.dtsi @@ -9,6 +9,18 @@ chosen { stdout-path = &uart3; }; + + ethernet@2c000000 { + compatible = "smsc,lan9221","smsc,lan9115"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0x2c000000 0xff>; + bank-width = <2>; + vddvario-supply = <&vddvario>; + vdd33a-supply = <&vdd33a>; + reg-io-width = <4>; + smsc,save-mac-address; + }; }; &uart1 { diff --git a/board/isee/igep00x0/igep00x0.c b/board/isee/igep00x0/igep00x0.c index 0932f62b9b..b48acf9d9b 100644 --- a/board/isee/igep00x0/igep00x0.c +++ b/board/isee/igep00x0/igep00x0.c @@ -12,7 +12,6 @@ #include #include #include -#include #include #include #include @@ -119,7 +118,7 @@ static void setup_net_chip(void) }; enable_gpmc_cs_config(gpmc_lan_config, &gpmc_cfg->cs[5], - CONFIG_SMC911X_BASE, GPMC_SIZE_16M); + 0x2C000000, GPMC_SIZE_16M); /* Enable off mode for NWE in PADCONF_GPMC_NWE register */ writew(readw(&ctrl_base->gpmc_nwe) | 0x0E00, &ctrl_base->gpmc_nwe); @@ -131,15 +130,6 @@ static void setup_net_chip(void) reset_net_chip(64); } - -int board_eth_init(struct bd_info *bis) -{ -#ifdef CONFIG_SMC911X - return smc911x_initialize(0, CONFIG_SMC911X_BASE); -#else - return 0; -#endif -} #else static inline void setup_net_chip(void) {} #endif diff --git a/configs/igep00x0_defconfig b/configs/igep00x0_defconfig index f0d6ac56b6..9f895113d9 100644 --- a/configs/igep00x0_defconfig +++ b/configs/igep00x0_defconfig @@ -70,8 +70,8 @@ CONFIG_SYS_NAND_PAGE_SIZE=0x800 CONFIG_SYS_NAND_OOBSIZE=0x40 CONFIG_SYS_NAND_BUSWIDTH_16BIT=y CONFIG_MTD_UBI_FASTMAP=y +CONFIG_DM_ETH=y CONFIG_SMC911X=y -CONFIG_SMC911X_BASE=0x2C000000 CONFIG_SMC911X_32_BIT=y CONFIG_CONS_INDEX=3 CONFIG_SPI=y -- 2.32.0