public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Leo Liang <ycliang@andestech.com>
To: Sean Anderson <seanga2@gmail.com>
Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
	Rick Chen <rick@andestech.com>, <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/3] cmd/sbi: format RustSBI version number
Date: Tue, 4 Oct 2022 07:11:03 +0000	[thread overview]
Message-ID: <Yzvchw5LeIM5w2sq@ubuntu01> (raw)
In-Reply-To: <b2ee5c05-ca02-3b43-25af-33c6992d5650@gmail.com>

Hi Sean,
On Tue, Oct 04, 2022 at 02:23:33AM -0400, Sean Anderson wrote:
> On 10/1/22 03:39, Heinrich Schuchardt wrote:
> > The SBI command can print out the version number of the SBI implementation.
> > Choose the correct output format for RustSBI.
> > 
> > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> > ---
> >   cmd/riscv/sbi.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/cmd/riscv/sbi.c b/cmd/riscv/sbi.c
> > index 522f502435..160d7c7b30 100644
> > --- a/cmd/riscv/sbi.c
> > +++ b/cmd/riscv/sbi.c
> > @@ -74,6 +74,7 @@ static int do_sbi(struct cmd_tbl *cmdtp, int flag, int argc,
> >   					       vers >> 16, vers & 0xffff);
> >   					break;
> >   				case 3: /* KVM */
> > ++				case 4: /* RustSBI */
> 
> Did your patch get mangled?

Thanks for the catch.
I will fix that extra '+' when merging the patches.

> 
> >   					printf("%ld.%ld.%ld",
> >   					       vers >> 16,
> >   					       (vers >> 8) & 0xff,
> 

Best regards,
Leo

  reply	other threads:[~2022-10-04  7:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-01  7:39 [PATCH 0/3] sbi/cmd: improve output formatting Heinrich Schuchardt
2022-10-01  7:39 ` [PATCH 1/3] cmd/sbi: format RustSBI version number Heinrich Schuchardt
     [not found]   ` <HK0PR03MB2994993437B0AEAE372695DAC15B9@HK0PR03MB2994.apcprd03.prod.outlook.com>
2022-10-03  1:00     ` Rick Chen
2022-10-04  6:23   ` Sean Anderson
2022-10-04  7:11     ` Leo Liang [this message]
2022-10-01  7:39 ` [PATCH 2/3] cmd/sbi: error message for failure to get spec version Heinrich Schuchardt
     [not found]   ` <HK0PR03MB2994A74252CD46C27E390C47C15B9@HK0PR03MB2994.apcprd03.prod.outlook.com>
2022-10-03  1:01     ` Rick Chen
2022-10-01  7:39 ` [PATCH 3/3] cmd/sbi: user friendly short texts Heinrich Schuchardt
     [not found]   ` <HK0PR03MB2994EBF201F5989155DE0036C15B9@HK0PR03MB2994.apcprd03.prod.outlook.com>
2022-10-03  1:02     ` Rick Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yzvchw5LeIM5w2sq@ubuntu01 \
    --to=ycliang@andestech.com \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=rick@andestech.com \
    --cc=seanga2@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox