From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB8BFC433FE for ; Tue, 4 Oct 2022 07:11:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 466EA84BDB; Tue, 4 Oct 2022 09:11:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id DDCF584B96; Tue, 4 Oct 2022 09:11:34 +0200 (CEST) Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 87B1B84B67 for ; Tue, 4 Oct 2022 09:11:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 2947BCpV042852; Tue, 4 Oct 2022 15:11:12 +0800 (+08) (envelope-from ycliang@andestech.com) Received: from ubuntu01 (10.0.12.75) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Tue, 4 Oct 2022 15:11:12 +0800 Date: Tue, 4 Oct 2022 07:11:03 +0000 From: Leo Liang To: Sean Anderson CC: Heinrich Schuchardt , Rick Chen , Subject: Re: [PATCH 1/3] cmd/sbi: format RustSBI version number Message-ID: References: <20221001073940.10018-1-heinrich.schuchardt@canonical.com> <20221001073940.10018-2-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) X-Originating-IP: [10.0.12.75] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 2947BCpV042852 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Sean, On Tue, Oct 04, 2022 at 02:23:33AM -0400, Sean Anderson wrote: > On 10/1/22 03:39, Heinrich Schuchardt wrote: > > The SBI command can print out the version number of the SBI implementation. > > Choose the correct output format for RustSBI. > > > > Signed-off-by: Heinrich Schuchardt > > --- > > cmd/riscv/sbi.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/cmd/riscv/sbi.c b/cmd/riscv/sbi.c > > index 522f502435..160d7c7b30 100644 > > --- a/cmd/riscv/sbi.c > > +++ b/cmd/riscv/sbi.c > > @@ -74,6 +74,7 @@ static int do_sbi(struct cmd_tbl *cmdtp, int flag, int argc, > > vers >> 16, vers & 0xffff); > > break; > > case 3: /* KVM */ > > ++ case 4: /* RustSBI */ > > Did your patch get mangled? Thanks for the catch. I will fix that extra '+' when merging the patches. > > > printf("%ld.%ld.%ld", > > vers >> 16, > > (vers >> 8) & 0xff, > Best regards, Leo