From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6ECE8C36002 for ; Mon, 24 Mar 2025 12:30:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A0CFF817EC; Mon, 24 Mar 2025 13:30:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=dolcini.it header.i=@dolcini.it header.b="pWQH+N8k"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5D4158197D; Mon, 24 Mar 2025 13:30:53 +0100 (CET) Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 021178122F for ; Mon, 24 Mar 2025 13:30:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=francesco@dolcini.it Received: from gaggiata.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 2A7431F9C8; Mon, 24 Mar 2025 13:30:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1742819450; bh=dUcjK0KIEORo7+XRGItFsC9L+06IWjimfneBVlYyDLM=; h=Received:From:To:Subject; b=pWQH+N8kxStq+HX75pQKSI2Q23reGPMmKZNxFdUxsv1S66xOkegKjIoYxYdzfHNU9 pe1tv4qv1vIZPxeG7gGjvY8aeCh0e/dT1Ktv+yflBWYO9m9zhGmycpo4f7vEUTIXR4 KLCE1TZNoiLDfjXaWQTXk5UvyvyW7n83tZwABuT8zm3aocLn5rzO9W9ngUTrvIqtp9 kJ50CXjC7w9kH0fyv3Ghipg3ASPwSx5ss6SzZTHtRVpcR7NiBnlTCfFVWLgDaF6n+E QERDTB0JUT0orTmKSPuojPDi7MVsNVj9k4aUJF6IiHmGFC2QxKZynsPGk+/2SmkPiX stqu25KD3iemw== Received: by gaggiata.pivistrello.it (Postfix, from userid 1000) id C7D757F9C9; Mon, 24 Mar 2025 13:30:49 +0100 (CET) Date: Mon, 24 Mar 2025 13:30:49 +0100 From: Francesco Dolcini To: Mattijs Korpershoek Cc: Francesco Dolcini , Marek Vasut , u-boot@lists.denx.de, Alexander Sverdlin , Felipe Balbi , Lukasz Majewski , Neil Armstrong , Thinh Nguyen , Tom Rini Subject: Re: [PATCH] usb: dwc3: gadget: Fix match_ep callback for NXP UUU tool Message-ID: References: <20250319220805.219001-1-marex@denx.de> <87a59gdofd.fsf@baylibre.com> <20250324080315.GA6932@francesco-nb> <87pli6esx0.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87pli6esx0.fsf@baylibre.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Mon, Mar 24, 2025 at 09:26:03AM +0100, Mattijs Korpershoek wrote: > Hi Francesco, > > On lun., mars 24, 2025 at 09:03, Francesco Dolcini wrote: > > > Hello Mattijs, Marek > > > > On Thu, Mar 20, 2025 at 10:47:02AM +0100, Mattijs Korpershoek wrote: > >> On mer., mars 19, 2025 at 23:07, Marek Vasut wrote: > >> > >> > The UUU tool excepts the interrupt-in endpoint to be ep1in, otherwise > >> > it crashes. This is a result of the previous hard-coded EP setup in > >> > drivers/usb/gadget/epautoconf.c which did special-case EP allocation > >> > for SPL builds, and which was since converted to this callback, but > >> > without the special-case EP allocation in SPL part. > >> > > >> > This reinstates the SPL part in an isolated manner, only for NXP iMX > >> > SoCs, only for SPL builds, and only for the ep1in interrupt-in endpoint. > > > > UUU can (and in our case is) used also on non-NXP i.MX platforms. > > What should we do? > > Do reproduce the problem (UUU tool crashes) on those platforms with > recent U-Boot versions (v2024.10+) ? Not tested, my comment is purely based on the code and the commit message. Older U-Boot versions (up to v2024.04, included) are working fine, with UUU used with TI K3 SoCs (AM69, AM62, AM62P). Francesco