From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62765C6FD1F for ; Sat, 11 Mar 2023 10:31:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 576CF85757; Sat, 11 Mar 2023 11:31:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=grimler.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=grimler.se header.i=@grimler.se header.b="DrHBxETD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B50CD85764; Sat, 11 Mar 2023 11:31:50 +0100 (CET) Received: from out-41.mta1.migadu.com (out-41.mta1.migadu.com [IPv6:2001:41d0:203:375::29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 84BDE85723 for ; Sat, 11 Mar 2023 11:31:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=grimler.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=henrik@grimler.se Date: Sat, 11 Mar 2023 11:31:43 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=grimler.se; s=key1; t=1678530706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AbKjtK04mkHxBl04NpPbm76DWNERQa5ncZasI7OtB78=; b=DrHBxETDckHq8smNFoCtEBRiYcU45T0c7VtWspWt9P77c+c7HMjxBNwHhUq0SoXF1eFyi+ DFhYXKo24ffrOmhcVfyKX9EdXLjUjO7bbiwTHis9hZAVBtUcIuaMHEHM9PpTZiovpMTA1N 0+lMgbKVV6nwc5yUT9fNzzEASGdOl9Y= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Henrik Grimler To: Jaehoon Chung Cc: joost@diskos.nl, peng.fan@nxp.com, andy.wu@sony.com, sjg@chromium.org, u-boot@lists.denx.de, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH 1/2] Revert "mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B" Message-ID: References: <20230208190421.62661-1-henrik@grimler.se> <20230208190421.62661-2-henrik@grimler.se> <000901d93ce2$b28c12a0$17a437e0$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000901d93ce2$b28c12a0$17a437e0$@samsung.com> X-Migadu-Flow: FLOW_OUT X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Jaehoon, On Fri, Feb 10, 2023 at 09:00:33AM +0900, Jaehoon Chung wrote: > Hi, > > > -----Original Message----- > > From: U-Boot On Behalf Of Henrik Grimler > > Sent: Thursday, February 9, 2023 4:04 AM > > To: joost@diskos.nl; jh80.chung@gmail.com; andy.wu@sony.com; sjg@chromium.org; > > m.szyprowski@samsung.com; u-boot@lists.denx.de; ~postmarketos/upstreaming@lists.sr.ht > > Cc: Henrik Grimler > > Subject: [PATCH 1/2] Revert "mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B" > > > > This reverts commit a034ec06ff1d558bbe11d5ee05edbb4de3ee2215. > > > > Commit 4a3ea75de4c5 ("Revert "mmc: sdhci: set to INT_DATA_END when > > there are data"") reverted the alternative fix that was added for > > Exynos 4 devices, causing an error when trying to boot from an sdcard: > > > > <...> > > Loading Environment from MMC... sdhci_send_command: Timeout for status update! > > mmc fail to send stop cmd > > <...> > > Thanks for sharing issue. > > I will check this on Exynos Board. Frankly, I hope not to re-add QUIRK. > Because it was verified that it was working fine without SDHCI_QUIKR_BROKEN_RIB. Just wondering if you have had an opportunity to test this on any of your devices? You can find v2 here, though this patch had no changes: https://lists.denx.de/pipermail/u-boot/2023-February/508928.html > Best Regards, > Jaehoon Chung Best regards, Henrik Grimler > > > > Re-add the quirk to allow booting from sdcards again. > > > > Signed-off-by: Henrik Grimler > > --- > > drivers/mmc/s5p_sdhci.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c > > index dee84263c3fd..3b74feae68c7 100644 > > --- a/drivers/mmc/s5p_sdhci.c > > +++ b/drivers/mmc/s5p_sdhci.c > > @@ -90,7 +90,7 @@ static int s5p_sdhci_core_init(struct sdhci_host *host) > > host->name = S5P_NAME; > > > > host->quirks = SDHCI_QUIRK_NO_HISPD_BIT | SDHCI_QUIRK_BROKEN_VOLTAGE | > > - SDHCI_QUIRK_32BIT_DMA_ADDR | > > + SDHCI_QUIRK_BROKEN_R1B | SDHCI_QUIRK_32BIT_DMA_ADDR | > > SDHCI_QUIRK_WAIT_SEND_CMD | SDHCI_QUIRK_USE_WIDE8; > > host->max_clk = 52000000; > > host->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195; > > -- > > 2.30.2 > >