From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB7AAC6FD1D for ; Wed, 15 Mar 2023 09:28:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 00912861BD; Wed, 15 Mar 2023 10:28:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="oTLGQCS1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 843E4861C1; Wed, 15 Mar 2023 10:28:11 +0100 (CET) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 07BD385D8E for ; Wed, 15 Mar 2023 10:28:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ed1-x536.google.com with SMTP id fd5so38958228edb.7 for ; Wed, 15 Mar 2023 02:28:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678872487; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=H0Q+y+/jy3TqpVgWRNhw6NBYSPQkRB1nNTX5ZIWhSmA=; b=oTLGQCS1fvyOnRjTf4MpjgkAsbJi8RJWqDCv9wZlVWt0kD6oyLhIAVrCoFOeuVg7ht kLgZL4IoSZtIdi4q2bKMCSXx+mIuhhyyCd/q+hXSEkMoQH9PAphzrNbXhlPXGU2s9vRE TKgb9XC7YWLbrCENGHxyfb2SZjlKzjn1I8ekmX4d2Se3CI28M4Gw9V3jc9lZ/2doiYH0 oyw4RpJxn5iuXEwCia0Qqqt5Wk1aDGBOyQt/F3AH4RvlzgrtmAsnOtp06qh7LYW7eEd3 X/gWVHcspOeILS8Lsbx4lHJtkahUjjNS+IqxcxiZNFs8UV61D/UjRmMDye6U1cEZZz5p 0ddg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678872487; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H0Q+y+/jy3TqpVgWRNhw6NBYSPQkRB1nNTX5ZIWhSmA=; b=LCKt83jY37VIj4aX2gA40ra4b300VsTI7Q/5RA6VBfdrQCjUBfOKVZYuQLjMJ/d2pT PX0WE1CKBkBiDYVlCVNk0H5YohpLRPYj1Yk9Q9Dzs7zMA+TTdGcbujQFPIEDt0NXWyKj PCZlTWn6olzJCrZTF5X6nk7qjNaxT4K5dhspLP/8fW0TQUcIxZWzfqjdixAbLSlZiouM gJRvxTwylfG2xiWD3t1qZkgPiKJerlknvAMyBnopfLGWVWKtzDguBExDw0hr9fdxfLCO 7zE+di60/vcV5e0rmH87df/kv+Dagj84xCwjxbQaKNr/8q+/fg0sG3Yn86c7IXnAdNIx P21A== X-Gm-Message-State: AO0yUKUp6s+s8jkiMmNlM9RCrG9ButXtvK2NQKSGWoAqESzMH9xrr6xM wvcABQL/I7YtokO1VGvLczjA7Q== X-Google-Smtp-Source: AK7set+tPVOJ9FkMEk4Ozv6eh54vpmA7J1awem5avXbhOFpefJaH+7lxQZEfzQkQWF9LDtChLCeV6Q== X-Received: by 2002:aa7:c054:0:b0:4ac:d90e:92b with SMTP id k20-20020aa7c054000000b004acd90e092bmr1707160edo.10.1678872487529; Wed, 15 Mar 2023 02:28:07 -0700 (PDT) Received: from hera (ppp176092130041.access.hol.gr. [176.92.130.41]) by smtp.gmail.com with ESMTPSA id w23-20020a50d797000000b004fadc041e13sm2090485edi.42.2023.03.15.02.28.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 02:28:07 -0700 (PDT) Date: Wed, 15 Mar 2023 11:28:04 +0200 From: Ilias Apalodimas To: jassisinghbrar@gmail.com Cc: u-boot@lists.denx.de, sughosh.ganu@linaro.org, etienne.carriere@linaro.org, trini@konsulko.com, sjg@chromium.org, xypron.glpk@gmx.de, patrick.delaunay@foss.st.com, patrice.chotard@foss.st.com, Jassi Brar Subject: Re: [PATCH v6 7/7] test: dm: fwu: fix for the updated api Message-ID: References: <20230306231747.1888513-1-jassisinghbrar@gmail.com> <20230306231858.1888643-1-jassisinghbrar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230306231858.1888643-1-jassisinghbrar@gmail.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Mon, Mar 06, 2023 at 05:18:58PM -0600, jassisinghbrar@gmail.com wrote: > From: Jassi Brar > > fwu_get_mdata() no more requires 'dev' argument and > fwu_check_mdata_validity() has been rendered useless and dropped. > Fix the test cases to work with aforementioned changes. > > Signed-off-by: Jassi Brar > --- > test/dm/fwu_mdata.c | 22 +++------------------- > 1 file changed, 3 insertions(+), 19 deletions(-) > > diff --git a/test/dm/fwu_mdata.c b/test/dm/fwu_mdata.c > index b179a65c15..8b5c83ef4e 100644 > --- a/test/dm/fwu_mdata.c > +++ b/test/dm/fwu_mdata.c > @@ -98,7 +98,7 @@ static int dm_test_fwu_mdata_read(struct unit_test_state *uts) > ut_assertok(populate_mmc_disk_image(uts)); > ut_assertok(write_mmc_blk_device(uts)); > > - ut_assertok(fwu_get_mdata(dev, &mdata)); > + ut_assertok(fwu_get_mdata(&mdata)); > > ut_asserteq(mdata.version, 0x1); > > @@ -118,30 +118,14 @@ static int dm_test_fwu_mdata_write(struct unit_test_state *uts) > > ut_assertok(uclass_first_device_err(UCLASS_FWU_MDATA, &dev)); > > - ut_assertok(fwu_get_mdata(dev, &mdata)); > + ut_assertok(fwu_get_mdata(&mdata)); > > active_idx = (mdata.active_index + 1) % CONFIG_FWU_NUM_BANKS; > ut_assertok(fwu_set_active_index(active_idx)); > > - ut_assertok(fwu_get_mdata(dev, &mdata)); > + ut_assertok(fwu_get_mdata(&mdata)); > ut_asserteq(mdata.active_index, active_idx); > > return 0; > } > DM_TEST(dm_test_fwu_mdata_write, UT_TESTF_SCAN_FDT); > - > -static int dm_test_fwu_mdata_check(struct unit_test_state *uts) > -{ > - struct udevice *dev; > - > - ut_assertok(setup_blk_device(uts)); > - ut_assertok(populate_mmc_disk_image(uts)); > - ut_assertok(write_mmc_blk_device(uts)); > - > - ut_assertok(uclass_first_device_err(UCLASS_FWU_MDATA, &dev)); > - > - ut_assertok(fwu_check_mdata_validity()); > - > - return 0; > -} > -DM_TEST(dm_test_fwu_mdata_check, UT_TESTF_SCAN_FDT); > -- > 2.34.1 > Acked-by: Ilias Apalodimas