From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9E67C6FD1D for ; Mon, 20 Mar 2023 07:28:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0A57185A48; Mon, 20 Mar 2023 08:28:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Z1RQHN5+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DB39885A57; Mon, 20 Mar 2023 08:28:23 +0100 (CET) Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2A02784CFA for ; Mon, 20 Mar 2023 08:28:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ed1-x532.google.com with SMTP id o12so42820833edb.9 for ; Mon, 20 Mar 2023 00:28:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679297300; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lbjiB1fHiduT0BWmbrN5amo6oiVTNgJ3ohws1lvtV+E=; b=Z1RQHN5+m/R1gZOQskjOAbuXiJtrEVSme3sXxgJ6kcXkhRe4CKOxBkcx5CJXmEV54p qhgr02nKQU2b9+r+5/xSwyQb7cmDOt5z7Ef8aAE04XTUa9c3CGkESwYgazBLhotcc7KJ m9XXnjEYWDsZGur8wtxWo5Sc/PKQYNOQU/k8C70iGhlGHKGi8zirDYSXMb13mr5Mp65N GRpOp+1fSPK3/GqijWlHy91DUwVwyMfmV9HHW7tmOyJYsxH7anfe01YUxbMrelw+NI1s 4fm3rYKI4w/JKiOXkdwxa7H8v41klCuI9wpDuClS3TfhBEaJXhLuzo5SffHkQQ0Y/pj6 Y8dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679297300; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lbjiB1fHiduT0BWmbrN5amo6oiVTNgJ3ohws1lvtV+E=; b=dJZmhhITwJ6wel8aJDFCWPP3XxtUI0EDhNTvyWB1WnsH9jRPn10QRTeAvW5tx4T3eV E1A8DgwFjLSMYr2Skq15ObZLYpBvFcfIL7klLUEjGc+aKcITAChBscYu59MFk9uwaMLr DLfva/UcUo/pTeFW0O68Eik0OCMKfbxVot+13L0GMnrkmRDqjzNcQ6cOq2xr/D74bfKL 0m3DlxxbGqFofqOCgx616yFGkn7S2wFQ5Rgrgqu3iQkg4BqtrI85j56acYpncqPRjDwT 6SC3VSn+WIlDv4Tl5wIufeWH9hxLSJHm7F7ez5JRdpgqotQI/4JyC9qLfVcBeNUjSmik uAVQ== X-Gm-Message-State: AO0yUKVHSMiw58qMbMw5xy/DVBClH4sA9LEJYSS7FN6Gytw4zdQJPNtp WLp2SAFw0t1MXlgsdCW1PYS/xLEygFvThC81N/M= X-Google-Smtp-Source: AK7set9GqNoSDu1oP5DjhjkU8kUYKWeSrDldf+qxFH26Uy24y+bPpHUxLHm3mUAMR/BoRtRqnknllA== X-Received: by 2002:a17:906:b28e:b0:920:254c:1e2d with SMTP id q14-20020a170906b28e00b00920254c1e2dmr8374514ejz.39.1679297300553; Mon, 20 Mar 2023 00:28:20 -0700 (PDT) Received: from hera (ppp176092130041.access.hol.gr. [176.92.130.41]) by smtp.gmail.com with ESMTPSA id p9-20020a1709060e8900b0093313f4fc3csm2805300ejf.70.2023.03.20.00.28.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 00:28:20 -0700 (PDT) Date: Mon, 20 Mar 2023 09:28:18 +0200 From: Ilias Apalodimas To: Heinrich Schuchardt Cc: u-boot@lists.denx.de Subject: Re: [PATCH 1/1] efi_loader: move struct efi_device_path to efi.h Message-ID: References: <20230319075933.88229-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230319075933.88229-1-heinrich.schuchardt@canonical.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich, On Sun, Mar 19, 2023 at 08:59:33AM +0100, Heinrich Schuchardt wrote: > Avoid forward declaration of struct efi_device_path. > > Signed-off-by: Heinrich Schuchardt > --- > include/efi.h | 13 ++++++++++++- > include/efi_api.h | 6 ------ > 2 files changed, 12 insertions(+), 7 deletions(-) > > diff --git a/include/efi.h b/include/efi.h > index c3087d3da2..2f312da3cb 100644 > --- a/include/efi.h > +++ b/include/efi.h > @@ -52,7 +52,18 @@ > #define EFI32_LOADER_SIGNATURE "EL32" > #define EFI64_LOADER_SIGNATURE "EL64" > > -struct efi_device_path; > +/** > + * struct efi_device_path - device path protocol > + * > + * @type: device path type > + * @sub_type: device path sub-type > + * @length: length of the device path node including the header > + */ > +struct efi_device_path { > + u8 type; > + u8 sub_type; > + u16 length; > +} __packed; > > /* > * The EFI spec defines the EFI_GUID as > diff --git a/include/efi_api.h b/include/efi_api.h > index 2d18d25a71..2969884280 100644 > --- a/include/efi_api.h > +++ b/include/efi_api.h > @@ -557,12 +557,6 @@ struct efi_loaded_image { > # define DEVICE_PATH_SUB_TYPE_INSTANCE_END 0x01 > # define DEVICE_PATH_SUB_TYPE_END 0xff > > -struct efi_device_path { > - u8 type; > - u8 sub_type; > - u16 length; > -} __packed; > - > struct efi_mac_addr { > u8 addr[32]; > } __packed; > -- > 2.39.2 > Reviewed-by: Ilias Apalodimas