From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0F58C6FD1D for ; Mon, 20 Mar 2023 07:40:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F1FC885AEC; Mon, 20 Mar 2023 08:39:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="W0qCT4UM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E924285A83; Mon, 20 Mar 2023 08:39:54 +0100 (CET) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 664C885A48 for ; Mon, 20 Mar 2023 08:39:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ed1-x535.google.com with SMTP id o12so42918665edb.9 for ; Mon, 20 Mar 2023 00:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679297991; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2soH2YMOUu8HcaAnpU8qw5YbIqjP8gYNBFV+9H3bTjo=; b=W0qCT4UMaysU8ssF0Yp9T7R1sJI/F8vyZzAy13vIl0FKBhinUotH1RNyDBitCxvVCT t3MVZLR/POcuU+4kqR2JV/Zj3UfLq9c7Fqkv81Bkkf+KitiO80uyM+DAxmsIiMW7F40U omrbmvuaCeVbQt9uMBN+SHTiYE7ZQspFJd1uIfHdh9prQMLeUPyDurQi/3JxUAnHHcm0 gYNCjYFfzp12MXjWBzw1do2BgdslYQELoOQTeECKtifyxVVFCu3laSerDy2hwGKkUaMy FezBp77xVqXWJLBdH8m6bq0H0hwZehe4jDoArL3hI3Ig5Q1cGmerlaFHjlwwRIoFSWRE elPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679297991; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2soH2YMOUu8HcaAnpU8qw5YbIqjP8gYNBFV+9H3bTjo=; b=v4U93lal/JsBFG5E8pmkYNxvPy9AMaaWUZN2X8IKj04iQy/MjJLTDYbFqU/ktjTm4M 2qxA3Cpb58ilGYGVNc8vSYYDazwM/HybCJy91UHa04fYRRepHb9xa6ZI58ULh8VSPb8k FGyGsySqOPExeCLa0EDAzbyxQJwHpX43UQv5aom0JCJ56Hoq7Qf6YaOKFb3vUCU9gGph Cvl8b3eefJrjQqS5MRnyde2XjWFavXy8fvrziZ6tSIT/wQldyHL57MmXzk6YW98qdLIW kiBsRpw9EDkcBmy+pqRTk0y83uLPIMZIEyy/degUPIkHXQnrJAAJz+v/S8XMrFgmEAkf kSJw== X-Gm-Message-State: AO0yUKWgopt3BMgoIs5XzOMKqyiJdqTUddafGCfK5BXYgtgbH2o057Vv BJaNVYPf7PdT4SjsfyLldKkz5Q== X-Google-Smtp-Source: AK7set/zLiSAgx1miFHxEFdiYX6uemycDgVbgdKSdZoBoKBFepLnrPQgCCRJqm6hYzFRgtqqrCVuoA== X-Received: by 2002:a17:906:6d8d:b0:8b1:76ca:f228 with SMTP id h13-20020a1709066d8d00b008b176caf228mr8612119ejt.39.1679297991003; Mon, 20 Mar 2023 00:39:51 -0700 (PDT) Received: from hera (ppp176092130041.access.hol.gr. [176.92.130.41]) by smtp.gmail.com with ESMTPSA id p25-20020a17090653d900b009333b82f061sm2366803ejo.80.2023.03.20.00.39.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 00:39:50 -0700 (PDT) Date: Mon, 20 Mar 2023 09:39:48 +0200 From: Ilias Apalodimas To: Heinrich Schuchardt Cc: u-boot@lists.denx.de Subject: Re: [PATCH 1/2] efi_loader: support for Ctrl() device path node Message-ID: References: <20230319151809.185099-1-heinrich.schuchardt@canonical.com> <20230319151809.185099-2-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230319151809.185099-2-heinrich.schuchardt@canonical.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Sun, Mar 19, 2023 at 04:18:08PM +0100, Heinrich Schuchardt wrote: > * Add the definitions for Ctrl() device path nodes. > * Implement Ctrl() nodes in the device path to text protocol. > > Signed-off-by: Heinrich Schuchardt > --- > include/efi_api.h | 6 ++++++ > lib/efi_loader/efi_device_path_to_text.c | 7 +++++++ > 2 files changed, 13 insertions(+) > > diff --git a/include/efi_api.h b/include/efi_api.h > index 2d18d25a71..c57868abbd 100644 > --- a/include/efi_api.h > +++ b/include/efi_api.h > @@ -570,6 +570,7 @@ struct efi_mac_addr { > #define DEVICE_PATH_TYPE_HARDWARE_DEVICE 0x01 > # define DEVICE_PATH_SUB_TYPE_MEMORY 0x03 > # define DEVICE_PATH_SUB_TYPE_VENDOR 0x04 > +# define DEVICE_PATH_SUB_TYPE_CONTROLLER 0x05 > > struct efi_device_path_memory { > struct efi_device_path dp; > @@ -584,6 +585,11 @@ struct efi_device_path_vendor { > u8 vendor_data[]; > } __packed; > > +struct efi_device_path_controller { > + struct efi_device_path dp; > + u32 controller_number; > +} __packed; > + > #define DEVICE_PATH_TYPE_ACPI_DEVICE 0x02 > # define DEVICE_PATH_SUB_TYPE_ACPI_DEVICE 0x01 > > diff --git a/lib/efi_loader/efi_device_path_to_text.c b/lib/efi_loader/efi_device_path_to_text.c > index 9062058ac2..9c0b39311a 100644 > --- a/lib/efi_loader/efi_device_path_to_text.c > +++ b/lib/efi_loader/efi_device_path_to_text.c > @@ -77,6 +77,13 @@ static char *dp_hardware(char *s, struct efi_device_path *dp) > s += sprintf(s, ")"); > break; > } > + case DEVICE_PATH_SUB_TYPE_CONTROLLER: { > + struct efi_device_path_controller *cdp = > + (struct efi_device_path_controller *)dp; > + > + s += sprintf(s, "Ctrl(0x%0x)", cdp->controller_number); > + break; > + } > default: > s = dp_unknown(s, dp); > break; > -- > 2.39.2 > Reviewed-by: Ilias Apalodimas