From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57351C7619A for ; Wed, 5 Apr 2023 13:09:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BBADD85FA5; Wed, 5 Apr 2023 15:09:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="j6MmPBf6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0516385F93; Wed, 5 Apr 2023 15:09:17 +0200 (CEST) Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E769285F86 for ; Wed, 5 Apr 2023 15:09:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-4fa51496035so448082a12.0 for ; Wed, 05 Apr 2023 06:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680700152; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Xmdg+iNvdFC7k4v34bcNsWUD9Pay6VTvEDZ26g1d9Lc=; b=j6MmPBf6LCQhFM1EKNzFDeYc0Lfl+Q2UOkEemt0Qs0uHHFMeuzV4NidWRVKGRNJMdU BOoVag7GR75WrcuFshSYUzj91csHzS+45m7gMXQF79TDz7mVibgh+BfmyO/DqLV5ucVH 1PS4oyavCoiqGBrSsKbpUQDXDHdrJNHH33FXlYKo3CfGLsHLNyOMX/Wreqlpi9n6KrbP e1maEjGgafil4W1nn9PdAitjawGez99+M9nHIn9nLVffADJLQ9TTEvcgjJ5pAyu5dFWU lUAL/BdBGCxVxobgq7BFRBPrINd23EDFNACjDibrZ+V92G14FkIJ/j9yx0Qzk7sP+aW3 H5MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680700152; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xmdg+iNvdFC7k4v34bcNsWUD9Pay6VTvEDZ26g1d9Lc=; b=QJAGJeOnqqd4ypQtkSKRDo3PtmhuaYm5mWFGqLUU0jmyE/7vE/vFO5ZMk9m7bgznXK p/EjRat3bgBP+G7hultqEYGTl0AixxLQmfpMaSasHFwKHiZbNWhI/xv9DAWfsuGaMnpr kcD7NGfJWRj+Fl6Uzaq6djMkDRY6cIP4JtvxsuKx/gwb/oATQYUnhyIcYUGlSC+hI/V7 CnqOXNQqb0Jl0rxQesgsvsyzJdA7MAiL3m+6yY6Xk5m30cFmgPzD5S7yYaQc54tYpQL6 QPhRnHzea7wQmAULMEH5I/S6AJve46mvDiZmRnP/ToJEc73l01DlFddFh2Iau0Fnhapa YYfw== X-Gm-Message-State: AAQBX9cnSlR9NfI0WX2jraMQrby/ueg4LXId1b+kVg7vJ/fcww/Fii8a C4OmkavmnHCRcQaY7RlLDmh4nJ9xpbtCr+h4CDo= X-Google-Smtp-Source: AKy350YtibKTNTC9jl2jdXVbN9WxY8Cnw+uibIYBpZFJDSStMX9Fd0fEbA1u0vzDUEoWDIQPECZd9w== X-Received: by 2002:aa7:cb47:0:b0:4fb:7ccf:3b33 with SMTP id w7-20020aa7cb47000000b004fb7ccf3b33mr2147692edt.31.1680700152503; Wed, 05 Apr 2023 06:09:12 -0700 (PDT) Received: from hades (ppp176092130041.access.hol.gr. [176.92.130.41]) by smtp.gmail.com with ESMTPSA id e14-20020a50d4ce000000b004fadc041e13sm384588edj.42.2023.04.05.06.09.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 06:09:12 -0700 (PDT) Date: Wed, 5 Apr 2023 16:09:10 +0300 From: Ilias Apalodimas To: Bin Meng Cc: Heinrich Schuchardt , u-boot@lists.denx.de Subject: Re: [PATCH 2/5] efi: selftest: Make load_file() and load_file2() static Message-ID: References: <20230405121519.778846-1-bmeng@tinylab.org> <20230405121519.778846-2-bmeng@tinylab.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230405121519.778846-2-bmeng@tinylab.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Wed, Apr 05, 2023 at 08:15:16PM +0800, Bin Meng wrote: > load_file() and load_file2() are only referenced in > efi_selftest_load_file.c > > Signed-off-by: Bin Meng > --- > > lib/efi_selftest/efi_selftest_load_file.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/lib/efi_selftest/efi_selftest_load_file.c b/lib/efi_selftest/efi_selftest_load_file.c > index 8784a76172..14df761172 100644 > --- a/lib/efi_selftest/efi_selftest_load_file.c > +++ b/lib/efi_selftest/efi_selftest_load_file.c > @@ -206,11 +206,11 @@ static efi_status_t decompress(u8 **image) > * @buffer_size: (required) buffer size > * @buffer: buffer to which the file is to be loaded > */ > -efi_status_t EFIAPI load_file(struct efi_load_file_protocol *this, > - struct efi_device_path *file_path, > - bool boot_policy, > - efi_uintn_t *buffer_size, > - void *buffer) > +static efi_status_t EFIAPI load_file(struct efi_load_file_protocol *this, > + struct efi_device_path *file_path, > + bool boot_policy, > + efi_uintn_t *buffer_size, > + void *buffer) > { > ++load_file_call_count; > if (memcmp(file_path, dp_lf_file_remainder, > @@ -243,11 +243,11 @@ efi_status_t EFIAPI load_file(struct efi_load_file_protocol *this, > * @buffer_size: (required) buffer size > * @buffer: buffer to which the file is to be loaded > */ > -efi_status_t EFIAPI load_file2(struct efi_load_file_protocol *this, > - struct efi_device_path *file_path, > - bool boot_policy, > - efi_uintn_t *buffer_size, > - void *buffer) > +static efi_status_t EFIAPI load_file2(struct efi_load_file_protocol *this, > + struct efi_device_path *file_path, > + bool boot_policy, > + efi_uintn_t *buffer_size, > + void *buffer) > { > ++load_file2_call_count; > if (memcmp(file_path, dp_lf2_file_remainder, > -- > 2.34.1 > Reviewed-by: Ilias Apalodimas