From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6A22C76188 for ; Wed, 5 Apr 2023 13:09:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EFEB185F94; Wed, 5 Apr 2023 15:09:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="dIZkJIv6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BFA0085F93; Wed, 5 Apr 2023 15:09:26 +0200 (CEST) Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6444E85FAD for ; Wed, 5 Apr 2023 15:09:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ed1-x52d.google.com with SMTP id w9so140960384edc.3 for ; Wed, 05 Apr 2023 06:09:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680700163; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Rt2pVYiQGUvPd3HZvGM40XH8z3LLs7i2s81htMQNaHU=; b=dIZkJIv6RZFaxJlIGCxE2HyYWOshLuYktoUsWSjWBz3HUesdYpLSN4PM8QT7eVC2++ MrGFE6jsjly5fVLhzpcJVWAeGIIGWAtzV+WJF7b7KljuSghB0wxpWpbHSiVfjhX+JRcY OgpIkJiwHNmwvow1oK4B8uQ3V6ZKAtAgn+ndbwiPYzcrQOmfumIO0yqn6TpCZ+XcnNZ6 E/3qb3ZgFqGJCBNzLZ36nfqkMK2OPKutVJafVHFPL4ZyYffuPjejS9E9aIBrZ/FbKqMo Mzdfxk3o4LgJMJcn3i32iusy9A8VvYNTUVde9l+f1DO/NufbQMFDU01Wo3lnXmonLxro tdKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680700163; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Rt2pVYiQGUvPd3HZvGM40XH8z3LLs7i2s81htMQNaHU=; b=lc+zXz5VdqcJJOZsJi3zaDVv6aiYz6ZtilcN+aD2J3+UQfSRa0qwnvz49gjvIG0SVQ qCHhlGnz/X42Q3miyH+yXwXcHdrvMWsACf+MMrEUr6fzXl4UGPR373x6Epa4HcePORdD 50F7pWzeQ6Lr5BCMIb8weICDQlHvLySujsRe3ItNAsI0zj5LR47VTzkFV0Y+u+oET9Vo VRYrRaKaBU54qDuSiIg5K8QtkIgeliVx3bm3yFaW99XgUAk39aceY0dIVgCJKaAYI95j nGAXjhkSFrRiIRBZDz6zICrEIa6eCsJTgq3tjv4ns77FMsPSPFyhl6evTUxDZy6AwdTc sFRA== X-Gm-Message-State: AAQBX9ekQWjvpH1nqlcbUaHzv6tQvtPUlzD8Yku2H2M3N+jQZoqLLjKs ByXWulMKnfKp7ta0dLTJSCc/Xw== X-Google-Smtp-Source: AKy350bQqM68xL5W5ksWrKRTQ6f4CN+ye96c+kJjI8P5lrn/Vjo70JalKJH5pr7fu26LjquuXSeeEQ== X-Received: by 2002:a17:906:3454:b0:933:89a1:57e6 with SMTP id d20-20020a170906345400b0093389a157e6mr2866862ejb.26.1680700162921; Wed, 05 Apr 2023 06:09:22 -0700 (PDT) Received: from hades (ppp176092130041.access.hol.gr. [176.92.130.41]) by smtp.gmail.com with ESMTPSA id m24-20020a17090679d800b00946c1068b14sm7235293ejo.120.2023.04.05.06.09.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 06:09:22 -0700 (PDT) Date: Wed, 5 Apr 2023 16:09:20 +0300 From: Ilias Apalodimas To: Bin Meng Cc: Heinrich Schuchardt , u-boot@lists.denx.de Subject: Re: [PATCH 3/5] efi: loader: Make efi_event_queue and efi_register_notify_events static Message-ID: References: <20230405121519.778846-1-bmeng@tinylab.org> <20230405121519.778846-3-bmeng@tinylab.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230405121519.778846-3-bmeng@tinylab.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Wed, Apr 05, 2023 at 08:15:17PM +0800, Bin Meng wrote: > efi_event_queue and efi_register_notify_events are only referenced > in efi_boottime.c > > Signed-off-by: Bin Meng > --- > > include/efi_loader.h | 3 --- > lib/efi_loader/efi_boottime.c | 4 ++-- > 2 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/include/efi_loader.h b/include/efi_loader.h > index 1542b4b625..0a2083c39a 100644 > --- a/include/efi_loader.h > +++ b/include/efi_loader.h > @@ -509,9 +509,6 @@ struct efi_register_notify_event { > struct list_head handles; > }; > > -/* List of all events registered by RegisterProtocolNotify() */ > -extern struct list_head efi_register_notify_events; > - > /* called at pre-initialization */ > int efi_init_early(void); > /* Initialize efi execution environment */ > diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c > index caaab685ee..d5065f296a 100644 > --- a/lib/efi_loader/efi_boottime.c > +++ b/lib/efi_loader/efi_boottime.c > @@ -35,7 +35,7 @@ LIST_HEAD(efi_obj_list); > __efi_runtime_data LIST_HEAD(efi_events); > > /* List of queued events */ > -LIST_HEAD(efi_event_queue); > +static LIST_HEAD(efi_event_queue); > > /* Flag to disable timer activity in ExitBootServices() */ > static bool timers_enabled = true; > @@ -44,7 +44,7 @@ static bool timers_enabled = true; > bool efi_st_keep_devices; > > /* List of all events registered by RegisterProtocolNotify() */ > -LIST_HEAD(efi_register_notify_events); > +static LIST_HEAD(efi_register_notify_events); > > /* Handle of the currently executing image */ > static efi_handle_t current_image; > -- > 2.34.1 > Reviewed-by: Ilias Apalodimas