From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EEEEC761A6 for ; Mon, 3 Apr 2023 09:57:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7BAAE854C8; Mon, 3 Apr 2023 11:56:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="DdK0+hEl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B372285827; Mon, 3 Apr 2023 11:56:55 +0200 (CEST) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A0B8180B98 for ; Mon, 3 Apr 2023 11:56:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ed1-x535.google.com with SMTP id cn12so114986247edb.4 for ; Mon, 03 Apr 2023 02:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680515812; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oKtE9E7qdIESlwPS5WYT5GFq8x6QP8v5r01LgXCLuwI=; b=DdK0+hElQrz7ttLuMyqv13Q78wf/KpDh9vhpbLQcuimI6Ahv4o6XxB+BY1O0obb+Lu czYsYrltf8QMwx7N1YibyWRX+mbjuMFyAMk/5XgCHMGC1S4U2Sj2ECtifAGuXkQz23rr 3drLkYNtZOLBMCwQkdfe9HxXIuvk7RdH063RlCOLaO3zF6oyexY3eliel8RCQB3DQPTg rjDXV/FwO7bcz+iPiOxjuV+JFa8b6Klzn4q3DvOkSP4lLKYE7mcpxuvx4ppP7xYiXJbY SCpClnINEvQrey8xhlA514GxqFV6L1pRFcaHCiDl7CbhPPSHUZsF/e/UZvNU/56XpSqP tmGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680515812; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oKtE9E7qdIESlwPS5WYT5GFq8x6QP8v5r01LgXCLuwI=; b=kxI5b6XO1We9QxuuM44s7dZghCfDmZ1NQ4AZ4LFn9zFxskCHhRW+UzX/TuXYuhgVqa Z6zbEG7bSUoEU/d4ChcZDuWRgqopM0nbxjhtn8CAhsnaAeDJolx164gNMlYE47z1csT6 l09Hl9aUXVNSAeV4ftA2tGrn/Pdr2wRG2BrdHCglubmJeg9IBjogPcECingVboqfnSPT iJ5zVoTwMjtZU3CK/3W1RCHCo6vM3GDyf/CbE82mHiXBueVQhzmAELkyQ663h7knaKi7 AZPb9g6PLPZj9xyH4VCOXqwe7QdaozRWiYd6tVL7vQVb21KRIfg54i2F5KBS8RfiIfgw 11cA== X-Gm-Message-State: AAQBX9f2hGnyIR2DNdIn1cCYKpci3JpkELARDfHUZ7IumqX4FwCLJOOT 0kLUS3sKFa39mggGJ1kbjt0Q4Q== X-Google-Smtp-Source: AKy350YGLzFt1vYCQpEnkCKVbojwi+lr8v/7mJ4QLkQ50sgfd7r4Aecnl0o6uvmoPhwCZR0IQpDoaQ== X-Received: by 2002:a17:906:70c9:b0:91d:a049:17a9 with SMTP id g9-20020a17090670c900b0091da04917a9mr34494187ejk.36.1680515812146; Mon, 03 Apr 2023 02:56:52 -0700 (PDT) Received: from hera (ppp176092130041.access.hol.gr. [176.92.130.41]) by smtp.gmail.com with ESMTPSA id m15-20020a170906258f00b009255b14e91dsm4257817ejb.46.2023.04.03.02.56.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 02:56:51 -0700 (PDT) Date: Mon, 3 Apr 2023 12:56:49 +0300 From: Ilias Apalodimas To: Simon Glass Cc: Tom Rini , Heinrich Schuchardt , U-Boot Mailing List , Vagrant Cascadian , huang lin , Jeffy Chen , Kever Yang , Philipp Tomsich Subject: Re: [PATCH v5 3/8] bootstd: Support booting EFI where multiple options exist Message-ID: References: <20230331102559.v5.1.Id5a4b4ee7b653591dfb25e75204c17215521164b@changeid> <20230331102559.v5.3.Ifa423a8f295b3c11e50821222b0db1e869d0c051@changeid> <20230331180222.GB13222@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Sat, Apr 01, 2023 at 07:31:49PM +1300, Simon Glass wrote: > Hi Tom, > > On Sat, 1 Apr 2023 at 07:02, Tom Rini wrote: > > > > On Fri, Mar 31, 2023 at 10:25:56AM +1300, Simon Glass wrote: > > > > > The current EFI implementation has a strange quirk where it watches > > > loaded files and uses the last-loaded file to determine the device that > > > is being booted from. > > > > > > This is confusing with bootstd, where multiple options may exist. Even > > > loading a device tree will cause it to go wrong. There is no API for > > > passing this information, since the only entry into booting an EFI image > > > is the 'bootefi' command. > > > > > > To work around this, call efi_set_bootdev() for EFI images, if possible, > > > just before booting. > > > > > > Signed-off-by: Simon Glass > > > > Shouldn't this all be a simple wrapper around the EFI Standard > > BootDeviceOrder or whatever that's called? > > I think you are referring to boot manager, which isn't used here. This > is replicating the existing distroboot functionality in standard boot. The distroboot functionality *was* trying to behave like the EFI spec expects the bootmanager to behave. Unfortunately I haven't had time to review the distroboot patches closely, but back when this started, my point was that EFI doesn't need anything. Whenever the EFI flow is added bootstd should 'just' call the bootmanager. Regards/Ilias > I've been trying to tease out the rules around finding the image and > the devicetree files, and this is what I've got it. > > Regards, > Simon