From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DAD5C76196 for ; Mon, 3 Apr 2023 13:18:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DA6A985C98; Mon, 3 Apr 2023 15:17:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="uLQowZ19"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D1DBF85C98; Mon, 3 Apr 2023 15:17:57 +0200 (CEST) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 024B485B74 for ; Mon, 3 Apr 2023 15:17:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=linux+u-boot=lists.denx.de@armlinux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=SpuK2a3wX26UmFGy/i63X6Bi715aQcQ+QI13BV8QfSE=; b=uLQowZ19fx+/EyT3UcKz2mfWmL SeNcgi+i7qXAaHWSKZM5RukXuwFx/fipqZ9O+4+S0KyHxQ7kSXp18YvcJ86pMmLtlpM2O1NeIbh8c 5OBdII5Zth65SIxf6k20cPnpqcFoBYmn6VmTYYreNSOZexopcSA0/sO7fIDSRtpt9PjCj1QsbNSVY 3LHXpAlSNuI7nIr+eqOFQ/R0ng+ewPVXtr1aw5k+CpGVwgAZJn3RrMT33L1TNUx0cMBlcPhiwdd4I mxLuWSzWqriEFlaso0MLdmxs7+Nnmtqz0OsPhnlEod5uKHiiCFh8ZzwGM/qATLltycGVdK9Jeh7OP yfgpbGBw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45106) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pjK4E-0002pL-Mr; Mon, 03 Apr 2023 14:17:50 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pjK49-0004Gl-FQ; Mon, 03 Apr 2023 14:17:45 +0100 Date: Mon, 3 Apr 2023 14:17:45 +0100 From: "Russell King (Oracle)" To: Christoph Fritz Cc: Kever Yang , U-Boot Mailing List , Quentin Schulz , Heiko Stuebner , Tony Xie , JuliusWerner , DanHandley , Rockchip , linux-arm-kernel@lists.infradead.org, op-tee@lists.trustedfirmware.org, tf-a@lists.trustedfirmware.org, =?utf-8?B?5byg5a2m5bm/?= Subject: Re: rk3399 issue: no DMA in Linux with mainline TF-A and U-Boot SPL Message-ID: References: <80286c54-c617-d790-b7dc-efd4e52259eb@rock-chips.com> <31b64d9aa694524d60c814469d620c8e15479222.camel@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <31b64d9aa694524d60c814469d620c8e15479222.camel@googlemail.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Mon, Apr 03, 2023 at 12:11:40PM +0200, Christoph Fritz wrote: > > > >      The ARM PL330 DMA driver in kernel only relate to: > > > > - DTS kernel used, can be check in /proc/device-tree/ > > > > - kernel driver which should mach the compatible name. > > drivers/dma/pl330.c needs also a successfully matched amba, but this > fails when using mainline TF-A and U-Boot SPL. > > I'm using the same kernel and devicetree on both tests, the only thing > changed is TF-A and U-Boot SPL vs mini-loader and rk3399_bl31. > > > This driver should has nothing to do with U-Boot SPL or TF-A, because we > > don't have any special setting for PL330 in loader stage. > > It is drivers/amba/bus.c, which is unable to find an AMBA_CID on the > ARM bus. The DMA driver not loading is just a symptom of this issue. That brings up the obvious question: why is it unable to find the AMBA CID? Is that because some resource needed to read it hasn't been enabled yet? If the AMBA CID is not accessible, presumably the rest of the PL330 also isn't accessible, so even if we could bind the driver, it still wouldn't work? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!