* [PATCH 1/1] efi_loader: avoid using HandleProtocol in initrddump.efi
@ 2023-04-04 5:23 Heinrich Schuchardt
2023-04-04 7:35 ` Ilias Apalodimas
0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2023-04-04 5:23 UTC (permalink / raw)
To: Ilias Apalodimas; +Cc: u-boot, Heinrich Schuchardt
HandleProtocol() is deprecated and leaves an OpenedProtocolInformation
behind. Use OpenProtocol(GET_PROTOCOL) instead.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
lib/efi_loader/initrddump.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/efi_loader/initrddump.c b/lib/efi_loader/initrddump.c
index 971a3b6236..5b470f4819 100644
--- a/lib/efi_loader/initrddump.c
+++ b/lib/efi_loader/initrddump.c
@@ -291,8 +291,9 @@ static efi_status_t get_initrd(void **initrd, efi_uintn_t *initrd_size)
error(u"Load File2 protocol not found\r\n");
return ret;
}
- ret = bs->handle_protocol(handle, &load_file2_guid,
- (void **)&load_file2_prot);
+ ret = bs->open_protocol(handle, &load_file2_guid,
+ (void **)&load_file2_prot, NULL, NULL,
+ EFI_OPEN_PROTOCOL_GET_PROTOCOL);
ret = load_file2_prot->load_file(load_file2_prot, dp, false,
initrd_size, NULL);
if (ret != EFI_BUFFER_TOO_SMALL) {
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] efi_loader: avoid using HandleProtocol in initrddump.efi
2023-04-04 5:23 [PATCH 1/1] efi_loader: avoid using HandleProtocol in initrddump.efi Heinrich Schuchardt
@ 2023-04-04 7:35 ` Ilias Apalodimas
0 siblings, 0 replies; 2+ messages in thread
From: Ilias Apalodimas @ 2023-04-04 7:35 UTC (permalink / raw)
To: Heinrich Schuchardt; +Cc: u-boot
On Tue, Apr 04, 2023 at 07:23:53AM +0200, Heinrich Schuchardt wrote:
> HandleProtocol() is deprecated and leaves an OpenedProtocolInformation
> behind. Use OpenProtocol(GET_PROTOCOL) instead.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> lib/efi_loader/initrddump.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/lib/efi_loader/initrddump.c b/lib/efi_loader/initrddump.c
> index 971a3b6236..5b470f4819 100644
> --- a/lib/efi_loader/initrddump.c
> +++ b/lib/efi_loader/initrddump.c
> @@ -291,8 +291,9 @@ static efi_status_t get_initrd(void **initrd, efi_uintn_t *initrd_size)
> error(u"Load File2 protocol not found\r\n");
> return ret;
> }
> - ret = bs->handle_protocol(handle, &load_file2_guid,
> - (void **)&load_file2_prot);
> + ret = bs->open_protocol(handle, &load_file2_guid,
> + (void **)&load_file2_prot, NULL, NULL,
> + EFI_OPEN_PROTOCOL_GET_PROTOCOL);
> ret = load_file2_prot->load_file(load_file2_prot, dp, false,
> initrd_size, NULL);
> if (ret != EFI_BUFFER_TOO_SMALL) {
> --
> 2.39.2
>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-04 7:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-04 5:23 [PATCH 1/1] efi_loader: avoid using HandleProtocol in initrddump.efi Heinrich Schuchardt
2023-04-04 7:35 ` Ilias Apalodimas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox