From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42C65C7618D for ; Tue, 4 Apr 2023 07:36:08 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3572185CD4; Tue, 4 Apr 2023 09:35:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="HUQtjIc9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6972E859F2; Tue, 4 Apr 2023 09:35:50 +0200 (CEST) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 74CB885AEC for ; Tue, 4 Apr 2023 09:35:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ed1-x533.google.com with SMTP id r11so126818756edd.5 for ; Tue, 04 Apr 2023 00:35:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680593744; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TqIGTPJ1L7poyXNhm92XcUfCVa5aRSlXKtVguyV/bPk=; b=HUQtjIc91f6jVe/kngbzhddKJZ1P0Qzr+cZWffSOBdv97ObEvB9Vt7iz08FYbonIkl Lk49OHswlJihtg38PyVDgR+8gvVLqC8Sr5KGfiNuoPwritMc+YoU4gAOWaJMougqGWRa 9fcKxnAhjgSYuv5RpwSRGDdPMeSLARa7FP+zk9H+4WPzb9DjuNlaVmD0Xf+wDZGzWS51 5I9WS9sof4sZLBnkkTlghvj6T7F80WVlQE7Bs/T8TpXEBA86Jxh5BX/jEhNnhLhDs/go zmhzW7cyHxJ+JOhd4kEzPk/FcSzFOKdY2LL2QyTolYuGz04YTD5vRooNqvv3GrmzXR/V Urnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680593744; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TqIGTPJ1L7poyXNhm92XcUfCVa5aRSlXKtVguyV/bPk=; b=s/3jpmAhgJxECALOgblP3k44ZTiS5SX1x9tz0/CJYC3RR8lrQ9IoxEM3+tej+ELcEG VqbZGJm/GCvtv4cLizNWtzBRe/D/C+knCA3aXYJK0wMnDjnwpVtbrZhO5/o4gUnf+sIW Y5l1yObmV3f6PEQlOLHJb+jaMAQYDS5GJxm7Ntscpg/K4HTxgciJlYCui3SqxBG6kzwA +ihQu1frwm5fRA9lZq13jobnyXRU4Qltagm/sOdTE9SVTT3BrwOkgVLBWGX/tY1pCrjv vCVJtfFJCs8WWvUX0eJqFxwGutTS5LJVU+fMbPq2dFhFFSZXlXP94Da02KVXF5BbzYaF XUpg== X-Gm-Message-State: AAQBX9f6Wq9sU7z6rj329qmy8g32iGhpzxEwkpa4NEHgzaj6+EHBZT4/ HPD/tNJ8HzXHldI4qxYy89I4Hg== X-Google-Smtp-Source: AKy350ZhJyRSnrOzYQr3xN5IwyxU8NOEIQvSnuTmdQy0WJ5aa+m5gdHr/GO9Ji0jjiIvE93O7NZVTA== X-Received: by 2002:aa7:d3c1:0:b0:4fd:2363:16f2 with SMTP id o1-20020aa7d3c1000000b004fd236316f2mr1495348edr.37.1680593744060; Tue, 04 Apr 2023 00:35:44 -0700 (PDT) Received: from hera (ppp176092130041.access.hol.gr. [176.92.130.41]) by smtp.gmail.com with ESMTPSA id o28-20020a509b1c000000b004aeeb476c5bsm5504194edi.24.2023.04.04.00.35.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 00:35:43 -0700 (PDT) Date: Tue, 4 Apr 2023 10:35:41 +0300 From: Ilias Apalodimas To: Heinrich Schuchardt Cc: u-boot@lists.denx.de Subject: Re: [PATCH 1/1] efi_loader: avoid using HandleProtocol in initrddump.efi Message-ID: References: <20230404052353.25850-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230404052353.25850-1-heinrich.schuchardt@canonical.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Tue, Apr 04, 2023 at 07:23:53AM +0200, Heinrich Schuchardt wrote: > HandleProtocol() is deprecated and leaves an OpenedProtocolInformation > behind. Use OpenProtocol(GET_PROTOCOL) instead. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/initrddump.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lib/efi_loader/initrddump.c b/lib/efi_loader/initrddump.c > index 971a3b6236..5b470f4819 100644 > --- a/lib/efi_loader/initrddump.c > +++ b/lib/efi_loader/initrddump.c > @@ -291,8 +291,9 @@ static efi_status_t get_initrd(void **initrd, efi_uintn_t *initrd_size) > error(u"Load File2 protocol not found\r\n"); > return ret; > } > - ret = bs->handle_protocol(handle, &load_file2_guid, > - (void **)&load_file2_prot); > + ret = bs->open_protocol(handle, &load_file2_guid, > + (void **)&load_file2_prot, NULL, NULL, > + EFI_OPEN_PROTOCOL_GET_PROTOCOL); > ret = load_file2_prot->load_file(load_file2_prot, dp, false, > initrd_size, NULL); > if (ret != EFI_BUFFER_TOO_SMALL) { > -- > 2.39.2 > Reviewed-by: Ilias Apalodimas