From: Leo Liang <ycliang@andestech.com>
To: Bin Meng <bmeng@tinylab.org>
Cc: <u-boot@lists.denx.de>, Nikita Shubin <n.shubin@yadro.com>,
Rick Chen <rick@andestech.com>
Subject: Re: [PATCH v2 6/9] riscv: Change to use positive offset to access relocation entries
Date: Thu, 20 Apr 2023 07:46:44 +0000 [thread overview]
Message-ID: <ZEDt5Mt0pyDMCFvG@ubuntu01> (raw)
In-Reply-To: <20230413062008.981238-6-bmeng@tinylab.org>
On Thu, Apr 13, 2023 at 02:20:05PM +0800, Bin Meng wrote:
> The codes currently skip the very first relocation entry, and have
> an inaccurate comment "skip first reserved entry" indicating that
> the first entry is reserved, but later it references the elements
> in the first relocation entry using a minus offset.
>
> Change to use a positive offset so that there is no need to skip
> the first relocation entry.
>
> Signed-off-by: Bin Meng <bmeng@tinylab.org>
> ---
>
> (no changes since v1)
>
> arch/riscv/cpu/start.S | 19 +++++++------------
> 1 file changed, 7 insertions(+), 12 deletions(-)
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
next prev parent reply other threads:[~2023-04-20 7:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 6:20 [PATCH v2 1/9] riscv: Optimize source end address calculation in start.S Bin Meng
2023-04-13 6:20 ` [PATCH v2 2/9] riscv: Optimize loading relocation type Bin Meng
2023-04-13 6:20 ` [PATCH v2 3/9] tools: prelink-riscv: Cosmetic style fixes Bin Meng
2023-04-13 6:20 ` [PATCH v2 4/9] tools: prelink-riscv: Unmap the ELF image when done Bin Meng
2023-04-13 6:20 ` [PATCH v2 5/9] makefile: riscv: Drop useless argument of prelink-riscv Bin Meng
2023-04-13 6:20 ` [PATCH v2 6/9] riscv: Change to use positive offset to access relocation entries Bin Meng
2023-04-20 7:46 ` Leo Liang [this message]
2023-04-13 6:20 ` [PATCH v2 7/9] riscv: Avoid updating the link register Bin Meng
2023-04-20 7:47 ` Leo Liang
2023-04-13 6:20 ` [PATCH v2 8/9] riscv: spl: Remove relocation sections Bin Meng
2023-04-20 7:48 ` Leo Liang
2023-04-13 6:20 ` [PATCH v2 9/9] riscv: Update alignment for some sections in linker scripts Bin Meng
2023-04-20 7:49 ` Leo Liang
2024-02-14 11:15 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEDt5Mt0pyDMCFvG@ubuntu01 \
--to=ycliang@andestech.com \
--cc=bmeng@tinylab.org \
--cc=n.shubin@yadro.com \
--cc=rick@andestech.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox