From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B17EFC77B7D for ; Wed, 10 May 2023 07:40:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 153BE85A66; Wed, 10 May 2023 09:40:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="f3rFOT3c"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5BB8F85D0B; Wed, 10 May 2023 09:40:23 +0200 (CEST) Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 439CF85A12 for ; Wed, 10 May 2023 09:40:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-30789a4c537so2786681f8f.0 for ; Wed, 10 May 2023 00:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683704420; x=1686296420; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4YX+Cv6wCMMJ9VMs3tzecmEGAAhJcofUYilctXDRDYE=; b=f3rFOT3cFqWvbTh4gUBkwcHjIe9t0nJRgey1ZO31N/sdoFYtwqzYyAMlMm0thyAklR +iCgsYMKb1TVQqA598vvv7wgJer+kssNAtJAi3sjdNcAq4qIy1Eos2K18e8id6GFrcDS XfB5c1lntF2W79ROZj/5iMdKsrl3ed8WGosnFNlxSawGfmGeODI0SWaDgQ0oCUiIYWa9 I7sL/oa6m2XdcjsfGI6b50CBcVnM1VaM25g0uwHJOVWjSlh2AfUgFUfnDw8xZy7PjIy7 o6yBRNvHT+btZ+QPzwmUA4Y8izTdacLm4bGEWFJ2Fz7zJ8VJMfIZFxe9d3Hn6YCeWkOQ x87Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683704420; x=1686296420; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4YX+Cv6wCMMJ9VMs3tzecmEGAAhJcofUYilctXDRDYE=; b=fqSYGfuA0UP/H6snWNuznfKSVorjONfthQKuAFRnhHD9GM2+plaDIBjvFv5HFJ4Zpe 8OBL+QuqpL5Q17jE2gWFf5T6QGQ83QzJr4fP1eRwwrJJU3RrhKI2s3oD3OV9RzI72sf+ lsPCdv2H73uG3YzeLTMRLMUvd2rA4va13UHu9gm/bVxdJbV9S/kW/UJ3UmQnjIF8u0vy gPPnVox6ol/gj9S2QfSlFmb7Wm6DJ8JEjB1qojlLRKaVwhtJ+JeNz2KAh9+4u4crk6Av mK70Afgj+4cMuHLyesdQAeSh8bLKEr26/4SZ5AT1HiNoNyno79VPfh5ziTXB2oRJpg7t Zahw== X-Gm-Message-State: AC+VfDz/URSojJ38Qomq66I2x3IZUdDRbU4pUVBvJukZClr5WLPXj4ru bqtFhJZQfxmM5C1hjjJ8ilNh4A== X-Google-Smtp-Source: ACHHUZ47dkeKfz2U1x+CJhaHayo7zmXSruqYLZ4/uSuSkklU37PRovwWEZobm3jmMjvHC1gtgMK5SQ== X-Received: by 2002:a5d:4b4b:0:b0:306:2cf5:79d7 with SMTP id w11-20020a5d4b4b000000b003062cf579d7mr11327365wrs.17.1683704420686; Wed, 10 May 2023 00:40:20 -0700 (PDT) Received: from hera (ppp176092130041.access.hol.gr. [176.92.130.41]) by smtp.gmail.com with ESMTPSA id e15-20020a5d4e8f000000b0030629536e64sm16518920wru.30.2023.05.10.00.40.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 May 2023 00:40:20 -0700 (PDT) Date: Wed, 10 May 2023 10:40:18 +0300 From: Ilias Apalodimas To: Simon Glass Cc: Maxim Uvarov , u-boot@lists.denx.de, pbrobinson@redhat.com, joe.hershberger@ni.com, rfried.dev@gmail.com Subject: Re: [RFC PATCH 1/5] add lwip-external submodule Message-ID: References: <20230505102529.1254445-1-maxim.uvarov@linaro.org> <20230505102529.1254445-2-maxim.uvarov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On Mon, May 08, 2023 at 08:43:14AM -0600, Simon Glass wrote: > Hi Maxim, > > On Fri, 5 May 2023 at 04:50, Maxim Uvarov wrote: > > > > Signed-off-by: Maxim Uvarov > > --- > > .gitmodules | 3 +++ > > lib/lwip/lwip-external | 1 + > > 2 files changed, 4 insertions(+) > > create mode 100644 .gitmodules > > create mode 160000 lib/lwip/lwip-external > > > > Please no submodules. They are such a pain. If we want the code in > U-Boot, let's put it in U-Boot and upstream our changes as needed. Can you explain a bit more the pain points you are seeing in u-boot with submodules? EDK2 does submodules for openSSL and it's quite convenient, since you dont have to maintain any code, do backports etc. Instead we can just use upstream projects as-is. IMHO we should work on having it as an experimental feature in parallel with the current TCP efforts for a while and have a Kconfig switch. If we are happy in the long run and the code increase isn't prohibitive, we can consider switching permanently Regards /Ilias > > Regards, > Simon