Re: [PATCH v4 1/6] FWU: Add FWU metadata access driver for MTD storage regions

[Ilias Apalodimas <ilias.apalodimas@linaro.org>]

HI Jassi, Michal

Based on the discussion we had on the dt bindings, I am personally ok with
the notion of having those defined internally until we can prove it makes
sense for the to be sent to the dt-schema.

In the future we need to strip those from U-Boot, before we hand over the
DR to the OS, but this is a problem that already exists regardless of this patchset.

Jassi, Michal had some review comments.  Are you going to send a v5 with
those fixed?

Thanks
/Ilias

On Fri, Apr 14, 2023 at 10:09:11AM -0500, Jassi Brar wrote:
> On Fri, Apr 14, 2023 at 8:56 AM Michal Simek <michal.simek@amd.com> wrote:
> > On 4/10/23 05:56, Jassi Brar wrote:
> > > On Wed, 29 Mar 2023 at 07:00, Michal Simek <michal.simek@amd.com> wrote:
> > >> On 3/27/23 23:15, jassisinghbrar@gmail.com wrote:
> > >
> > >>> diff --git a/drivers/fwu-mdata/raw_mtd.c b/drivers/fwu-mdata/raw_mtd.c
> > >>> new file mode 100644
> > >>> index 0000000000..4b1a10073a
> > >>> --- /dev/null
> > >>> +++ b/drivers/fwu-mdata/raw_mtd.c
> > >>> @@ -0,0 +1,272 @@
> > >>> +// SPDX-License-Identifier: GPL-2.0+
> > >>
> > >> Just a note: Did you choose GPL-2.0+ by purpose? Or it is just c&p?
> > >>
> > > just c&p. though isn't that the same as GPL-2.0-or-later ?
> >
> > license choice is up to you. We normally use just gpl-2.0.
> >
> I think more than "we", the subsystem dictates licensing. All FWU code
> is under GPL-2.0-or-later.
> 
> 
> > >>
> > >> As I said this DT binding should be approved first to make sure that we don't
> > >> need to fix DT binding in future. Just simply do it right from the begining.
> > >>
> > > Yes, I will cc Rob in the next submission (I only forgot last time).
> > > However, let us note that fwu-mdata-gpt.yaml isn't blessed either.
> > > I am not sure if there is any reason for the fwu node to even be in
> > > the dts for kernel. But sure it is good to have it eyeballed by the DT
> > > gods.
> >
> > It doesn't really go to kernel.
> > Simon pushed options node directly to dt-schema
> > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/options/u-boot.yaml#L96
> > And that would be also location for this node too.
> >
> Yes, but I have resend the already existisng bindings in uboot. My
> patch only modified them. Not a big problem.
> 
> -j