From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3F9DC77B75 for ; Fri, 19 May 2023 12:21:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 53A0684773; Fri, 19 May 2023 14:21:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="tk23OiU0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AD8F884770; Fri, 19 May 2023 14:21:22 +0200 (CEST) Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D79EB84770 for ; Fri, 19 May 2023 14:21:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3095557dd99so591960f8f.1 for ; Fri, 19 May 2023 05:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684498879; x=1687090879; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=S52W+Zffp7HLx08KIWKsXsgjxCS4O2BQ9AZRJLqcvB8=; b=tk23OiU08dPTsKR6kmt54omhYLVbepeyJWqfHiskLcYr8BOZoj8L+jQtjpleks6wDj 3LfNctttN97Wvr9rkL9//fb6H2wO01+bnhmvxEnAInCw6UVZy+FsPUzTGXuPM8T+ilR4 98QK6afgvg64IWn/CbL70QymaH0j+a3O2G+JErtUN7PYgXKSfV5f0/DEDuxQ59iWkzAM CV6pT1ddblVX6r1047ODnsYhvBTA5Ppvvt3ibTAJPyPkK/RzLIN1oq+W+BeASnBiHW5P +hqG0Gt/pW2aBRYShVsQ18XzUO6gifbeyfpna9THtlAM42L1QdJCuGHb6tSuLiLlAQVt 1itw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684498879; x=1687090879; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S52W+Zffp7HLx08KIWKsXsgjxCS4O2BQ9AZRJLqcvB8=; b=jP4HkqQvdlzCX0nAp1ynB3ch4NPBv2bFIzjazmMs7TinJX1Ms8OAoCKwQQfaYIiiyS fok3y3n4qdbRNM+3r8Offgue7eCzmenNhqrBr+fVYM5n1zwO+Gj/yzt5XWtlazAOyAjW DHZjKGHfttkOpABbIirmMLbR1GoEW0TpNvFVUhbpEbtUSgScYsvzfLGj/u+3lTsL4UJp j0bjxf+nwBnb18fk9nWzDcdy19f4tbgNITvt/3cU8YFppn0wFlChw+QDPuxVSrVbCgtm FXWTsX3N0eeTbTAYXemQ9ksNQe4NlKMhSK3aBMwiB1xjlVcc70IbBtILpRbHBA6W2Adk jDLg== X-Gm-Message-State: AC+VfDzYKZrczRqvOhjhoNm2bT7on39F3Ib3iS2LNG4EhDSfzywN+p6w AoQY9RbTWu360t+NdyY/M/M5HA== X-Google-Smtp-Source: ACHHUZ5iewHBHdM1zDZAGtowIBwQY83GTE5FxTIKF9kljANTMK4HZCWxdl1zHocFp9tD01mjhQbmZQ== X-Received: by 2002:adf:ee05:0:b0:307:9702:dfc8 with SMTP id y5-20020adfee05000000b003079702dfc8mr1616863wrn.48.1684498879213; Fri, 19 May 2023 05:21:19 -0700 (PDT) Received: from hades (ppp176092130041.access.hol.gr. [176.92.130.41]) by smtp.gmail.com with ESMTPSA id y4-20020a7bcd84000000b003f423dfc686sm2204255wmj.45.2023.05.19.05.21.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 05:21:18 -0700 (PDT) Date: Fri, 19 May 2023 15:21:15 +0300 From: Ilias Apalodimas To: Jassi Brar Cc: Michal Simek , Jassi Brar , u-boot@lists.denx.de, etienne.carriere@linaro.org, trini@konsulko.com, sjg@chromium.org, sughosh.ganu@linaro.org, xypron.glpk@gmx.de, takahiro.akashi@linaro.org, Masami Hiramatsu Subject: Re: [PATCH v4 1/6] FWU: Add FWU metadata access driver for MTD storage regions Message-ID: References: <20230327211458.498879-1-jaswinder.singh@linaro.org> <20230327211548.498919-1-jaswinder.singh@linaro.org> <7bad6344-d0af-4ee2-e00f-c708d28fe1b7@amd.com> <7171534b-7d23-6005-183a-bc613bee5368@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean HI Jassi, Michal Based on the discussion we had on the dt bindings, I am personally ok with the notion of having those defined internally until we can prove it makes sense for the to be sent to the dt-schema. In the future we need to strip those from U-Boot, before we hand over the DR to the OS, but this is a problem that already exists regardless of this patchset. Jassi, Michal had some review comments. Are you going to send a v5 with those fixed? Thanks /Ilias On Fri, Apr 14, 2023 at 10:09:11AM -0500, Jassi Brar wrote: > On Fri, Apr 14, 2023 at 8:56 AM Michal Simek wrote: > > On 4/10/23 05:56, Jassi Brar wrote: > > > On Wed, 29 Mar 2023 at 07:00, Michal Simek wrote: > > >> On 3/27/23 23:15, jassisinghbrar@gmail.com wrote: > > > > > >>> diff --git a/drivers/fwu-mdata/raw_mtd.c b/drivers/fwu-mdata/raw_mtd.c > > >>> new file mode 100644 > > >>> index 0000000000..4b1a10073a > > >>> --- /dev/null > > >>> +++ b/drivers/fwu-mdata/raw_mtd.c > > >>> @@ -0,0 +1,272 @@ > > >>> +// SPDX-License-Identifier: GPL-2.0+ > > >> > > >> Just a note: Did you choose GPL-2.0+ by purpose? Or it is just c&p? > > >> > > > just c&p. though isn't that the same as GPL-2.0-or-later ? > > > > license choice is up to you. We normally use just gpl-2.0. > > > I think more than "we", the subsystem dictates licensing. All FWU code > is under GPL-2.0-or-later. > > > > >> > > >> As I said this DT binding should be approved first to make sure that we don't > > >> need to fix DT binding in future. Just simply do it right from the begining. > > >> > > > Yes, I will cc Rob in the next submission (I only forgot last time). > > > However, let us note that fwu-mdata-gpt.yaml isn't blessed either. > > > I am not sure if there is any reason for the fwu node to even be in > > > the dts for kernel. But sure it is good to have it eyeballed by the DT > > > gods. > > > > It doesn't really go to kernel. > > Simon pushed options node directly to dt-schema > > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/options/u-boot.yaml#L96 > > And that would be also location for this node too. > > > Yes, but I have resend the already existisng bindings in uboot. My > patch only modified them. Not a big problem. > > -j