From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CC78C77B7F for ; Sat, 20 May 2023 17:28:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8F99A846FB; Sat, 20 May 2023 19:28:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=in-advantage.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=inadvantage.onmicrosoft.com header.i=@inadvantage.onmicrosoft.com header.b="EbZ4hhVO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C629484703; Sat, 20 May 2023 19:28:05 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20705.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e88::705]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C71E3846F7 for ; Sat, 20 May 2023 19:28:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=in-advantage.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=colin.Foster@in-advantage.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XOJZoL706ZIlRc0x5yQY+PH2CfCUIIoSDpN7XCBovgvSgE5kFdolgMB7S659lEO8m7nfxhryfRNZt71M0PTsSozuGzXX+jd2KNTjzAdVEswQNCN6BARlIju9fX8ZLiq+a968iZCsUQraKvllxdjLql1UMC1/TPEcFwn0edzy1PKdzzzIzJmU0Oy+9k8bLLPseMp4oddu1OlD5iab9fV04utq/LSw6GGmucqmTWH81RreDRlSIgPR7v0P1TzCLy4EFFfCU+2fzu0OoEwNWkPDg7XvLRd3ba/8Gy41Sy/adUmhPKOEpQKH/aecHrmHaUY2pBXDngICdsxsViSk82/sEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KpcfLWue8OY3hgQUBWGlGhw1jwLhwiOVzz+hwg70Uco=; b=QgG28R+YF9rPhwlAMPHX6kKKxaaXdQLrRdJxx9oGEunCxq+7Fixucc1h2Hp745+5Hnpo9XkwPRtSvuIEbJYSp/iVVSKAfgC4WcBjZP6PQsRjOBidXY62ZYcH8b2lVl66PXcDGqmnnv1uFSM965+fSvsZrD9NkKQq0cUiuY04coTRy6OcRs6G+E1S5aBr7Po3lfZxUGnMs9dP1HaLL4VtznBMMBhUQGElPFq8oOkogu5woAFwqpKYtzspEIUGlWboEQlTXU/8srp+t5igmQ+/eg4l2dSyQf3JWEHBP5ILOpzR20wuO/zzZN17CzZsoCZwmt2f7C8wzYeakYzdj/E0ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KpcfLWue8OY3hgQUBWGlGhw1jwLhwiOVzz+hwg70Uco=; b=EbZ4hhVOX921sHf404nkswLMEUUbOpdWzYHpjEY8cW4rztbn5umVl8vRUs0SvaukZXo6GmF3tD1uRnfZgSoDtUaHuhu4ztK7zo2aFjPCdQZytitU/ljOz53hwJRyUnirFj+48LewNz2SJCcufRSlPWODSMJ36U0D/cJ8i9YKDvE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by SA1PR10MB7684.namprd10.prod.outlook.com (2603:10b6:806:38e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.21; Sat, 20 May 2023 17:27:59 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::50f4:806b:a6be:98da]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::50f4:806b:a6be:98da%4]) with mapi id 15.20.6411.025; Sat, 20 May 2023 17:27:59 +0000 Date: Sat, 20 May 2023 10:27:55 -0700 From: Colin Foster To: Roger Quadros Cc: Michael Trimarchi , Dario Binacchi , u-boot@lists.denx.de Subject: Re: U-Boot OMAP GPMC ECC change Message-ID: References: <1944d1d1-399d-dfde-16ae-21a00ff7fbe3@kernel.org> <9ec2a385-a991-c3c1-4bfe-18b79793688d@kernel.org> <5e475f93-bf2c-fa28-f594-e8182e96c0e2@kernel.org> <20fbcbd5-056b-407a-c506-c29b4359d669@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BYAPR08CA0067.namprd08.prod.outlook.com (2603:10b6:a03:117::44) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2351:EE_|SA1PR10MB7684:EE_ X-MS-Office365-Filtering-Correlation-Id: 88d7f15f-3b36-4ad4-4fb9-08db59578e68 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oLX61+GjwkveFr6eE4L5tJBV/kK77+VCIe+sAc4Hva3R9WAjFEzCmdyKrCSeAamhj9hT73kf2BLRBaLP941XsLsxQaHuGlKV6fNq9q+ggP0v299zpF61gIBJ7Y88u7wAC8nwKVfVXWv6aM4ML6LDWrU1PseEmwl0vOsPjpv3uLulPeA6RHhIoX1B3zhB7edo2l5XpWiYuPG6jl+tKkTh5eE8GWIZwhfLAOQVFToye2XDZjYnIA5bC8OERI4WBxzVcJ428dPA1/ZM1oMI4x/jxngQqL2QUmPhvnbjuqpDPmrTcdRcUBeID4tR9B+gOWNUh4/ULjBuVVlqD578Hvq4jOkpbeJ1Up3zlXIp+n8WeYjgIYg6LpIA6ue9vs4h+8AQ7kyTFLR17QRbiNUlGw2yQghGo8U983uqzHpxuOcdyTqwrufoIJer55+0IYSDwXJ7mMgZ4uk0ZArZFdYVxGIkRd3tZzj6E6Ivrol3JaaIrqo9iKxRJEHf0Z4Ug+Iaou9yG+A1ZdtH7SrQQVXBJkYIxmwfDMp4ZsJHkgdv+Vf2tqBET+bk7YqjsrI3BgEBvFGK X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2351.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(7916004)(376002)(136003)(366004)(396003)(39830400003)(346002)(451199021)(6916009)(66946007)(66556008)(4326008)(66476007)(478600001)(54906003)(316002)(86362001)(83380400001)(6506007)(53546011)(26005)(186003)(9686003)(6512007)(44832011)(5660300002)(2906002)(8676002)(6666004)(8936002)(6486002)(33716001)(41300700001)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?e8Ai34bk5SQgUuS3Ex4avOLwstF78pxQnfCs46gxQoBSFnSGcx5oESa9S18i?= =?us-ascii?Q?qqoYGZh2tGM/FvRawMM9rTfRAZ6OLGxbfMuW5XAIQQ6d376VPH2XGKmIYqBf?= =?us-ascii?Q?jxTcqQkeX5R+6f/9DnFmgaPK6oh0dpBl9rOcKtgBY4GnBVh/c9WYwPmkHc0o?= =?us-ascii?Q?0HwYcGd5JXnVk0wFuEuWSz0Q+M7Idzbr564+0sjp67eR+lQRn40Qx/yU2ahx?= =?us-ascii?Q?g5kasz2FU0aWOhLojN2dLbMm8mFPo6lSzJx2b9dtdgylh/lzldQVOjiosjRh?= =?us-ascii?Q?P8ve+qX6sEap06ya7NAqo+Xi0tdY5kJ1PPLX90xJll8vJ2J4TiX+4KTzU4Zu?= =?us-ascii?Q?guh7iGedfk56pCtz4Qx9ATDjmwTDFwIDCkicIGG8kwCYAEr0XC5O2xOhYqGn?= =?us-ascii?Q?mZ90slx1hyVhfSyRVxAql/QUgrYBwzFqhFfyN2TqdnFuyELlyIOBf6JG4P86?= =?us-ascii?Q?nNW6/h7MsU7DZ2MO+ywcHiVgCJf1pprlpGF9unlLIOSHvWo+JHIxh9XgTe0i?= =?us-ascii?Q?+sMF2HWYDWlUNscwxxN8rckmJ5CCN8U5pu7aFDW/lj1H0KDpBo5JCY5OXEiK?= =?us-ascii?Q?KtXCH5aeFBnu8plhfy5wGZLbHGdHpbokIykx/Pd4CdGJEvBlWOpbhJowDLDt?= =?us-ascii?Q?/QM3Cv2Klw28904/bbPnTPbmi6zMuPiE8cgVtLuc4f5EfbAPVwPac3nfNvJv?= =?us-ascii?Q?gDiCpDAL81LZmEG7B7+WQv/vhSXoUW9c+BjUzNVrr+MscauCwGo1rfBj2Plh?= =?us-ascii?Q?vdVJ8wHzpYv+QnHKTzMhX+l3hUqkjh22sac8l0QtQnBNy4nz9NAM0edvSJAu?= =?us-ascii?Q?SIO4CBdYGzfrqE5jLFjHPjPHjzvpBj0SCWb21sKMg0LswZ0K1e3QOThchuCk?= =?us-ascii?Q?dqmwbWFfbl2ntOPcD9TxBGeuieNKzSsTcEN0gC9ZbBgfsSdBDO1BPZ2JsJ0A?= =?us-ascii?Q?FBXoDJwiwGcY3lOfwTlT1YlpHotnlaNubIKfR+4mHJOG0/W6XP/BP9AOmD00?= =?us-ascii?Q?ZjrFivAjYBnhJkkvXZ4uIXxVuNeOGTaA4vC9rv9xglwDseZG21fFE+ybfiCs?= =?us-ascii?Q?ZSv2qEusnaWfXRXbnVa6OBubY87gwA6lYr40Mo2s740eSxWhTkaFUd3HsIpE?= =?us-ascii?Q?kg6ISCWQY6JababwI/vY0PCC7tThV/mAIGcRGf//ZxflB0fC6bgmalNpFy5j?= =?us-ascii?Q?OBCbLxeI/ibmil+wepxIiha23Sr7AZ3kNmeT8DS1R6s7OlyetgtM/OLeWZE6?= =?us-ascii?Q?sS4WBFV2RgiMNvH7eUuav7x7WDDMmLZjtwEyNIuGX7m9/YB6Zfpd8709yaZ3?= =?us-ascii?Q?exrswx7IPoIkc0OE2LfYsu1v5n0BT03/zLFht2bSsEuExxWWdTJNJvcQh6lK?= =?us-ascii?Q?qsMlZ3enPwQEBOJEu3Okgb4JShwLZQi1BFVcWgft2qJiJeHDYKped18XF2tf?= =?us-ascii?Q?Ddnog2KXr6fhma65SA13QfJHdGPbUDExw9g2gArUcbS74v49n+dCid+50bC3?= =?us-ascii?Q?fm8tHcwNAh001B/YlpecZ17SdPTw4gFE8DqeL8NtnvQDA9llZOqnFt8HSbXE?= =?us-ascii?Q?Ki8vi3M+HFG3pT4CrV0gdp23sPEsCUurBKO6i6hrm425UErmMJxeamlqRTDI?= =?us-ascii?Q?Ww=3D=3D?= X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88d7f15f-3b36-4ad4-4fb9-08db59578e68 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2023 17:27:59.3233 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XX0I/FW/l2TdO7BDFx0L8cB+jOLJksTUOwEoKKIXY6O/heOO00dQ//ZeVGOFLpmnuEidXIltHqGgxq9P8z1cbnoDOT5HcgO5lcXO5Mb0cfY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB7684 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Fri, May 19, 2023 at 03:41:34PM +0300, Roger Quadros wrote: > Hi Colin, > > On 19/05/2023 02:19, Colin Foster wrote: > > Hi Roger, > > > >> Can you please share your spl/u-boot.cfg? > > > > Attached > > Couple of questions there > > 1) CONFIG_MTDPARTS_DEFAULT "mtdparts=nandflash:0x20000(xload_raw),0x180000(u-boot),0x180000(u-boot-2),0x1fce0000(main)" > Is this correct and matches with what kernel sees? > I couldn't see the NAND partition table in the Kernel Device tree patch. Yes, this is correct. I intentionally left my MTD Partitions out of the kernel patch, since I don't want any changes I might make to the flash partitions to require further patches. I'm currently at this structure (SPL, 2x U-Boot, and main UBI with A/B partitions and 2x U-Boot Envs) The SD Boot version of U-Boot doesn't use NAND, so it might have a stale partition layout that I'll need to remove / modify. > > 2) > #define CONFIG_SYS_NAND_U_BOOT_OFFS 0x20000 > #define CONFIG_SYS_NAND_U_BOOT_OFFS_REDUND 0x1a0000 > > These don't seem to match what you have defined in MTDPARTS_DEFAULT. > Which one is correct? This matches the above partition layout. 0x180000 + 0x20000 = 0x1a0000. It wasn't until recently I realized I needed to remove CONFIG_SPL_RAW_IMAGE_SUPPORT in order for this fallback to succeed. > > How do you flash the MLO and u-boot image to NAND? I boot to from SD card, then run a commissioning script that contains: ``` echo "Erasing MLO partition $MLO_PART" flash_erase $MLO_PART 0 0 echo "Programming MLO partition" nandwrite -a -p $MLO_PART $MLO_FILE echo "Erasing U-Boot partition $U_BOOT_PART" flash_erase $U_BOOT_PART 0 0 echo "Programming U-Boot partition" nandwrite -a -p $U_BOOT_PART $U_BOOT_FILE echo "Erasing U-Boot redundant partition $U_BOOT_PART_REDUND" flash_erase $U_BOOT_PART_REDUND 0 0 echo "Programming U-Boot redund partition" nandwrite -a -p $U_BOOT_PART_REDUND $U_BOOT_FILE echo "Clearing UBI partition" flash_erase $UBI_PART 0 0 echo "Formatting UBI partition" ubiformat $UBI_PART -y ubiattach -p $UBI_PART echo "Making UBI volumes" ubimkvol /dev/ubi0 -N env1 -s 0x40000 ubimkvol /dev/ubi0 -N env2 -s 0x40000 ubimkvol /dev/ubi0 -N rootfs-a -s 0xc000000 ubimkvol /dev/ubi0 -N rootfs-b -s 0xc000000 echo "Writing rootfs partitions" ubiupdatevol /dev/ubi0_2 $ROOTFS_FILE ubiupdatevol /dev/ubi0_3 $ROOTFS_FILE ``` For all these tests I've been manually running the flash_erase / nandwrite process for the SPL / U-Boot partitions. > > I tried on AM335x-EVM and it works fine both before and after commit 04fcd25873. > > Once change I had to do was to increase the u-boot partition size > as u-boot image does not fit in original partition size. > > -----boot log follows----- > > U-Boot SPL 2023.01-rc4-00381-g04fcd25873-dirty (May 19 2023 - 15:10:15 +0300) > Trying to boot from NAND > > > U-Boot 2023.01-rc4-00381-g04fcd25873-dirty (May 19 2023 - 15:10:15 +0300) > > CPU : AM335X-GP rev 1.0 > Model: TI AM335x EVM > DRAM: 512 MiB > Core: 156 devices, 17 uclasses, devicetree: separate > WDT: Started wdt@44e35000 with servicing every 1000ms (60s timeout) > NAND: 256 MiB > MMC: OMAP SD/MMC: 0 > Loading Environment from FAT... Unable to read "uboot.env" from mmc0:1... > not set. Validating first E-fuse MAC > Net: eth2: ethernet@4a100000, eth3: usb_ether > Hit any key to stop autoboot: 0 > => > > => mtd > > device nand0 , # parts = 10 > #: name size offset mask_flags > 0: NAND.SPL 0x00020000 0x00000000 0 > 1: NAND.SPL.backup1 0x00020000 0x00020000 0 > 2: NAND.SPL.backup2 0x00020000 0x00040000 0 > 3: NAND.SPL.backup3 0x00020000 0x00060000 0 I need to go back to the 4460 datasheet. I looked and don't remember seeing anything about an SPL search. I'd sleep better at night knowing that when the day comes I need to update the SPL, I can do so with some redundancy. Sorry - I'm getting off topic. I'll be back with hardware on Monday to keep looking at this. > 4: NAND.u-boot-spl-os 0x00040000 0x00080000 0 > 5: NAND.u-boot 0x00200000 0x000c0000 0 > 6: NAND.u-boot-env 0x00020000 0x002c0000 0 > 7: NAND.u-boot-env.backup10x00020000 0x002e0000 0 > 8: NAND.kernel 0x00700000 0x00300000 0 > 9: NAND.file-system 0x0f600000 0x00a00000 0 > > > -- > cheers, > -roger