From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C6DEC7EE2E for ; Mon, 22 May 2023 20:34:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 823AD84D05; Mon, 22 May 2023 22:34:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="jEEYng3v"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 994A584D05; Mon, 22 May 2023 22:34:42 +0200 (CEST) Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3AD2F847C5 for ; Mon, 22 May 2023 22:34:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-309438004a6so4104114f8f.2 for ; Mon, 22 May 2023 13:34:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684787679; x=1687379679; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jAqJ/BJY8hiB8/bsM9KyerJ3ZpTjZIuvz5dOXoRZUnc=; b=jEEYng3vDdbmgv129vrLwtveDVSneLSOQHzV0s7ucNYmPag7u/m7L8LvC+9D0PS2ld BshM+TZKawD/+yESCli3cSi1gJek/L8Q/J2pmmI5FUUSnL2/5Nk2K4KjmnapQMqOEO/M 9xuAxnvjo0mMG+drshHjEAuv3F+GO+TyacSUo8QfbdJ7Dv4rfV2gIP9F2/OcxCUJfF6W 2iq2pnXxHc0Qmbdz+UwmGLWwH6qSpYdgof/xGnRv61PxAhy/l9aZfLMsaKpGexPFJhpI HWvSyBfAjqgzv0ImR3UOdEtomUL+2+9/7iYTu2nDaIhXP180oDZEQ9t7nDxRoaWXXreG PKLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684787679; x=1687379679; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jAqJ/BJY8hiB8/bsM9KyerJ3ZpTjZIuvz5dOXoRZUnc=; b=NWU9pI6OL1X+iW4yZXbFM+sM1Z7DQ4lCu1lmm7MfpAYbNuuYvJTBdOfdYOoPiav78k KCIBP0Z9cP4lf5QflkQPscpu/K1oMlfhzzjxxXGMa2c9xD/qW+BcLHjvlzrL8PbyowOm IR69KHDN1JoxAVRIqYS1HDIZuPAm13DeVR7XdV+apqfH1wCG9/zS5c05wCnaoAWUh7Jk lUIeh+6QeaUZE+3KR2gx453KYKQzZALRMAIMeDrDL8sn34oBu+tkHVLV3ahW26qF0z6x 8I5DmWOsoP+PJTpcrAz2fko0djsh4Thj4WEZsWASgRKBwmPHlcLrzQIpYxeufxKIZDhl zoAA== X-Gm-Message-State: AC+VfDw5nCyDdM2pz17QmYGTHjHkLVgzBFkCVZGL6lQ5B+ekHbCuDeRp RQw8RK7ek1D7J836Z7npy5uirQ== X-Google-Smtp-Source: ACHHUZ4dyYkVut9SxmDE5ejGYoIwP7dQUC0jn6ygQUSwZoBj/9IfAKZAIjGIiUxSQVSLkf8Np+Hi0Q== X-Received: by 2002:a5d:694e:0:b0:309:4227:6d1a with SMTP id r14-20020a5d694e000000b0030942276d1amr7248168wrw.70.1684787679572; Mon, 22 May 2023 13:34:39 -0700 (PDT) Received: from hera (ppp176092130041.access.hol.gr. [176.92.130.41]) by smtp.gmail.com with ESMTPSA id s4-20020a5d4244000000b00307bc4e39e5sm8685124wrr.117.2023.05.22.13.34.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 May 2023 13:34:39 -0700 (PDT) Date: Mon, 22 May 2023 23:34:36 +0300 From: Ilias Apalodimas To: Jens Wiklander Cc: u-boot@lists.denx.de, linux-btrfs@vger.kernel.org, Arnd Bergmann , Huan Wang , Angelo Dureghello , Daniel Schwierzeck , Wolfgang Denk , Marek Vasut , Nobuhiro Iwamatsu , Marek Behun , Qu Wenruo , Tom Rini Subject: Re: [PATCH 0/8] Cleanup unaligned access macros Message-ID: References: <20230522122238.4191762-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522122238.4191762-1-jens.wiklander@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Jens On Mon, May 22, 2023 at 02:22:30PM +0200, Jens Wiklander wrote: > Hi, > > There are two versions of get/set_unaligned, get_unaligned_be64, > put_unaligned_le64 etc in U-Boot causing confusion (and bugs). > > In this patch-set, I'm trying to fix that with a single unified version of > the access macros to be used across all archs. This work is inspired by > similar changes in this Linux kernel by Arnd Bergman, > https://lore.kernel.org/lkml/20210514100106.3404011-1-arnd@kernel.org/ > > Thanks, > Jens Thanks for the cleanup. For the series Reviewed-by: Ilias Apalodimas Although I'd like to hear from arch maintainers as well. Tom, This did pass all the CI successfully, but regardless I think it should be pulled into -next. If you want me to pick it up via the TPM tree please let me know. Thanks /Ilias > > Jens Wiklander (8): > arm: use asm-generic/unaligned.h > sh: use asm-generic/unaligned.h > mips: use asm-generic/unaligned.h > m68k: use asm-generic/unaligned.h > powerpc: use asm-generic/unaligned.h > fs/btrfs: use asm/unaligned.h > linux/unaligned: remove unused access_ok.h > asm-generic: simplify unaligned.h > > arch/arm/include/asm/unaligned.h | 21 +------ > arch/m68k/include/asm/unaligned.h | 17 +----- > arch/mips/include/asm/unaligned.h | 23 +------ > arch/powerpc/include/asm/unaligned.h | 18 +----- > arch/sh/include/asm/unaligned.h | 22 +------ > fs/btrfs/crypto/hash.c | 2 +- > include/asm-generic/unaligned.h | 89 +++++++++++++++++++++++----- > include/linux/unaligned/access_ok.h | 66 --------------------- > 8 files changed, 83 insertions(+), 175 deletions(-) > delete mode 100644 include/linux/unaligned/access_ok.h > > -- > 2.34.1 >