From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC2C0C77B75 for ; Tue, 23 May 2023 06:56:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CA755856D6; Tue, 23 May 2023 08:56:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="d8J/UTa4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B6A4C85723; Tue, 23 May 2023 08:56:36 +0200 (CEST) Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9875A8565E for ; Tue, 23 May 2023 08:56:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3f42b984405so43108575e9.3 for ; Mon, 22 May 2023 23:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684824993; x=1687416993; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EXlOsKiF40XqKBn19vu3zTaMbd5nwpW5UauajfyMM/Q=; b=d8J/UTa41IBu0c+gH4ZTVLn4YUemnGzAkgJhlZfISNx3vgmF9YgAIWaZrmSI4Fb0RA mY4h54UYyUe7ZUFDAvu+vffkq7UxEgoIebDb0ChX84ZmStHcGssPlgko+yOpNWeZ0PUp aQhyJEMvkjHkoG5S4wHoGJfad0/dY2+OSCG+iNmoT2nm49TZD7XrFS/8mmvht5gqictM q6Pvxvpini3O61d1RhzjszIdZjshRjh9ohwT2AWwy0BzGME+IIFzWHNiGmNH2khUhEH3 PuYCjjyBbZXYsAFxhvZrNUj+lXRkMib69peHxzoVGOV5MNtNYmFBlJoJpcbU9FrhssLy nE4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684824993; x=1687416993; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EXlOsKiF40XqKBn19vu3zTaMbd5nwpW5UauajfyMM/Q=; b=DbOBAUQ5fQtAdoTTyqlV0Bhe/tXA1XUToQQQ7r/yjQMlRE8JjiOqB3hhr0hnNQ36Li jNohjk/Vv9X6ta02JnLDH58ZC58SFeVBz9M+pwFtX2nRJvCg3u/FZEuMAM0Zs8H7dHCy hakLc3E1dOroxk75IIngxa3yN6mdUK4VYhsZPrXYd04CV88Jaqvb7utcZ0BCg+xr8BjR /PeU6ITvEWht7+NAK2RTVl9FFNCLHwBoR93gNSU8rDJzgctk49sYhfmP8R6DXLtqWprO thqpsWpKIxe2wo4ao2OCqUhDB+twjKZd6My62EIlbhOT7Bdy0QOOaZZCkWSBVkjjj1yO uIlw== X-Gm-Message-State: AC+VfDy8JlxuVu2FsOI8E7U46h7NopAZ+wIhXO7pKJExj3cFnRo5U28T 9B91e8Q+SCqO5uu8PveXnaZZoA== X-Google-Smtp-Source: ACHHUZ4PeRMQCTVR4swRXfRr3Kri/1gW8X5TupSfxzqxvL7MBffFhNPGeg31lRPmqaCpS+bZxP9log== X-Received: by 2002:a05:600c:ac7:b0:3f5:1980:ad43 with SMTP id c7-20020a05600c0ac700b003f51980ad43mr9110281wmr.31.1684824993082; Mon, 22 May 2023 23:56:33 -0700 (PDT) Received: from hera (ppp176092130041.access.hol.gr. [176.92.130.41]) by smtp.gmail.com with ESMTPSA id k6-20020adfe8c6000000b003095a329e90sm9894059wrn.97.2023.05.22.23.56.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 May 2023 23:56:32 -0700 (PDT) Date: Tue, 23 May 2023 09:56:30 +0300 From: Ilias Apalodimas To: Sam Edwards Cc: u-boot@lists.denx.de, Albert ARIBAUD , Alper Nebi Yasak , Andrew Scull , Kever Yang , Michal Simek , Nathan Barrett-Morrison , Peng Fan , Philip Oberfichtner , Philipp Tomsich , Simon Glass , Tom Rini Subject: Re: [RFC PATCH 10/10] arm: migrate away from sections.c Message-ID: References: <20230520205547.1009254-1-CFSworks@gmail.com> <20230520205547.1009254-11-CFSworks@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230520205547.1009254-11-CFSworks@gmail.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Sat, May 20, 2023 at 02:55:47PM -0600, Sam Edwards wrote: > This patch effectively reverts 3ebd1cbc49f0005092d69cf0d9a6e64d7a1c300b. Also 47bd65ef057fb71b02b32741d5cfcaf03e2f0918 ? > > The approach taken in that commit was to have the section-marking > symbols generated into empty sections by the compiler, for the linker > script to include at the correct location. The rationale was that at > the time, the linker considered linker-assigned symbols to be dynamic > when they were in PIC (PIEs or shared libraries), which meant they were > represented at runtime by a R_ARM_ABS32 relocation (by symbol name) > rather than by M_ARM_RELATIVE. > > That commit landed in March 2013, but GNU ld later changed its behavior > on 2016-02-23 to default linker-assigned symbols to dynamic only in > shared libraries (not PIE), so this approach is unnecessary. > > I am removing it, because: > 1) It required keeping sections.c in sync with multiple linker scripts. > 2) It added complexity to the linker scripts, making them less readable. > 3) It added unnecessary sections to the output, which can't be merged > because the sections are sometimes of different types. > 4) The linker may insert sections not explicitly named in the script > somewhere between explicit sections; having the marker symbols > outside of the sections they were marking meant the markers could > end up with an unintended section inserted within that region. > > Signed-off-by: Sam Edwards > Cc: Albert ARIBAUD > Thanks /Ilias