From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84F93EB64D8 for ; Sat, 17 Jun 2023 00:45:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0098F8627B; Sat, 17 Jun 2023 02:45:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="GHYcIAWd"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 781998628F; Sat, 17 Jun 2023 02:45:14 +0200 (CEST) Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6A33D801CD for ; Sat, 17 Jun 2023 02:45:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-6584553892cso362766b3a.0 for ; Fri, 16 Jun 2023 17:45:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686962710; x=1689554710; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=JtavEPR5Zh8UWRvM8gyXbqhrDaOoOm5Jqv2y28oufDY=; b=GHYcIAWdqv/40z7+6l6m0gQ6x5ZPgSEN8TaRPCXr20s1b0Pjm9DOD7qjB3YC9ngX1v 8rEEC0iL9Y/YbVwJATkm8i+iv0zskieK1eiux7jVJASGBTNx3T94x3tt2e+SZh8rXPH1 NIoeuzjbL3vpjut16q3a0ZoSnNCYqNQ5qc99KEIrhVb9pbxiMY5wNbdotNZAKDRi6lG9 A5m9nm+Eo2RDwREeWKMlZ/27Gt1ReW677V2yvKkymNVEIkqcJHhtB1MXco6g+XrYenTM ksLgrBaJiFT3QiZg8mzpmS468HNFu92qdIuTiRQDduOO+Zw4hxx3QMiYLZkFjybyVvXV YSAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686962710; x=1689554710; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JtavEPR5Zh8UWRvM8gyXbqhrDaOoOm5Jqv2y28oufDY=; b=fk5oowV/Sp3+m0CKrFT0HsAC9ES66gtE0GfkU7ZVaivtoxC5M9qWQRlkbJsStdwj0F a0CdBkjgwsPvpzc/bAsFbCtbC0+NS1Xf73PbNGMafxXZ4bNudpqH45p5RQwfROhf4fx/ nlkS5QBcVYZ4QXdBeqgb2unvenWSKFpxwBSgdqUn7WyaPtYGxgk5ZzAlgyQQOhsHLsWz GEpEmXWzBIETSFYD2cOrThOqPoGQR4nFYujoT+MQRvjjxx4ia9thyiTWPzHLeWBZykjM oM/EHKumVARBT3yN/x/MzQp9NJmaljU40OW5B1Bv/Of5a1Q9au0jRYf/wGwFYJzsLCgT JNUw== X-Gm-Message-State: AC+VfDxxgAxQXLw4cOgoxozwWhDjPZquGEPHxtEJmbeT5zMqBKyx3u4l bSQe3kcOhOHkcthdQBTECnyEDA== X-Google-Smtp-Source: ACHHUZ5ereeMG2j/oMvaONJOUHRER84Sy7xN0NtSQriLOq8cMk7kfsw2yo9s7gpJ4kpPx99e4vD3Sw== X-Received: by 2002:a05:6a20:549e:b0:111:77cf:96dd with SMTP id i30-20020a056a20549e00b0011177cf96ddmr4932908pzk.5.1686962709745; Fri, 16 Jun 2023 17:45:09 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:df74:66da:3671:b619]) by smtp.gmail.com with ESMTPSA id 17-20020aa79211000000b00662610cf7a8sm14387449pfo.172.2023.06.16.17.45.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jun 2023 17:45:09 -0700 (PDT) Date: Sat, 17 Jun 2023 09:45:04 +0900 From: AKASHI Takahiro To: Stefan Herbrechtsmeier Cc: u-boot@lists.denx.de, Malte Schmidt , Sughosh Ganu , Stefan Herbrechtsmeier , Etienne Carriere , Heinrich Schuchardt , Ilias Apalodimas , Malte Schmidt , Masahisa Kojima Subject: Re: [PATCH 0/5] Extend mkeficapsule tool to pack multiple payloads Message-ID: Mail-Followup-To: AKASHI Takahiro , Stefan Herbrechtsmeier , u-boot@lists.denx.de, Malte Schmidt , Sughosh Ganu , Stefan Herbrechtsmeier , Etienne Carriere , Heinrich Schuchardt , Ilias Apalodimas , Malte Schmidt , Masahisa Kojima References: <20230616113426.13976-1-stefan.herbrechtsmeier-oss@weidmueller.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230616113426.13976-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Fri, Jun 16, 2023 at 01:34:21PM +0200, Stefan Herbrechtsmeier wrote: > From: Stefan Herbrechtsmeier > > > Currently, the mkeficapsule tool supports at most one payload inside the > capsule. However, the UEFI specification and the u-boot code > support multiple payloads inside one capsule. Extend the tool by > this feature. The tool is kept backwards-compatible, so it can still > be used and called exactly as before if desired. One of reasons why only a single image be included is that I didn't see any strong reason to do so because U-Boot already has an archive format of multiple images, named FIT. I wanted to utilize the existing framework which is widely used on U-Boot and the current implementation of FMP supports this format. It seems to be just enough. Do you have any useful use case of multiple images? -Takahiro Akashi > > Malte Schmidt (5): > mkeficapsule: constify function parameters > mkeficapsule: add support for multiple payloads inside capsule > test: efi_capsule: test a capsule update containing multiple images > doc: uefi: update mkeficapsule documentation > doc: uefi: clarify capsule concept > > doc/develop/uefi/uefi.rst | 73 +- > test/py/tests/test_efi_capsule/conftest.py | 18 +- > .../test_capsule_firmware_raw.py | 46 +- > .../test_capsule_firmware_signed_raw.py | 24 +- > tools/eficapsule.h | 5 - > tools/mkeficapsule.c | 651 +++++++++++++----- > 6 files changed, 622 insertions(+), 195 deletions(-) > > -- > 2.30.2 >