From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F19E7C77B7A for ; Wed, 7 Jun 2023 09:12:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1A2F785FE2; Wed, 7 Jun 2023 11:12:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=tinet.cat Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 82C7285FE5; Wed, 7 Jun 2023 11:12:06 +0200 (CEST) Received: from mx1.tinet.cat (smtp.altanet.org [195.76.233.59]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6726F85FD8 for ; Wed, 7 Jun 2023 11:12:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=tinet.cat Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xdrudis@tinet.cat X-ASG-Debug-ID: 1686129121-12aaf22e97a7760001-4l7tJC Received: from smtp01.tinet.cat (smtp01.tinet.cat [195.77.216.131]) by mx1.tinet.cat with ESMTP id AQarWMn28xQjBNbg; Wed, 07 Jun 2023 11:12:01 +0200 (CEST) X-Barracuda-Envelope-From: xdrudis@tinet.cat X-Barracuda-Effective-Source-IP: smtp01.tinet.cat[195.77.216.131] X-Barracuda-Apparent-Source-IP: 195.77.216.131 Received: from xdrudis.tinet.cat (180.red-79-152-181.dynamicip.rima-tde.net [79.152.181.180]) by smtp01.tinet.cat (Postfix) with ESMTPSA id C340D605DE44; Wed, 7 Jun 2023 11:12:01 +0200 (CEST) Date: Wed, 7 Jun 2023 11:12:00 +0200 From: Xavier Drudis Ferran To: Jagan Teki Cc: Kever Yang , Simon Glass , Philipp Tomsich , Jonas Karlman , u-boot@lists.denx.de, linux-amarula@amarulasolutions.com Subject: Re: [PATCH v2 5/7] phy: rockchip-inno-usb2: Add USB2 PHY for RK3328 Message-ID: X-ASG-Orig-Subj: Re: [PATCH v2 5/7] phy: rockchip-inno-usb2: Add USB2 PHY for RK3328 References: <20230606170918.45581-1-jagan@amarulasolutions.com> <20230606170918.45581-6-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230606170918.45581-6-jagan@amarulasolutions.com> X-Barracuda-Connect: smtp01.tinet.cat[195.77.216.131] X-Barracuda-Start-Time: 1686129121 X-Barracuda-URL: https://webmail.tinet.cat:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 1206 X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: INNOCENT GLOBAL 0.5371 1.0000 0.7500 X-Barracuda-Spam-Score: 0.75 X-Barracuda-Spam-Status: No, SCORE=0.75 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=6.0 KILL_LEVEL=8.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.109715 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean El Tue, Jun 06, 2023 at 10:39:16PM +0530, Jagan Teki deia: > USB2.0 Host and OTG controllers in RK3328 are using USB2PHY. > > Add support for it. > > Signed-off-by: Jagan Teki Reviewed-by: Xavier Drudis Ferran (fwiw, I just compared it with linux) I just wanted to note this patch as written most likely depends on https://patchwork.ozlabs.org/project/uboot/patch/464111fca83008503022e8ada5305e69ffd1afbd.1685974993.git.xdrudis@tinet.cat/ which introduces the struct member clkout_ctl used here. > --- > Changes for v2: > - add clkout_ctl > > drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 34 +++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c > index e43a5ba9b5..d8738f891d 100644 > --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c > +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c > @@ -345,6 +345,36 @@ bind_fail: > return ret; > } > > +static const struct rockchip_usb2phy_cfg rk3328_usb2phy_cfgs[] = { > + { > + .reg = 0x100, > + .clkout_ctl = { 0x108, 4, 4, 1, 0 }, [...]