From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E258C7EE25 for ; Mon, 12 Jun 2023 07:48:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DA48085C2B; Mon, 12 Jun 2023 09:48:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id B937484709; Mon, 12 Jun 2023 09:48:32 +0200 (CEST) Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B46C886020 for ; Mon, 12 Jun 2023 09:48:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 35C7lvr8027121; Mon, 12 Jun 2023 15:47:57 +0800 (+08) (envelope-from ycliang@andestech.com) Received: from ubuntu01 (10.0.12.75) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Mon, 12 Jun 2023 15:47:57 +0800 Date: Mon, 12 Jun 2023 07:47:52 +0000 From: Leo Liang To: Ben Dooks CC: , Rick Chen , Subject: Re: [PATCH 2/3] riscv: implement local_irq_{save,restore} macros Message-ID: References: <20230505080207.11902-1-ben.dooks@sifive.com> <20230505080207.11902-3-ben.dooks@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230505080207.11902-3-ben.dooks@sifive.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-Originating-IP: [10.0.12.75] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 35C7lvr8027121 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Ben, On Fri, May 05, 2023 at 09:02:06AM +0100, Ben Dooks wrote: > Add implementations of the local_irq_{save,restore} macros so that > can be used with riscv. > > Signed-off-by: Ben Dooks > --- > arch/riscv/include/asm/system.h | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/arch/riscv/include/asm/system.h b/arch/riscv/include/asm/system.h > index 9d8e43e394..78093681e5 100644 > --- a/arch/riscv/include/asm/system.h > +++ b/arch/riscv/include/asm/system.h > @@ -7,15 +7,22 @@ > #ifndef __ASM_RISCV_SYSTEM_H > #define __ASM_RISCV_SYSTEM_H > > +#include > + > struct event; > > /* > - * Interrupt configuring macros. > - * > - * TODO > - * > + * Interupt configuration macros > */ > > +#define local_irq_save(__flags) do { \ Can we have this "do" in a new line just like what kernel does? > + __flags = csr_read_clear(CSR_SSTATUS, SR_SIE) & SR_SIE; \ > + } while (0) > + > +#define local_irq_restore(__flags) do { \ > + csr_set(CSR_SSTATUS, __flags & SR_SIE); \ > + } while(0) ^ a space missing > + > /* Hook to set up the CPU (called from SPL too) */ > int riscv_cpu_setup(void *ctx, struct event *event); > If you don't mind, I could make these format modification on my side, so you don't have to spin another patch set. Best regards, Leo > -- > 2.39.2 >