From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0DE5EB64D7 for ; Sat, 17 Jun 2023 00:33:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6E51C847C7; Sat, 17 Jun 2023 02:33:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="qaDADA8l"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 57250857A3; Sat, 17 Jun 2023 02:33:10 +0200 (CEST) Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0703B847B6 for ; Sat, 17 Jun 2023 02:33:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1b515ec39feso2713325ad.0 for ; Fri, 16 Jun 2023 17:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686961985; x=1689553985; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=QaVQ7z+J2pyX8efXoquCzs9PzQ8fl/A7ZMIDjiXPvdo=; b=qaDADA8lBXpdu+mJZziQ3LuOzjCe1XaYv6CN/bRMbo4KrZCd6BfTIXQ8irY0V4Ulam uE8ilzE0NnY/X7/vUh42we4HWaiVOUbYsvVlLxMotnJllWUURaoqCrhXl23E0S9a0ovX OOwSBnAMBGjR8n404jlOMR2zFmN6IxUDuVgMhtFmXXBHAu1KZh9Ixt/atWdiyZwgmgKe AVo52+d5KVa5D3owXAlZvBm6qbLDEgKyTJq+efJmKlifSmCHFMmCQad1ZRm8XLwjWeIf cGMONBCXczTLU5qMSnmWpnauE8Z+NXhvjtXTW7WPZ602vKKS5muJjrZ0T3tg78OhszHB MbMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686961985; x=1689553985; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QaVQ7z+J2pyX8efXoquCzs9PzQ8fl/A7ZMIDjiXPvdo=; b=FblqRHGit1XZmM+4u/sk5VN/+/nGOr3RpSQ0HRDNzjgFwghZW4tjw0SZg+D+SEEz35 GugDJ9K+5pGAoheHXdffBhI8tDeilMLI3QA/veUID6QShUpEjPM6frAeVfMI8a5f1Dl0 Lyx8i43KSMu3fK1JTDsX4fQDSlHrPu8v/5CDz6vGy4qeeoxQvoShgJoAfWkw8dn+QXLe NY7c4cfdOHWOlcDyFhDmKZH48z+BoZKD8xoLQnXnEpIuusCQIHu7p7NF0GXUt4rHXHTC EBnda0L/WWF06omLQm8GXpEbc7O6IZGkW0rQfczjjpuWlcjj5O7iYY72yQS3hos6UcJi XTCA== X-Gm-Message-State: AC+VfDyKFNRb4wV0bh8fg1ifHl7dOywtyUEKWafUn9sS/u7PtmO17oSD UJfhKvyDCbC9VeHjXh9Kz8Wnow== X-Google-Smtp-Source: ACHHUZ4sGnZ8eFwUZO9sgitvdX1Q4XN8vFUoS6vTor74ta77wBMrqp4kk1x1rvOVQXpQc7izcEYVSg== X-Received: by 2002:a17:903:32c4:b0:1b0:3cda:6351 with SMTP id i4-20020a17090332c400b001b03cda6351mr4235484plr.0.1686961985130; Fri, 16 Jun 2023 17:33:05 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:df74:66da:3671:b619]) by smtp.gmail.com with ESMTPSA id d22-20020a170902b71600b001b521b6e03dsm2857419pls.1.2023.06.16.17.33.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jun 2023 17:33:04 -0700 (PDT) Date: Sat, 17 Jun 2023 09:33:00 +0900 From: AKASHI Takahiro To: Stefan Herbrechtsmeier Cc: u-boot@lists.denx.de, Malte Schmidt , Malte Schmidt , Stefan Herbrechtsmeier , Etienne Carriere , Ilias Apalodimas , Masahisa Kojima , Sughosh Ganu Subject: Re: [PATCH v1] mkeficapsule: fix efi_firmware_management_capsule_header data type Message-ID: Mail-Followup-To: AKASHI Takahiro , Stefan Herbrechtsmeier , u-boot@lists.denx.de, Malte Schmidt , Malte Schmidt , Stefan Herbrechtsmeier , Etienne Carriere , Ilias Apalodimas , Masahisa Kojima , Sughosh Ganu References: <20230616082805.4652-1-stefan.herbrechtsmeier-oss@weidmueller.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230616082805.4652-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Fri, Jun 16, 2023 at 10:28:05AM +0200, Stefan Herbrechtsmeier wrote: > From: Malte Schmidt > > The data type of item_offset_list shall be UINT64 according to the UEFI [1] > specifications. > > In include/efi_api.h the correct data type is used. The bug was probably > never noticed because of little endianness. Thank you. Just in case, tools/eficapsule.h has the same struct definition because I didn't want to include U-Boot's corresponding header to avoid including a conflicting header file. Please fix it as well. -Takahiro Akashi > > [1] https://uefi.org/specs/UEFI/2.10/index.html > > Signed-off-by: Malte Schmidt > > Signed-off-by: Stefan Herbrechtsmeier > --- > > tools/eficapsule.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/eficapsule.h b/tools/eficapsule.h > index 753fb73313..2099a2e9b8 100644 > --- a/tools/eficapsule.h > +++ b/tools/eficapsule.h > @@ -63,7 +63,7 @@ struct efi_firmware_management_capsule_header { > uint32_t version; > uint16_t embedded_driver_count; > uint16_t payload_item_count; > - uint32_t item_offset_list[]; > + uint64_t item_offset_list[]; > } __packed; > > /* image_capsule_support */ > -- > 2.30.2 >