From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C53C7EB64D9 for ; Mon, 19 Jun 2023 11:19:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CE8C5862B3; Mon, 19 Jun 2023 13:19:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ThV1wgoB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1F135862E9; Mon, 19 Jun 2023 13:18:55 +0200 (CEST) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2D20F86309 for ; Mon, 19 Jun 2023 13:18:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-qt1-x831.google.com with SMTP id d75a77b69052e-3fdd37c16bfso9950561cf.1 for ; Mon, 19 Jun 2023 04:18:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687173519; x=1689765519; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=LTw4qYyB9VKFM8TyH1d74fF5H2kcmd1I6u+hq2X03XY=; b=ThV1wgoB9DlEznV2RwcSdf8nhrXIvRAzB2Xyw27x9cgDdXvpTFdyPn9HesvPxHx5jT yGuptWVH38B++kKWfoZnYvo06cVRpww2NYX1V2lXF/v5xgCgIAGvSDZTDnM3qq5+bW8c 4Yxsv02Lj16IcMvilB7z5t0SaMobE1sdRvKHwHuVxaFBthjwzP/Luw0MwFZgnaKGajlB 7wKnhxgXhSmqmh0SjDtyzErdNSuy24P/5wRHaWTqdBIbkT857CW6nlQfYC72bdOOVNJD U4hsDtT8kdz+/KEQqPQ69KdY1R0T7kp/JnLVWlmUao3BNtyKYkkgaZ/KUJcRMkzaM8vL xbgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687173519; x=1689765519; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LTw4qYyB9VKFM8TyH1d74fF5H2kcmd1I6u+hq2X03XY=; b=ISjz2BDhgvSTjpykxPAEBaUkqDtgRz29lbDIA7Tqq88R+VEQDoWtzuLKgS5rkkdZkn QzuA36gudoMSH0vQOh2hjas0OKM4JFEAfUL7yceZEhoGgd2hx3diy126qlxeUp1Z3rho cKHvi8GvAZdMGZQjC0n9HKsmCsJPPa08s8tEixYEP+K/h+Xm08cjncd9ueogs/Pvb7fN 6V53f0zfsF5nrLtf4ojo8rO+urjKDs4zZfo432a/xeQiKOWQHDAp8i4dKWIH2rmHD2Rc r0+u1rzpEbOyYRPKmBoTJ9ye96VljE/Ij2MaYcI3lqo2KXFlIKj8N7kJ8SrdJRXXS4J5 hQbw== X-Gm-Message-State: AC+VfDydJbMDknOd+cOQJh85NMsrNY6Nr5KTP7168QzhLsYFQ0/zQZ2e VK3eTRxXFqwwdJknTk5fus4tYVfMR4Iecp5E69M= X-Google-Smtp-Source: ACHHUZ4TPyyiBzHpVd3+EV8vzY4seXMPxTNHP2mBplxEwA7g92QxFxmno+Z+tN8nSVCgkB2Qf2DZVQ== X-Received: by 2002:a17:90b:3ecd:b0:255:cbad:594f with SMTP id rm13-20020a17090b3ecd00b00255cbad594fmr11864483pjb.1.1687171505373; Mon, 19 Jun 2023 03:45:05 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:7540:94e3:d1be:6785]) by smtp.gmail.com with ESMTPSA id 4-20020a17090a198400b0025643e5da99sm1154318pji.37.2023.06.19.03.45.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jun 2023 03:45:05 -0700 (PDT) Date: Mon, 19 Jun 2023 19:45:00 +0900 From: AKASHI Takahiro To: "Schmidt, Malte" Cc: Stefan Herbrechtsmeier , u-boot@lists.denx.de, Malte Schmidt , Stefan Herbrechtsmeier , Etienne Carriere , Ilias Apalodimas , Masahisa Kojima , Sughosh Ganu Subject: Re: [PATCH v1] mkeficapsule: fix efi_firmware_management_capsule_header data type Message-ID: Mail-Followup-To: AKASHI Takahiro , "Schmidt, Malte" , Stefan Herbrechtsmeier , u-boot@lists.denx.de, Malte Schmidt , Stefan Herbrechtsmeier , Etienne Carriere , Ilias Apalodimas , Masahisa Kojima , Sughosh Ganu References: <20230616082805.4652-1-stefan.herbrechtsmeier-oss@weidmueller.com> <8e7a9dff-8404-4ae0-41c2-f7faf25e9422@weidmueller.com> <15c75ba8-bcb3-a604-d79f-3e28c876be13@weidmueller.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15c75ba8-bcb3-a604-d79f-3e28c876be13@weidmueller.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Mon, Jun 19, 2023 at 12:37:48PM +0200, Schmidt, Malte wrote: > Hello Takahiro, > > Am 19.06.2023 um 11:53 schrieb AKASHI Takahiro: > > On Mon, Jun 19, 2023 at 11:45:49AM +0200, Schmidt, Malte wrote: > > > Hello Takahir, > > > > > > Am 17.06.2023 um 02:33 schrieb AKASHI Takahiro: > > > > On Fri, Jun 16, 2023 at 10:28:05AM +0200, Stefan Herbrechtsmeier wrote: > > > > > From: Malte Schmidt > > > > > > > > > > The data type of item_offset_list shall be UINT64 according to the UEFI [1] > > > > > specifications. > > > > > > > > > > In include/efi_api.h the correct data type is used. The bug was probably > > > > > never noticed because of little endianness. > > > > Thank you. > > > > Just in case, tools/eficapsule.h has the same struct definition > > > > because I didn't want to include U-Boot's corresponding header > > > > to avoid including a conflicting header file. > > > > > > > > Please fix it as well. > > > > > > > > -Takahiro Akashi > > > Which header should I fix additionally? In include/efi_api.h the correct > > > type is used, so there is nothing to fix. > > That is tools/eficapsule.h > > > > -Takahiro Akashi > tools/eficapsule is the file to which my patch applies to. Please have > another > look at it. Otherwise, please explain a bit more detailed what your are > suggesting, > as I am a bit confused about what your point is. Right, it's my misunderstanding. -Takahiro Akashi > Best Regards > Malte > > > > > Best Regards > > > Malte > > > > > [1] https://uefi.org/specs/UEFI/2.10/index.html > > > > > > > > > > Signed-off-by: Malte Schmidt > > > > > > > > > > Signed-off-by: Stefan Herbrechtsmeier > > > > > --- > > > > > > > > > > tools/eficapsule.h | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/tools/eficapsule.h b/tools/eficapsule.h > > > > > index 753fb73313..2099a2e9b8 100644 > > > > > --- a/tools/eficapsule.h > > > > > +++ b/tools/eficapsule.h > > > > > @@ -63,7 +63,7 @@ struct efi_firmware_management_capsule_header { > > > > > uint32_t version; > > > > > uint16_t embedded_driver_count; > > > > > uint16_t payload_item_count; > > > > > - uint32_t item_offset_list[]; > > > > > + uint64_t item_offset_list[]; > > > > > } __packed; > > > > > /* image_capsule_support */ > > > > > -- > > > > > 2.30.2 > > > > > >