Re: [PATCH v7 4/7] board: asus: transformer: add ASUS Transformer T30 family support

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]

On Fri, Jun 23, 2023 at 08:55:57AM +0300, Svyatoslav Ryhel wrote:
[...]
> diff --git a/board/asus/transformer-t30/pinmux-config-transformer.h b/board/asus/transformer-t30/pinmux-config-transformer.h
> new file mode 100644
> index 0000000000..96ff45d375
> --- /dev/null
> +++ b/board/asus/transformer-t30/pinmux-config-transformer.h
> @@ -0,0 +1,365 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2010-2013, NVIDIA CORPORATION.  All rights reserved.
> + *
> + * Copyright (c) 2021, Svyatoslav Ryhel.
> + */

I don't recall if we discussed this during upstreaming of the Linux
device tree files, but shortly after the initial support for Tegra20 and
Tegra30 was upstreamed (both in U-Boot and in Linux) we decided to move
towards generating the pinmux configuration for the various consumers
(i.e. U-Boot and Linux) from data tables using a set of scripts. This
was done because we noticed that various inconsistencies kept creeping
into the various drivers/tables.

You can find the scripts for this here:

	https://github.com/NVIDIA/tegra-pinmux-scripts

I think there'd be some benefit if these new boards were also converted
to use these scripts.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]