From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65606C0015E for ; Fri, 23 Jun 2023 11:32:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7BECB861D4; Fri, 23 Jun 2023 13:32:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="sQJzHgwN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 184EE8638B; Fri, 23 Jun 2023 13:32:36 +0200 (CEST) Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2C9438467C for ; Fri, 23 Jun 2023 13:32:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=thierry.reding@gmail.com Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3fa7cd95dacso5657235e9.3 for ; Fri, 23 Jun 2023 04:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687519952; x=1690111952; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=xpZZuZDmfxZkPps4VupfTSwmdRfVPsScw8mFwx4bdRM=; b=sQJzHgwN28TxEQBSNPS6vWFe2PI081AKoZQZxaHzPzUMy97fSPGdn6JHmeUUntlYMz e17CUUpw1BVjxI8+DIFZZpwwKT1JY+x9yTw83vLKuq1RdMPU6jJtvTeuMWe4SNNbFNNq oYDK7RAu7s2qArYTd7dFww6iEqWPy9HBIGKzSXOWCWJYMbB8HfFz+6uZi72JCMKpBQ3S xVBe48dVkC1kmLYRRN0D5o5XlhB3fvMPOSK9bEkTbqcPJbedqij4hJ5Sv6JZPCV6tZuf ez0/+xi0ZrIu/oO3yndPRT/DHaizbyY9doPeplTd1I/P3U+Kbo0JTRklYjr59w7JZ2C/ bqUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687519952; x=1690111952; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xpZZuZDmfxZkPps4VupfTSwmdRfVPsScw8mFwx4bdRM=; b=NSLFDtQG7MB2W20tOeSudP1KC0U90x/8ZgttH5eFpJyNJSWi8IRXoYhFWlP/g7+yKT 7ClC96ewsABMHYYgUEd2gsYuNzwbNK1agy6MoilBWQ20GItZ9+LPt6WQThsQsYHwkQ+E 33nrfgb71vWB5x7VW+xmD6JGkG+8BMr1B3fdiC86SV68kr4yoUlMv1TTeI9f8Rf0PfSi q1EDhuce2hMhXmbRV6Q82X1XJra4He5r92q76jrd3s+h8/39tviqAywV+HmsIqDOJ8z1 qLyOdTRpZDgeb9OlWo0QbBp9DoDOGeqjzisNvw/ZhLmBaipLxieil1ZTIeEF1TuIc4aw VEYA== X-Gm-Message-State: AC+VfDzn942nmshVEf09d1QzxwS6Kfe+8X1W8azJ/rOmYUxksQ0+Pc05 cnV9p1oxVIEdFUSW3j9MTTc= X-Google-Smtp-Source: ACHHUZ6BEh4lLVOgsHTP9M7JnyyhWf/RIdxDgpO+lWCttaG3fRkpCmmxUV6/MzbF5erm4OzDWzWzjQ== X-Received: by 2002:a05:600c:c6:b0:3fa:7d90:7ac5 with SMTP id u6-20020a05600c00c600b003fa7d907ac5mr982094wmm.29.1687519952480; Fri, 23 Jun 2023 04:32:32 -0700 (PDT) Received: from orome (p200300e41f305300f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f30:5300:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id m15-20020a056000008f00b0030e5bd253aasm9264561wrx.39.2023.06.23.04.32.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 04:32:32 -0700 (PDT) Date: Fri, 23 Jun 2023 13:32:30 +0200 From: Thierry Reding To: Svyatoslav Ryhel Cc: Thierry Reding , Tom Warren , Tom Rini , Simon Glass , Jonas =?utf-8?B?U2Nod8O2YmVs?= , u-boot@lists.denx.de Subject: Re: [PATCH v7 4/7] board: asus: transformer: add ASUS Transformer T30 family support Message-ID: References: <20230623055600.246416-1-clamor95@gmail.com> <20230623055600.246416-5-clamor95@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/YdkPNmaamJFM70o" Content-Disposition: inline In-Reply-To: <20230623055600.246416-5-clamor95@gmail.com> User-Agent: Mutt/2.2.10 (2023-03-25) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --/YdkPNmaamJFM70o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 23, 2023 at 08:55:57AM +0300, Svyatoslav Ryhel wrote: [...] > diff --git a/board/asus/transformer-t30/pinmux-config-transformer.h b/board/asus/transformer-t30/pinmux-config-transformer.h > new file mode 100644 > index 0000000000..96ff45d375 > --- /dev/null > +++ b/board/asus/transformer-t30/pinmux-config-transformer.h > @@ -0,0 +1,365 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) 2010-2013, NVIDIA CORPORATION. All rights reserved. > + * > + * Copyright (c) 2021, Svyatoslav Ryhel. > + */ I don't recall if we discussed this during upstreaming of the Linux device tree files, but shortly after the initial support for Tegra20 and Tegra30 was upstreamed (both in U-Boot and in Linux) we decided to move towards generating the pinmux configuration for the various consumers (i.e. U-Boot and Linux) from data tables using a set of scripts. This was done because we noticed that various inconsistencies kept creeping into the various drivers/tables. You can find the scripts for this here: https://github.com/NVIDIA/tegra-pinmux-scripts I think there'd be some benefit if these new boards were also converted to use these scripts. Thierry --/YdkPNmaamJFM70o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmSVgs4ACgkQ3SOs138+ s6FcSQ//XZ0cQ2KCBH540SYeXM7V1n0G590/kuFnUKaOeLFmjkU2k82mBFxBS4Rv IK+pDpjD87jBFtzF7VeAiCqq4B2oxLPiw8PM6+wzvgmplmQOlCv5WPAkAi11ndzM HAmXAIaCwqOgM6RvSLjb30MphSExDxLtFR3JPue5FHX+wnIF5UlObhDxwAJIE20g 9arfU4KKhKjKte4UVpKW14+qvMbYtbVwMjNxVd4eVXFJM466b2Q791qFm5eIRrbG Wv/MvK+III1S2WM4d6W8w0ubS5gPzmDPwH1vQeAMU9hsGCQDDmi/Cdpe1HaHVBNf JKQKh6OKY3dC8tfDaOedWcSs0OWTkLjM7OQplP+C2xoo7MlGudc93hl4EjNgXGUD HjWA5kARwD4NAdmyv/9BhiwOOw/Ir1YoAO2AFEFV7Nq1OllUIZoqxOtX+WHM3lIN fiqkH4AJBy8opao4l0OBh528fdit//kJ+mQ9f3WZGGYbKcQ3Z281VgCC/01SiPpg lF4cu6GNY1drK+Us3k5tnQkstC2lfQzjpcTx54wC+KNHYjOxLg45KXBjUnkuP6Tx V1v9+2WEUiaDmVpi+qxWUUMOY/4tBx1NpTrzy0HV+yoa1mlXG0OsFWNlMgRB51A3 eec0eTpmPhjVc0m2OOGCLbwIHomiq89I4+HBiipNfztHN+/ZYcQ= =pYJZ -----END PGP SIGNATURE----- --/YdkPNmaamJFM70o--