From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BFA9EB64DD for ; Fri, 23 Jun 2023 14:26:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3C2318638B; Fri, 23 Jun 2023 16:26:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="PHDWtHFo"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7D1D0863C1; Fri, 23 Jun 2023 16:26:47 +0200 (CEST) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 881BD861CA for ; Fri, 23 Jun 2023 16:26:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=thierry.reding@gmail.com Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3f9c2913133so8777865e9.1 for ; Fri, 23 Jun 2023 07:26:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687530403; x=1690122403; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=98ReU04hqFxwbcNB4+K7ecB6HFs1WOAzz/6PpzIlhhQ=; b=PHDWtHFouhlG0+nW6Y3gVJ/O/ShQ8VwqynKWOECc+FROQFchsc6KeSWPMXI2uPzgFC O5Q6PsNnW2AdEXyvJdLeSf4/ldDr/QXz1+agp1QQ6XmHXpSafyVHDmLIcRQVHubCw7Gl vonWzxT/PptLU67mCv7j26WA0G1/HjbLOE+uENFesM1bTzpErEygOiJm9QlwsF8JN6jm Tz2hx2XRf5W+rpEuPKpGrEMnvNaFrLb/YwpOkgTCZFpGkrAtOYE/+0OalVZXP3QZ7DWc MxIOoN+vQSi4+xauRKYsTuMy0lnqZ0Qh8nVWWQqOdtkXE/z9AbXcnJ0EoCmohNcMD+FG RlxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687530403; x=1690122403; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=98ReU04hqFxwbcNB4+K7ecB6HFs1WOAzz/6PpzIlhhQ=; b=fjCGycyoTeBX/xlrwoejgb50Kw9sg9fnE0Rlt1m978g0t47A2y0XJ5oE6u9FZOKZsv C5YEQ4s3pVm/QyPqJ189MdHGAuDfscNO3Nj8zQmVfAsd+mkAQV1oKNM6O04DyDNTpz7m YG7Qe4nVYWcok5FVOuNG7r6se3moUz6/G69FTTcy/QUdQOQ/b7Uz8EioJbuunSD8N4sf vtmzvtmtsl2e0Ws4ZK2w8EtNyIpTWmqxfXN6BIkjI9pBPV3172CnmlkqGiLgV8Zhbu5Q pq/QCcy6zuymAo3owtM8sirMv0Y8JT1irdS1IQ5iKCtqPq91CyHDo37NNplTced9pekd BRDg== X-Gm-Message-State: AC+VfDxDcRYiLDJkSmIHC/nwZvWzEjKEXvilSgq2MYZvG9dh1wlg5tuv pksAZTs9q4j3uHJrFJHVg8I= X-Google-Smtp-Source: ACHHUZ5Xqb+RGRHjf5sLI5GtDcx6gMo/bisN3HUqCXT0eQUVDksmVgwRmnHcfo5CM7EC2nwGcP5Adw== X-Received: by 2002:a7b:c014:0:b0:3f8:f1db:d206 with SMTP id c20-20020a7bc014000000b003f8f1dbd206mr16006809wmb.25.1687530402782; Fri, 23 Jun 2023 07:26:42 -0700 (PDT) Received: from orome (p200300e41f305300f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f30:5300:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id m5-20020adffe45000000b002fae7408544sm9646930wrs.108.2023.06.23.07.26.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 07:26:42 -0700 (PDT) Date: Fri, 23 Jun 2023 16:26:40 +0200 From: Thierry Reding To: Svyatoslav Ryhel Cc: Thierry Reding , Tom Warren , Tom Rini , Simon Glass , Jonas =?utf-8?B?U2Nod8O2YmVs?= , u-boot@lists.denx.de Subject: Re: [PATCH v7 4/7] board: asus: transformer: add ASUS Transformer T30 family support Message-ID: References: <20230623055600.246416-1-clamor95@gmail.com> <20230623055600.246416-5-clamor95@gmail.com> <7EA055AA-7ACE-4759-B8F0-CABA68402644@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SsVIQX36JDIhPuh5" Content-Disposition: inline In-Reply-To: <7EA055AA-7ACE-4759-B8F0-CABA68402644@gmail.com> User-Agent: Mutt/2.2.10 (2023-03-25) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --SsVIQX36JDIhPuh5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 23, 2023 at 05:19:09PM +0300, Svyatoslav Ryhel wrote: >=20 >=20 > 23 =D1=87=D0=B5=D1=80=D0=B2=D0=BD=D1=8F 2023 =D1=80. 17:11:35 GMT+03:00, = Thierry Reding =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0= =B0=D0=B2(-=D0=BB=D0=B0): > >On Fri, Jun 23, 2023 at 02:51:54PM +0300, Svyatoslav Ryhel wrote: > >>=20 > >>=20 > >> 23 =D1=87=D0=B5=D1=80=D0=B2=D0=BD=D1=8F 2023 =D1=80. 14:32:30 GMT+03:0= 0, Thierry Reding =D0=BD=D0=B0=D0=BF=D0=B8=D1=81= =D0=B0=D0=B2(-=D0=BB=D0=B0): > >> >On Fri, Jun 23, 2023 at 08:55:57AM +0300, Svyatoslav Ryhel wrote: > >> >[...] > >> >> diff --git a/board/asus/transformer-t30/pinmux-config-transformer.h= b/board/asus/transformer-t30/pinmux-config-transformer.h > >> >> new file mode 100644 > >> >> index 0000000000..96ff45d375 > >> >> --- /dev/null > >> >> +++ b/board/asus/transformer-t30/pinmux-config-transformer.h > >> >> @@ -0,0 +1,365 @@ > >> >> +/* SPDX-License-Identifier: GPL-2.0 */ > >> >> +/* > >> >> + * Copyright (c) 2010-2013, NVIDIA CORPORATION. All rights reserv= ed. > >> >> + * > >> >> + * Copyright (c) 2021, Svyatoslav Ryhel. > >> >> + */ > >> > > >> >I don't recall if we discussed this during upstreaming of the Linux > >> >device tree files, but shortly after the initial support for Tegra20 = and > >> >Tegra30 was upstreamed (both in U-Boot and in Linux) we decided to mo= ve > >> >towards generating the pinmux configuration for the various consumers > >> >(i.e. U-Boot and Linux) from data tables using a set of scripts. This > >> >was done because we noticed that various inconsistencies kept creeping > >> >into the various drivers/tables. > >> > > >> >You can find the scripts for this here: > >> > > >> > https://github.com/NVIDIA/tegra-pinmux-scripts > >> > > >> >I think there'd be some benefit if these new boards were also convert= ed > >> >to use these scripts. > >>=20 > >> True, but there is no driver for pinmux which can utilize device tree,= instead u-boot relies on board header. I see the benefit of these pinmux n= odes only if I can verify that they are correct and do not brake devices. W= ould be really bad if at some point devices brake cause nodes were not test= ed. > >>=20 > >> Additionally, shouldn't all supported boards be converted first? > > > >The above repository contains a script that will generate the board > >headers for U-Boot based on a more generic definition of the pinmux > >configuration. Many devices already have headers that were generated > >from those scripts, though it's mostly later boards (Tegra124 and > >onwards). > > > >That said, for many of these boards a spreadsheet exists that contains > >these settings and the tables are generated from that spreadsheet. For > >many of these OEM devices I suspect no such spreadsheet exists, and it > >doesn't necessarily make sense to transcribe this into the tables and > >then convert into board header & DTS snippets. It might be nice to do > >for consistency, but I'll leave it up to you. >=20 > Current tables are dumped from working vendor kernels. It is not that > I like this approach, but I would rather leave an existing setup since > it is well tested and confirmed to be stable enough. No one knows what > htc and asus did with those pins, at least publicly. Okay, fair enough. Thierry --SsVIQX36JDIhPuh5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmSVq6AACgkQ3SOs138+ s6FWyg//aC+ona1L5BD4ZrhI2WL1VQyKNhqCtDjilQaGVYdJYj2hO7f5zEE12q7p VQ8GiZGE//D8pvoHpuWZgrLeWKZh3T1jKRO7AIwtiuUjl83Wi4Sj4dy2ROiqgb+H CnjlYMpHZ0qaQyeJRSseIXsZShwo9zZCmTpJrdKJhzZLmdLG6pUv5CWYiVQmqNdR GJfOPsfkBNHldy5BrLy39Xc21txdpfbplpPENkKMuxXn7CPvQ255jw3j1nTVvjdg 3pwx//8a/qsnutt1QfKncMOMW/i0C5CUvOoOWMi+SumA+rry4uHP5RpNy0Z4CEw1 7gHlxQ7uR/8iEsjYad6+KVvFzAMAZuhn1+z3qcY5z58x2vL63vQ+KhBy3vSq1emS 0W4K29s8P9OtDIqWxLSRJzjxTffsGXyIa4Ex2Tyebkje7GfwoAo9ojb34BHKxtA9 8sJb6j4DBpIhUd/0SoK2fpJHfhi6+u8qcUgwg5dw/c0aX/+zZBTrrciEN4cM9yfr j6CxXiB9rOx2PRrhTRZD/db2lFJVxoB+/s4f0Ezf6dVwcdll9Neju6hTEcxuHV48 Vl2HvuorRRkW86dSbDHALgYrwUox/NP6UhoVN6tyVVgBG/TTOU0rlk7g/nUdLNxf 0qf/3TC58VlgJwnykBT9f+Ywc58lJ1HTjAXDYWzTh8DejLciewU= =FBce -----END PGP SIGNATURE----- --SsVIQX36JDIhPuh5--