Re: [RESEND PATCH v1 1/4] riscv: t-head: licheepi4a: initial support added

Yixun Lan
2023-07-07T14:05:49Z

Hi Leo

On 02:55 Thu 29 Jun , Leo Liang wrote:
> Hi YiXun,
> On Fri, May 26, 2023 at 08:41:04PM +0800, Yixun Lan wrote:
> > Add support for Sipeed's Lichee Pi 4A board which based on
> > T-HEAD's TH1520 SoC, only minimal device tree and serial onsole are enabled,
> > so it's capable of chain booting from T-HEAD's vendor u-boot.
> >
> > Reviewed-by: Wei Fu <wefu@redhat.com>
> > Signed-off-by: Yixun Lan <dlan@gentoo.org>
> > ...
> > diff --git a/board/thead/th1520_lpi4a/board.c b/board/thead/th1520_lpi4a/board.c
> > new file mode 100644
> > index 0000000000..378bab098b
> > --- /dev/null
> > +++ b/board/thead/th1520_lpi4a/board.c
> > @@ -0,0 +1,14 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (c) 2023, Yixun Lan <dlan@gentoo.org>
> > + *
> > + */
> > +
> > +#include <common.h>
> > +
> > +int board_init(void)
> > +{
> > + enable_caches();
>
> There is a compilation warining here at "enable_caches"
> (probably due to cpu_func.h not being included to provide this function)
>
thanks, will fix in v2
>
> Best regards,
> Leo
> > +
> > + return 0;
> > +}

--
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55