From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D5E7EB64D9 for ; Wed, 12 Jul 2023 14:32:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 30D3386AF0; Wed, 12 Jul 2023 16:32:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=dolcini.it Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 62CB286AEE; Wed, 12 Jul 2023 16:32:35 +0200 (CEST) Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 75A4F86AFA for ; Wed, 12 Jul 2023 16:32:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=dolcini.it Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=francesco@dolcini.it Received: from francesco-nb.int.toradex.com (31-10-206-125.static.upc.ch [31.10.206.125]) by mail11.truemail.it (Postfix) with ESMTPA id B291D2034F; Wed, 12 Jul 2023 16:32:31 +0200 (CEST) Date: Wed, 12 Jul 2023 16:32:30 +0200 From: Francesco Dolcini To: Andrew Davis Cc: Francesco Dolcini , u-boot@lists.denx.de, Tom Rini , Emanuele Ghidoli , Vignesh Raghavendra , Francesco Dolcini Subject: Re: [PATCH v1 1/3] arm: k3: Fix ft_system_setup so it can be enabled on any SoC Message-ID: References: <20230712134730.30229-1-francesco@dolcini.it> <20230712134730.30229-2-francesco@dolcini.it> <31f3f0bf-a3d7-18ee-14fc-be951c2a7b94@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <31f3f0bf-a3d7-18ee-14fc-be951c2a7b94@ti.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Wed, Jul 12, 2023 at 09:15:21AM -0500, Andrew Davis wrote: > On 7/12/23 8:47 AM, Francesco Dolcini wrote: > > From: Emanuele Ghidoli > > > > ft_system_setup cannot be enabled on SoC without msmc sram otherwise > > fdt_fixup_msmc_ram function fails causing system reset. > > > > Fix by calling fdt_fixup_msmc_ram only on these specific SoC: > > - J721S2 > > - AM654 > > - J721E > > > > This change was verified to not change anything on any existing board > > (all the J721S2, AM654 and J721E boards requires it, > > none of the remaining k3 boards require it). > > > > Fixes: 30e96a240156 ("arm: mach-k3: Move MSMC fixup to SoC level") > > Signed-off-by: Emanuele Ghidoli > > Signed-off-by: Francesco Dolcini > > --- > > arch/arm/mach-k3/common.c | 20 ++++++++++++-------- > > 1 file changed, 12 insertions(+), 8 deletions(-) > > > > diff --git a/arch/arm/mach-k3/common.c b/arch/arm/mach-k3/common.c > > index 34737a43aa08..f86ccaedc94f 100644 > > --- a/arch/arm/mach-k3/common.c > > +++ b/arch/arm/mach-k3/common.c > > @@ -433,14 +433,18 @@ int fdt_fixup_msmc_ram(void *blob, char *parent_path, char *node_name) > > #if defined(CONFIG_OF_SYSTEM_SETUP) > > int ft_system_setup(void *blob, struct bd_info *bd) > > How about we rename this function to something like ft_msmc_sram_setup(), then only > call it from board_setup for the platforms that needed it. This is partially reverting what you did in commit 30e96a240156 ("arm: mach-k3: Move MSMC fixup to SoC level"). Is this fixup going to be required if tomorrow we have a new board using the AM654 SoC (for example) or not? Depending on this answer we can decide if ft_board_setup or ft_system_setup is the right function to use. Francesco